[Libreoffice-commits] core.git: 2 commits - sal/inc vcl/source

[Chr. Rossmanith]

 sal/inc/rtl/strbuf.hxx       |   13 +++++++++++++
 sal/inc/rtl/string.hxx       |    4 ++--
 sal/inc/rtl/ustrbuf.hxx      |    6 +++---
 sal/inc/rtl/ustring.hxx      |    4 ++--
 vcl/source/control/field.cxx |    2 +-
 5 files changed, 21 insertions(+), 8 deletions(-)

New commits:
commit f447854d0cd92647c66871bdc4b3d1f601f25382
Author: Chr. Rossmanith <ChrRossmanith at gmx.de>
Date:   Wed Feb 6 21:30:57 2013 +0100

    decrement for-loop variable instead of incrementing it
    
    Change-Id: Id989bcf78fc10eb29e9afd89c71e2deb2b98b4d3

diff --git a/vcl/source/control/field.cxx b/vcl/source/control/field.cxx
index 28b8c8e..344b106 100644
--- a/vcl/source/control/field.cxx
+++ b/vcl/source/control/field.cxx
@@ -139,7 +139,7 @@ static sal_Bool ImplNumericGetValue( const OUString& rStr, double& rValue,
             if ( (nFormat == 3) || (nFormat == 6)  || // $1- || 1-$
                  (nFormat == 7) || (nFormat == 10) )  // 1$- || 1 $-
             {
-                for (sal_Int32 i = aStr.getLength()-1; i > 0; i++ )
+                for (sal_Int32 i = aStr.getLength()-1; i > 0; --i )
                 {
                     if ( (aStr[i] >= '0') && (aStr[i] <= '9') )
                         break;
commit 584612a9290445924c3c13d763381ced74c5ebea
Author: Chr. Rossmanith <ChrRossmanith at gmx.de>
Date:   Wed Feb 6 21:49:35 2013 +0100

    improve comments of isEmpty()
    
    Change-Id: I6542470c2d4b27de25e263651e25baf85c7d018d

diff --git a/sal/inc/rtl/strbuf.hxx b/sal/inc/rtl/strbuf.hxx
index 2740c48..fe19227 100644
--- a/sal/inc/rtl/strbuf.hxx
+++ b/sal/inc/rtl/strbuf.hxx
@@ -290,6 +290,19 @@ public:
     }
 
     /**
+      Checks if a string buffer is empty.
+
+      @return   true if the string buffer is empty;
+                false, otherwise.
+
+      @since LibreOffice 4.1
+    */
+    bool isEmpty() const SAL_THROW(())
+    {
+        return pData->length == 0;
+    }
+
+    /**
         Returns the current capacity of the String buffer.
 
         The capacity
diff --git a/sal/inc/rtl/string.hxx b/sal/inc/rtl/string.hxx
index 345827c..1e5aca0 100644
--- a/sal/inc/rtl/string.hxx
+++ b/sal/inc/rtl/string.hxx
@@ -356,8 +356,8 @@ public:
     /**
       Checks if a string is empty.
 
-      @return   sal_True if the string is empty;
-                sal_False, otherwise.
+      @return   true if the string is empty;
+                false, otherwise.
 
       @since LibreOffice 3.4
     */
diff --git a/sal/inc/rtl/ustrbuf.hxx b/sal/inc/rtl/ustrbuf.hxx
index b8bae09..a7d5748 100644
--- a/sal/inc/rtl/ustrbuf.hxx
+++ b/sal/inc/rtl/ustrbuf.hxx
@@ -284,10 +284,10 @@ public:
     /**
       Checks if a string buffer is empty.
 
-      @return   sal_True if the string buffer is empty;
-                sal_False, otherwise.
+      @return   true if the string buffer is empty;
+                false, otherwise.
 
-      @since LibreOffice 4.0
+      @since LibreOffice 4.1
     */
     bool isEmpty() const SAL_THROW(())
     {
diff --git a/sal/inc/rtl/ustring.hxx b/sal/inc/rtl/ustring.hxx
index 7024bf4..1742c35 100644
--- a/sal/inc/rtl/ustring.hxx
+++ b/sal/inc/rtl/ustring.hxx
@@ -446,8 +446,8 @@ public:
     /**
       Checks if a string is empty.
 
-      @return   sal_True if the string is empty;
-                sal_False, otherwise.
+      @return   true if the string is empty;
+                false, otherwise.
 
       @since LibreOffice 3.4
     */