[Libreoffice-commits] core.git: 2 commits - sdext/source vcl/source

[Markus Mohrhard]

 sdext/source/pdfimport/tree/drawtreevisiting.cxx |    2 +-
 sdext/source/pdfimport/tree/pdfiprocessor.cxx    |    4 +++-
 sdext/source/pdfimport/tree/pdfiprocessor.hxx    |    2 +-
 vcl/source/window/dlgctrl.cxx                    |    3 +--
 4 files changed, 6 insertions(+), 5 deletions(-)

New commits:
commit 07ee72672e6966dafccf21ca3349e428c2a9dd0a
Author: Markus Mohrhard <markus.mohrhard at googlemail.com>
Date:   Sun Feb 17 19:53:00 2013 +0100

    coverity: pass by const reference is more efficient
    
    Change-Id: Iec40176a5dd567e667178f07fecd043fe0aa4344

diff --git a/sdext/source/pdfimport/tree/drawtreevisiting.cxx b/sdext/source/pdfimport/tree/drawtreevisiting.cxx
index 8f4c16c..9a38e3d 100644
--- a/sdext/source/pdfimport/tree/drawtreevisiting.cxx
+++ b/sdext/source/pdfimport/tree/drawtreevisiting.cxx
@@ -666,7 +666,7 @@ bool isSpaces(TextElement* pTextElem)
     return true;
 }
 
-bool notTransformed(GraphicsContext GC)
+bool notTransformed(const GraphicsContext& GC)
 {
     return (
         GC.Transformation.get(0,0) ==  100.00 &&
commit c66ec11c41c9519e2f9462ae7fe2b54927f6bc77
Author: Markus Mohrhard <markus.mohrhard at googlemail.com>
Date:   Sun Feb 17 19:50:41 2013 +0100

    coverity: pass by const reference is more efficient
    
    Change-Id: I08cebe4aca8eaa5a2be8c319c2de20de10dbd2d3

diff --git a/sdext/source/pdfimport/tree/pdfiprocessor.cxx b/sdext/source/pdfimport/tree/pdfiprocessor.cxx
index 0e9955f..a457d47 100644
--- a/sdext/source/pdfimport/tree/pdfiprocessor.cxx
+++ b/sdext/source/pdfimport/tree/pdfiprocessor.cxx
@@ -486,9 +486,10 @@ GraphicsContext& PDFIProcessor::getTransformGlyphContext( CharGlyph& rGlyph )
 
   return rGlyph.getGC();
 }
+
 void PDFIProcessor::drawCharGlyphs( rtl::OUString&             rGlyphs,
                                     geometry::RealRectangle2D& rRect,
-                                    GraphicsContext aGC,
+                                    const GraphicsContext& aGC,
                                     ParagraphElement* pPara,
                                     FrameElement* pFrame,
                                     bool bSpaceFlag )
@@ -523,6 +524,7 @@ void PDFIProcessor::drawCharGlyphs( rtl::OUString&             rGlyphs,
       pFrame->updateGeometryWith( pPara );
 
 }
+
 void PDFIProcessor::drawGlyphs( const rtl::OUString&             rGlyphs,
                                 const geometry::RealRectangle2D& rRect,
                                 const geometry::Matrix2D&        rFontMatrix )
diff --git a/sdext/source/pdfimport/tree/pdfiprocessor.hxx b/sdext/source/pdfimport/tree/pdfiprocessor.hxx
index 1e4af25..e86ccfe 100644
--- a/sdext/source/pdfimport/tree/pdfiprocessor.hxx
+++ b/sdext/source/pdfimport/tree/pdfiprocessor.hxx
@@ -116,7 +116,7 @@ namespace pdfi
 
         void drawCharGlyphs( rtl::OUString&             rGlyphs,
                              ::com::sun::star::geometry::RealRectangle2D&  rRect,
-                             GraphicsContext aGC,
+                             const GraphicsContext& aGC,
                              ParagraphElement* pPara,
                              FrameElement* pFrame,
                              bool bSpaceFlag );
diff --git a/vcl/source/window/dlgctrl.cxx b/vcl/source/window/dlgctrl.cxx
index 15078a0..19d68a0 100644
--- a/vcl/source/window/dlgctrl.cxx
+++ b/vcl/source/window/dlgctrl.cxx
@@ -1167,10 +1167,9 @@ static Window* ImplGetLabelFor( Window* pFrameWindow, WindowType nMyType, Window
         // #i100833# MT 2010/02: Group box and fixed lines can also lable a fixed text.
         // See tools/options/print for example.
         sal_Bool bThisIsAGroupControl = (nMyType == WINDOW_GROUPBOX) || (nMyType == WINDOW_FIXEDLINE);
-        Window* pSWindow = NULL;
         // get index, form start and form end
         sal_uInt16 nIndex=0, nFormStart=0, nFormEnd=0;
-        pSWindow = ::ImplFindDlgCtrlWindow( pFrameWindow,
+        Window* pSWindow = ::ImplFindDlgCtrlWindow( pFrameWindow,
                                            pLabel,
                                            nIndex,
                                            nFormStart,