[Libreoffice-commits] core.git: basic/source

Norbert Thiebaud nthiebaud at gmail.com
Tue Feb 19 13:00:20 PST 2013


 basic/source/comp/codegen.cxx |    6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

New commits:
commit 7f561b9d667de3ec1b5ecef819f553c0cbefb5d6
Author: Norbert Thiebaud <nthiebaud at gmail.com>
Date:   Tue Feb 19 14:54:32 2013 -0600

    coverity#735398 Logically dead code
    
    Change-Id: Iadb7fbd8a1fb1c535a3ed78d4b2f7120b29aeb75
    Reviewed-on: https://gerrit.libreoffice.org/2270
    Reviewed-by: Tor Lillqvist <tml at iki.fi>
    Tested-by: Tor Lillqvist <tml at iki.fi>

diff --git a/basic/source/comp/codegen.cxx b/basic/source/comp/codegen.cxx
index 77542dd..c17ecbb 100644
--- a/basic/source/comp/codegen.cxx
+++ b/basic/source/comp/codegen.cxx
@@ -233,8 +233,8 @@ void SbiCodeGen::Save()
                     case PROPERTY_MODE_SET:
                         ePropType = SbxOBJECT;
                         break;
-                    case PROPERTY_MODE_NONE:
-                        OSL_FAIL( "Illegal PropertyMode PROPERTY_MODE_NONE" );
+                    default:
+                        OSL_FAIL("Illegal PropertyMode");
                         break;
                     }
                     OUString aPropName = pProc->GetPropName();
@@ -295,7 +295,7 @@ void SbiCodeGen::Save()
                             t = (SbxDataType) ( t | SbxARRAY );
                         }
                         // #33677 hand-over an Optional-Info
-                       sal_uInt16 nFlags = SBX_READ;
+                        sal_uInt16 nFlags = SBX_READ;
                         if( pPar->IsOptional() )
                         {
                             nFlags |= SBX_OPTIONAL;


More information about the Libreoffice-commits mailing list