[Libreoffice-commits] core.git: cui/source

Julien Nabet serval2412 at yahoo.fr
Sun Feb 24 04:46:35 PST 2013


 cui/source/options/optinet2.cxx |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

New commits:
commit bd502f4d99a6f1e783d7eaf53e0a4d05f04629c1
Author: Julien Nabet <serval2412 at yahoo.fr>
Date:   Sun Feb 24 13:44:17 2013 +0100

    coverity#735295+735296 Buffer not null terminated
    
    Change-Id: I02693a2f4b2470ad33e6bd7a925aa64e31ad9a58

diff --git a/cui/source/options/optinet2.cxx b/cui/source/options/optinet2.cxx
index 4b2db82..08def31 100644
--- a/cui/source/options/optinet2.cxx
+++ b/cui/source/options/optinet2.cxx
@@ -1043,7 +1043,7 @@ sal_Bool MozPluginTabPage::isInstalled()
     if (!getDllURL(&tempString)) {
         return false;
     }
-    strncpy(realFilePath, tempString.getStr(), NPP_PATH_MAX);
+    strncpy(realFilePath, tempString.getStr(), NPP_PATH_MAX - 1);
     strcat(realFilePath, "/libnpsoplugin" SAL_DLLEXTENSION);
 
     if (0 != strcmp(lnkReferFilePath, realFilePath))
@@ -1094,7 +1094,7 @@ sal_Bool MozPluginTabPage::installPlugin()
     if (!getDllURL(&tempString)) {
         return false;
     }
-    strncpy(realFilePath, tempString.getStr(), NPP_PATH_MAX);
+    strncpy(realFilePath, tempString.getStr(), NPP_PATH_MAX - 1);
     strcat(realFilePath, "/libnpsoplugin" SAL_DLLEXTENSION);
 
     // create the link


More information about the Libreoffice-commits mailing list