[Libreoffice-commits] core.git: 3 commits - basic/source chart2/source sc/source

[Markus Mohrhard]

 basic/source/comp/exprtree.cxx            |    1 +
 chart2/source/view/charttypes/Splines.cxx |    1 +
 sc/source/core/data/conditio.cxx          |    2 ++
 3 files changed, 4 insertions(+)

New commits:
commit e440724eb7febe0072d79683d1a6f3b586575a3f
Author: Markus Mohrhard <markus.mohrhard at googlemail.com>
Date:   Wed Feb 27 10:11:46 2013 +0100

    coverity#982642: add missing break
    
    Change-Id: Iba7cfec5fa1aa9e3a6a3f1e57b8732989238d608

diff --git a/sc/source/core/data/conditio.cxx b/sc/source/core/data/conditio.cxx
index bf364e5..4683b4a 100644
--- a/sc/source/core/data/conditio.cxx
+++ b/sc/source/core/data/conditio.cxx
@@ -1107,6 +1107,7 @@ bool ScConditionEntry::IsValid( double nArg, const ScAddress& rPos ) const
                 rtl::OUString aStr2 = rtl::OUString::valueOf(nArg);
                 bValid = aStr2.indexOf(aStrVal1) == 0;
             }
+            break;
         case SC_COND_ENDS_WITH:
             if(aStrVal1.isEmpty())
             {
@@ -1119,6 +1120,7 @@ bool ScConditionEntry::IsValid( double nArg, const ScAddress& rPos ) const
                 rtl::OUString aStr2 = rtl::OUString::valueOf(nArg);
                 bValid = aStr2.endsWith(aStrVal1) == 0;
             }
+            break;
         case SC_COND_CONTAINS_TEXT:
         case SC_COND_NOT_CONTAINS_TEXT:
             if(aStrVal1.isEmpty())
commit 1544c17ffd548f353916e626a05821f5da07b242
Author: Markus Mohrhard <markus.mohrhard at googlemail.com>
Date:   Thu Feb 28 06:16:46 2013 +0100

    coverity#705626 and coverity#705627: fix memory leak
    
    Change-Id: I68f43d07798ccb3fc3a5ab438992ac74f4cd262a

diff --git a/basic/source/comp/exprtree.cxx b/basic/source/comp/exprtree.cxx
index 1037e77..da77346 100644
--- a/basic/source/comp/exprtree.cxx
+++ b/basic/source/comp/exprtree.cxx
@@ -303,6 +303,7 @@ SbiExprNode* SbiExpression::Term( const KeywordSymbolInfo* pKeywordSymbolInfo )
         SbiConstDef* pConst = pDef->GetConstDef();
         if( pConst )
         {
+            delete pPar;
             if( pConst->GetType() == SbxSTRING )
             {
                 return new SbiExprNode( pParser, pConst->GetString() );
commit ca4e453d760f3001ef34ba0beda4b2e5f7e24be1
Author: Markus Mohrhard <markus.mohrhard at googlemail.com>
Date:   Wed Feb 27 10:23:03 2013 +0100

    make sure that this coverity report is really a false positive
    
    Change-Id: I2ae6312c533bf2dbfcd5fa691c5acaaee61fe8b2

diff --git a/chart2/source/view/charttypes/Splines.cxx b/chart2/source/view/charttypes/Splines.cxx
index 8cb7fcb..a288f12 100644
--- a/chart2/source/view/charttypes/Splines.cxx
+++ b/chart2/source/view/charttypes/Splines.cxx
@@ -497,6 +497,7 @@ void createKnotVector(const lcl_tSizeType n, const sal_uInt32 p, double* t, doub
             {
                 fSum += t[i];
             }
+            assert(p != 0);
             u[j+p] = fSum / p ;
         }
         for (lcl_tSizeType j = n+1; j <= n+1+p; ++j)