[Libreoffice-commits] .: sd/source

Libreoffice Gerrit user logerrit at kemper.freedesktop.org
Sun Jan 6 15:06:31 PST 2013


 sd/source/filter/xml/sdxmlwrp.cxx                 |    4 ++--
 sd/source/ui/controller/slidelayoutcontroller.cxx |    4 ++--
 sd/source/ui/toolpanel/ToolPanelFactory.cxx       |    2 +-
 sd/source/ui/unoidl/sddetect.cxx                  |    2 +-
 4 files changed, 6 insertions(+), 6 deletions(-)

New commits:
commit 5ea7e74c29f7279b6c31d38185ace576f68f4fb2
Author: Markus Mohrhard <markus.mohrhard at googlemail.com>
Date:   Sun Jan 6 23:42:55 2013 +0100

    fix some memory leaks in sd
    
    Change-Id: I7c7d0772a3d10601c6d1a9ea22c697abe762036d

diff --git a/sd/source/filter/xml/sdxmlwrp.cxx b/sd/source/filter/xml/sdxmlwrp.cxx
index 4020a62..285af43 100644
--- a/sd/source/filter/xml/sdxmlwrp.cxx
+++ b/sd/source/filter/xml/sdxmlwrp.cxx
@@ -282,7 +282,7 @@ sal_Int32 ReadThroughComponent(
 
         if( rStreamName.Len() )
         {
-            return *new TwoStringErrorInfo(
+            return TwoStringErrorInfo(
                             (bMustBeSuccessfull ? ERR_FORMAT_FILE_ROWCOL
                                                     : WARN_FORMAT_FILE_ROWCOL),
                             rStreamName, sErr,
@@ -291,7 +291,7 @@ sal_Int32 ReadThroughComponent(
         else
         {
             DBG_ASSERT( bMustBeSuccessfull, "Warnings are not supported" );
-            return *new StringErrorInfo( ERR_FORMAT_ROWCOL, sErr,
+            return StringErrorInfo( ERR_FORMAT_ROWCOL, sErr,
                              ERRCODE_BUTTON_OK | ERRCODE_MSG_ERROR );
         }
     }
diff --git a/sd/source/ui/controller/slidelayoutcontroller.cxx b/sd/source/ui/controller/slidelayoutcontroller.cxx
index bdea29a..5cce3a4 100644
--- a/sd/source/ui/controller/slidelayoutcontroller.cxx
+++ b/sd/source/ui/controller/slidelayoutcontroller.cxx
@@ -331,7 +331,7 @@ Sequence< OUString >  SlideLayoutController_getSupportedServiceNames() throw( Ru
 
 Reference< XInterface > SAL_CALL SlideLayoutController_createInstance( const Reference< XMultiServiceFactory >& rSMgr ) throw( RuntimeException )
 {
-    return *new SlideLayoutController( rSMgr, ".uno:AssignLayout", false );
+    return SlideLayoutController( rSMgr, ".uno:AssignLayout", false );
 }
 
 // --------------------------------------------------------------------
@@ -354,7 +354,7 @@ Sequence< OUString >  InsertSlideController_getSupportedServiceNames() throw( Ru
 
 Reference< XInterface > SAL_CALL InsertSlideController_createInstance( const Reference< XMultiServiceFactory >& rSMgr ) throw( RuntimeException )
 {
-    return *new SlideLayoutController( rSMgr, ".uno:InsertPage" , true );
+    return SlideLayoutController( rSMgr, ".uno:InsertPage" , true );
 }
 
 //========================================================================
diff --git a/sd/source/ui/toolpanel/ToolPanelFactory.cxx b/sd/source/ui/toolpanel/ToolPanelFactory.cxx
index e725293..2fc4d69 100644
--- a/sd/source/ui/toolpanel/ToolPanelFactory.cxx
+++ b/sd/source/ui/toolpanel/ToolPanelFactory.cxx
@@ -101,7 +101,7 @@ namespace sd { namespace toolpanel
     //------------------------------------------------------------------------------------------------------------------
     Reference< XInterface > SAL_CALL ToolPanelFactory_createInstance( const Reference< XComponentContext >& i_rContext )
     {
-        return Reference< XInterface >( *new ToolPanelFactory( i_rContext ) );
+        return Reference< XInterface >( ToolPanelFactory( i_rContext ) );
     }
 
     //------------------------------------------------------------------------------------------------------------------
diff --git a/sd/source/ui/unoidl/sddetect.cxx b/sd/source/ui/unoidl/sddetect.cxx
index 0431e6e..8a8bb94 100644
--- a/sd/source/ui/unoidl/sddetect.cxx
+++ b/sd/source/ui/unoidl/sddetect.cxx
@@ -515,7 +515,7 @@ rtl::OUString SdFilterDetect::impl_getStaticImplementationName()
 /* Helper for registry */
 UNOREFERENCE< UNOXINTERFACE > SAL_CALL SdFilterDetect::impl_createInstance( const UNOREFERENCE< UNOXMULTISERVICEFACTORY >& xServiceManager ) throw( UNOEXCEPTION )
 {
-    return UNOREFERENCE< UNOXINTERFACE >( *new SdFilterDetect( xServiceManager ) );
+    return UNOREFERENCE< UNOXINTERFACE >( SdFilterDetect( xServiceManager ) );
 }
 
 /* vim:set shiftwidth=4 softtabstop=4 expandtab: */


More information about the Libreoffice-commits mailing list