[Libreoffice-commits] .: Branch 'libreoffice-3-6' - sc/source

[Libreoffice Gerrit user]

 sc/source/ui/docshell/dbdocfun.cxx |    3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

New commits:
commit 0490372a127b03dde0397009758289e94862a662
Author: Kohei Yoshida <kohei.yoshida at gmail.com>
Date:   Fri Jan 11 12:51:13 2013 -0500

    Let's not return here to prevent memory leak.
    
    There are several heap objects that are deleted at the end of the
    method.  Returning prematurely would leak those objects.
    
    Change-Id: If70cb3c9c02e47229d10b30f1542f7b25534d593
    Reviewed-on: https://gerrit.libreoffice.org/1654
    Reviewed-by: Markus Mohrhard <markus.mohrhard at googlemail.com>
    Tested-by: Markus Mohrhard <markus.mohrhard at googlemail.com>

diff --git a/sc/source/ui/docshell/dbdocfun.cxx b/sc/source/ui/docshell/dbdocfun.cxx
index 5216c68..9fea320 100644
--- a/sc/source/ui/docshell/dbdocfun.cxx
+++ b/sc/source/ui/docshell/dbdocfun.cxx
@@ -1330,8 +1330,7 @@ bool ScDBDocFunc::DataPilotUpdate( ScDPObject* pOldObj, const ScDPObject* pNewOb
             if ( pDestObj )
             {
                 pDestObj->ReloadGroupTableData();
-                if (!pDestObj->SyncAllDimensionMembers())
-                    return false;
+                pDestObj->SyncAllDimensionMembers();
                 pDestObj->InvalidateData();             // before getting the new output area
 
                 //  make sure the table has a name (not set by dialog)