[Libreoffice-commits] .: sc/source

Libreoffice Gerrit user logerrit at kemper.freedesktop.org
Sat Jan 12 11:26:00 PST 2013


 sc/source/filter/oox/formulabase.cxx |    4 ++++
 1 file changed, 4 insertions(+)

New commits:
commit bad3ddbbb0fbef8a39cbe89db77d7c7053edf0ed
Author: Eike Rathke <erack at redhat.com>
Date:   Sat Jan 12 20:22:56 2013 +0100

    OpCodeProviderImpl::initFuncOpCode: warn if there is no opcode mapping
    
    During loading an xlsx document in an --enable-dbgutil build
    OpCodeProviderImpl::OpCodeProviderImpl() spits out a warning
    "OpCodeProviderImpl::OpCodeProviderImpl - opcodes not initialized"
    
    OpCodeProviderImpl::initFuncOpCode() now gives a clue which.
    
    Change-Id: Ia0bc53ce5a590e6904c660cd725d907efa5a731d

diff --git a/sc/source/filter/oox/formulabase.cxx b/sc/source/filter/oox/formulabase.cxx
index 847beee..6c2441d 100644
--- a/sc/source/filter/oox/formulabase.cxx
+++ b/sc/source/filter/oox/formulabase.cxx
@@ -33,6 +33,7 @@
 #include <com/sun/star/sheet/XFormulaParser.hpp>
 #include <rtl/strbuf.hxx>
 #include <rtl/ustrbuf.hxx>
+#include <sal/log.hxx>
 #include "oox/core/filterbase.hxx"
 #include "oox/helper/containerhelper.hxx"
 #include "oox/token/properties.hxx"
@@ -1228,6 +1229,9 @@ bool OpCodeProviderImpl::initFuncOpCode( FunctionInfo& orFuncInfo, const ApiToke
         {
             // ignore entries for functions unknown by Calc *and* by Excel
             bIsValid = orFuncInfo.maOoxFuncName.isEmpty();
+            SAL_WARN_IF( !bIsValid, "sc",
+                    "OpCodeProviderImpl::initFuncOpCode - no opcode mapping for function ODF '" <<
+                    orFuncInfo.maOdfFuncName << "' <-> OOXML '" << orFuncInfo.maOoxFuncName << "'");
         }
     }
     else if( orFuncInfo.mnBiffFuncId == BIFF_FUNC_EXTERNCALL )


More information about the Libreoffice-commits mailing list