[Libreoffice-commits] .: Branch 'libreoffice-4-0' - sfx2/source

Libreoffice Gerrit user logerrit at kemper.freedesktop.org
Fri Jan 18 01:11:08 PST 2013


 sfx2/source/doc/sfxbasemodel.cxx |    3 ---
 1 file changed, 3 deletions(-)

New commits:
commit 89fb1aee1a9e80e901f9e23ef6239177645b0101
Author: Michael Stahl <mstahl at redhat.com>
Date:   Tue Jan 15 21:25:14 2013 +0100

    fdo#58893: Revert "Resolves: rhbz#818557 crash with NULL shell..."
    
    This reverts commit a1d265be484f1c70f57ab3de9b2d8c27d2fd3aa4.
    
    This commit causes the crash, because apparently it causes some event to
    be delayed via SfxHintPoster which refers to some SfxRequest that is
    then deleted too early.
    
    Change-Id: I301f3b52001c1d8b1b60f5b1cfb3b093c9f81607
    (cherry picked from commit 5090267eada3d68a618769c5dbae8b2ee8d6dab5)
    Reviewed-on: https://gerrit.libreoffice.org/1721
    Reviewed-by: Miklos Vajna <vmiklos at suse.cz>
    Tested-by: Miklos Vajna <vmiklos at suse.cz>

diff --git a/sfx2/source/doc/sfxbasemodel.cxx b/sfx2/source/doc/sfxbasemodel.cxx
index 5dd7d63..540c190 100644
--- a/sfx2/source/doc/sfxbasemodel.cxx
+++ b/sfx2/source/doc/sfxbasemodel.cxx
@@ -1119,10 +1119,7 @@ void SAL_CALL SfxBaseModel::connectController( const uno::Reference< frame::XCon
     {
         SfxViewFrame* pViewFrame = SfxViewFrame::Get( xController, GetObjectShell() );
         ENSURE_OR_THROW( pViewFrame, "SFX document without SFX view!?" );
-        bool bOldLock = pViewFrame->GetDispatcher()->IsLocked();
-        pViewFrame->GetDispatcher()->Lock(sal_True);
         pViewFrame->UpdateDocument_Impl();
-        pViewFrame->GetDispatcher()->Lock(bOldLock);
         const String sDocumentURL = GetObjectShell()->GetMedium()->GetName();
         if ( sDocumentURL.Len() )
             SFX_APP()->Broadcast( SfxStringHint( SID_OPENURL, sDocumentURL ) );


More information about the Libreoffice-commits mailing list