[Libreoffice-commits] .: sc/source

Libreoffice Gerrit user logerrit at kemper.freedesktop.org
Mon Jan 21 09:01:38 PST 2013


 sc/source/core/tool/compiler.cxx |    4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

New commits:
commit aa2b8bde171bf9562536dc14b2cf81d81e31b438
Author: Eike Rathke <erack at redhat.com>
Date:   Mon Jan 21 17:56:25 2013 +0100

    resolved fdo#59583 prevent inappropriate column/row label detection
    
    If followed by '(' (with or without space inbetween) an identifier can
    not be a column/row label. Prevent arbitrary content detection in case a
    macro function of the same name is meant (fdo#59583) or if it wouldn't
    resolve to a known function name at all, that earlier resulted in #REF!
    instead of #NAME? in the case of unknown function but label found.
    
    Change-Id: Id36a0c9ebad2d62867b4f9fe00ae78d464e77109

diff --git a/sc/source/core/tool/compiler.cxx b/sc/source/core/tool/compiler.cxx
index 7b7ab88..ac0d10b 100644
--- a/sc/source/core/tool/compiler.cxx
+++ b/sc/source/core/tool/compiler.cxx
@@ -3686,7 +3686,9 @@ bool ScCompiler::NextNewToken( bool bInArray )
             return true;
         if (IsDBRange( aUpper ))
             return true;
-        if (IsColRowName( aUpper ))
+        // If followed by '(' (with or without space inbetween) it can not be a
+        // column/row label. Prevent arbitrary content detection.
+        if (!bMayBeFuncName && IsColRowName( aUpper ))
             return true;
         if (bMayBeFuncName && IsMacro( aUpper ))
             return true;


More information about the Libreoffice-commits mailing list