[Libreoffice-commits] core.git: filter/source

[Mark Wielaard]

 filter/source/msfilter/msdffimp.cxx |    1 +
 1 file changed, 1 insertion(+)

New commits:
commit 4cf80bd8b2a61d154172fa602aeb0fecbe7a2f67
Author: Mark Wielaard <mark at klomp.org>
Date:   Sun Jul 7 22:18:12 2013 +0200

    Fix memory leak in SvxMSDffManager::ImportShape.
    
    When a new DffPropertyReader is created and assigned to pSecPropSet
    make sure the old one is deleted first.
    
    Change-Id: Idd14fdf4e3a03a625a10a89dde71ad66cbdba792
    Reviewed-on: https://gerrit.libreoffice.org/4761
    Reviewed-by: Petr Mladek <pmladek at suse.cz>
    Tested-by: Petr Mladek <pmladek at suse.cz>

diff --git a/filter/source/msfilter/msdffimp.cxx b/filter/source/msfilter/msdffimp.cxx
index a580c43..e6d8d1e 100644
--- a/filter/source/msfilter/msdffimp.cxx
+++ b/filter/source/msfilter/msdffimp.cxx
@@ -4141,6 +4141,7 @@ SdrObject* SvxMSDffManager::ImportShape( const DffRecordHeader& rHd, SvStream& r
     if ( aObjData.bOpt2 )
     {
         maShapeRecords.Current()->SeekToBegOfRecord( rSt );
+        delete pSecPropSet;
         pSecPropSet = new DffPropertyReader( *this );
         pSecPropSet->ReadPropSet( rSt, NULL );
     }