[Libreoffice-commits] core.git: Branch 'libreoffice-4-1-0' - connectivity/source

Lionel Elie Mamane lionel at mamane.lu
Wed Jul 10 12:50:22 PDT 2013


 connectivity/source/parse/sqliterator.cxx |    1 +
 1 file changed, 1 insertion(+)

New commits:
commit 7802990f3155de25d38f894d1261dc975c37762d
Author: Lionel Elie Mamane <lionel at mamane.lu>
Date:   Wed Jul 10 00:50:11 2013 +0200

    fdo#58644 fix handling of subqueries
    
    don't remove parentheses around subqueries
    (without the parentheses, it is not valid SQL)
    
    Change-Id: I4e9c55cea0276f10b0f97e31bc329949aba5b989
    Reviewed-on: https://gerrit.libreoffice.org/4791
    Reviewed-by: David Tardon <dtardon at redhat.com>
    Reviewed-by: Michael Meeks <michael.meeks at suse.com>
    Reviewed-by: Michael Stahl <mstahl at redhat.com>
    Tested-by: Michael Stahl <mstahl at redhat.com>

diff --git a/connectivity/source/parse/sqliterator.cxx b/connectivity/source/parse/sqliterator.cxx
index 9e51296..6007eb9 100644
--- a/connectivity/source/parse/sqliterator.cxx
+++ b/connectivity/source/parse/sqliterator.cxx
@@ -966,6 +966,7 @@ bool OSQLParseTreeIterator::traverseSelectColumnNames(const OSQLParseNode* pSele
                 sal_Bool bFkt(sal_False);
                 pColumnRef = pColumnRef->getChild(0);
                 if (
+                        pColumnRef->getKnownRuleID() != OSQLParseNode::subquery &&
                         pColumnRef->count() == 3 &&
                         SQL_ISPUNCTUATION(pColumnRef->getChild(0),"(") &&
                         SQL_ISPUNCTUATION(pColumnRef->getChild(2),")")


More information about the Libreoffice-commits mailing list