[Libreoffice-commits] core.git: Branch 'feature/aboutconfig' - 2 commits - cui/source

[Efe Gürkan YALAMAN]

 cui/source/options/optaboutconfig.cxx |   24 ++++++++++++------------
 cui/source/options/optaboutconfig.hxx |   11 +++++------
 2 files changed, 17 insertions(+), 18 deletions(-)

New commits:
commit daeccfaf65a0b312e1a19901de8b223cb3204724
Author: Efe Gürkan YALAMAN <efeyalaman at gmail.com>
Date:   Sun Jul 21 22:05:28 2013 +0300

    InsertEntry method implemented
    
    This is used for the adding new items to the list box.
    
    Change-Id: I6c531141c9dd4df1e050bfec610735c917bf5403

diff --git a/cui/source/options/optaboutconfig.cxx b/cui/source/options/optaboutconfig.cxx
index a130753..e6ec794 100644
--- a/cui/source/options/optaboutconfig.cxx
+++ b/cui/source/options/optaboutconfig.cxx
@@ -9,6 +9,8 @@
 
 #include "optaboutconfig.hxx"
 #include "optHeaderTabListbox.hxx"
+#include <svtools/svlbitm.hxx>
+#include <svtools/treelistentry.hxx>
 
 using namespace svx;
 
@@ -57,4 +59,16 @@ SfxTabPage* CuiAboutConfigTabPage::Create( Window* pParent, const SfxItemSet& rI
 {
     return ( new CuiAboutConfigTabPage( pParent, rItemSet) );
 }
+
+void CuiAboutConfigTabPage::InsertEntry( OUString& rProp, OUString&  rStatus, OUString& rType, OUString& rValue)
+{
+    SvTreeListEntry* pEntry = new SvTreeListEntry;
+
+    pEntry->AddItem( new SvLBoxString( pEntry, 0, rProp));
+    pEntry->AddItem( new SvLBoxString( pEntry, 0, rStatus));
+    pEntry->AddItem( new SvLBoxString( pEntry, 0, rType));
+    pEntry->AddItem( new SvLBoxString( pEntry, 0, rValue));
+
+    pPrefBox->Insert( pEntry );
+}
 /* vim:set shiftwidth=4 softtabstop=4 expandtab: */
diff --git a/cui/source/options/optaboutconfig.hxx b/cui/source/options/optaboutconfig.hxx
index 6848a8f..cdfb1d5 100644
--- a/cui/source/options/optaboutconfig.hxx
+++ b/cui/source/options/optaboutconfig.hxx
@@ -28,12 +28,13 @@ private:
     PushButton* m_pEditBtn;
 
     ::svx::OptHeaderTabListBox* pPrefBox;
+    CuiAboutConfigTabPage( Window* pParent, const SfxItemSet& rItemSet );
+    ~CuiAboutConfigTabPage();
 public:
-   CuiAboutConfigTabPage( Window* pParent, const SfxItemSet& rItemSet );
-   ~CuiAboutConfigTabPage();
-
    static SfxTabPage* Create( Window* pParent, const SfxItemSet& rItemset );
 
+   void     InsertEntry(OUString& rProp, OUString&  rStatus, OUString& rType, OUString& rValue);
+
 };
 
 #endif
commit e81a396053526f9a7c09aefed805b189ecd4e0b9
Author: Efe Gürkan YALAMAN <efeyalaman at gmail.com>
Date:   Sun Jul 21 18:36:58 2013 +0300

    Revert "starting to initial implementation"
    
    This reverts commit 5a3b21b5fb579bcf86eff172862b1c23c499b361.
    Will implement it a different way.

diff --git a/cui/source/options/optaboutconfig.cxx b/cui/source/options/optaboutconfig.cxx
index 864c681..a130753 100644
--- a/cui/source/options/optaboutconfig.cxx
+++ b/cui/source/options/optaboutconfig.cxx
@@ -9,7 +9,6 @@
 
 #include "optaboutconfig.hxx"
 #include "optHeaderTabListbox.hxx"
-#include <svtools/accessibilityoption.hxx>
 
 using namespace svx;
 
@@ -18,17 +17,8 @@ using namespace svx;
 #define ITEMID_STATUS   3
 #define ITEMID_VALUE    4
 
-struct CuiAboutConfigTabPage_Impl
-{
-    SvtAccessibilityOptions     m_aAccConfig;
-    CuiAccessibilityOptionsTabPage_Impl()
-        : m_aAccConfig(){}
-    //FIXME use this struct for all options possible.
-}
-
 CuiAboutConfigTabPage::CuiAboutConfigTabPage( Window* pParent, const SfxItemSet& rItemSet )
-    :SfxTabPage( pParent, "AboutConfig", "cui/ui/aboutconfigdialog.ui", rItemSet),
-    m_pImpl(new CuiAboutConfigTabPage_Impl)
+    :SfxTabPage( pParent, "AboutConfig", "cui/ui/aboutconfigdialog.ui", rItemSet)
 {
     get(m_pDefaultBtn,"default");
     get(m_pEditBtn, "edit");
@@ -67,8 +57,4 @@ SfxTabPage* CuiAboutConfigTabPage::Create( Window* pParent, const SfxItemSet& rI
 {
     return ( new CuiAboutConfigTabPage( pParent, rItemSet) );
 }
-
-sal_Bool CuiAboutConfigTabPage::FillItemSet()
-{
-}
 /* vim:set shiftwidth=4 softtabstop=4 expandtab: */
diff --git a/cui/source/options/optaboutconfig.hxx b/cui/source/options/optaboutconfig.hxx
index a924877..6848a8f 100644
--- a/cui/source/options/optaboutconfig.hxx
+++ b/cui/source/options/optaboutconfig.hxx
@@ -18,7 +18,7 @@ namespace svx
 {
     class OptHeaderTabListBox;
 }
-struct CuiAboutConfigTabPage_Impl;
+class CuiAboutConfigTabPage;
 
 class CuiAboutConfigTabPage : public SfxTabPage
 {
@@ -28,8 +28,6 @@ private:
     PushButton* m_pEditBtn;
 
     ::svx::OptHeaderTabListBox* pPrefBox;
-
-    CuiAboutConfigTabPage_Impl* m_pImpl;
 public:
    CuiAboutConfigTabPage( Window* pParent, const SfxItemSet& rItemSet );
    ~CuiAboutConfigTabPage();