[Libreoffice-commits] core.git: extensions/source

Julien Nabet serval2412 at yahoo.fr
Mon Jun 3 14:10:13 PDT 2013


 extensions/source/ole/jscriptclasses.cxx |    3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

New commits:
commit b532752e7b9407d4d3204d49b601a4725e2e1113
Author: Julien Nabet <serval2412 at yahoo.fr>
Date:   Mon Jun 3 23:09:44 2013 +0200

    Fix variable value reassigned before old value used
    
    Change-Id: Ide65a35d1dd39cbce9230f951bcc229b0df7b634

diff --git a/extensions/source/ole/jscriptclasses.cxx b/extensions/source/ole/jscriptclasses.cxx
index 663450a..58fadbe 100644
--- a/extensions/source/ole/jscriptclasses.cxx
+++ b/extensions/source/ole/jscriptclasses.cxx
@@ -136,9 +136,8 @@ STDMETHODIMP JScriptValue::Invoke( DISPID dispIdMember,
 STDMETHODIMP JScriptValue::Set( VARIANT type, VARIANT value)
 {
     Lock();
-    HRESULT hr= S_OK;
     m_varValue.Clear();
-    hr= VariantCopyInd( &m_varValue, &value);
+    HRESULT hr= VariantCopyInd( &m_varValue, &value);
     VARIANT var;
     VariantInit( &var);
     if( SUCCEEDED( hr= VariantChangeType( &var, &type, 0, VT_BSTR)))


More information about the Libreoffice-commits mailing list