[Libreoffice-commits] core.git: sfx2/source

[Mark Wielaard]

 sfx2/source/dialog/filedlghelper.cxx |    3 ---
 1 file changed, 3 deletions(-)

New commits:
commit f4e7b7758b99aaec99aa333dbd31580286e422d9
Author: Mark Wielaard <mark at klomp.org>
Date:   Tue Jun 4 21:40:27 2013 +0200

    FileDialogHelper_Impl::addFilters. Don't leak matcher.
    
    commit 178fc3 removed the creation of filter matcher and explicitly
    set mbDeleteMatcher to sal_False. commit 551f85 reintroduced the
    matchers, but forgot the remove the explicit setting of mbDeleteMatcher.
    Causing mpMatcher to never get deleted even if a new SfxFilterMatcher
    was created.
    
    Change-Id: I59f085e1c3ce088f9215be60fb7161364bad0cbe
    Reviewed-on: https://gerrit.libreoffice.org/4154
    Reviewed-by: Noel Power <noel.power at suse.com>
    Tested-by: Noel Power <noel.power at suse.com>

diff --git a/sfx2/source/dialog/filedlghelper.cxx b/sfx2/source/dialog/filedlghelper.cxx
index cc9ada9..c9ab00c 100644
--- a/sfx2/source/dialog/filedlghelper.cxx
+++ b/sfx2/source/dialog/filedlghelper.cxx
@@ -1828,9 +1828,6 @@ void FileDialogHelper_Impl::addFilters( const String& rFactory,
 
     TSortedFilterList         aIter   (xResult);
 
-    // no matcher any longer used ...
-    mbDeleteMatcher = sal_False;
-
     // append the filters
     OUString sFirstFilter;
     if (OPEN == lcl_OpenOrSave(m_nDialogType))