[Libreoffice-commits] core.git: dbaccess/source

[Stephan Bergmann]

 dbaccess/source/ui/dlg/generalpage.cxx |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

New commits:
commit fb835e0e8a99caeb7dbb79bf6d935c97d291114c
Author: Stephan Bergmann <sbergman at redhat.com>
Date:   Thu Jun 6 17:21:27 2013 +0200

    -Werror=sign-compare
    
    (ListBox::GetSelectEntryPos returns sal_uInt16)
    
    Change-Id: Ia6e4bf4354523f5112ee3ade1d3da6db0f9ab2c4

diff --git a/dbaccess/source/ui/dlg/generalpage.cxx b/dbaccess/source/ui/dlg/generalpage.cxx
index 0373916..e2b325a 100644
--- a/dbaccess/source/ui/dlg/generalpage.cxx
+++ b/dbaccess/source/ui/dlg/generalpage.cxx
@@ -328,8 +328,8 @@ namespace dbaui
     IMPL_LINK( OGeneralPage, OnDatasourceTypeSelected, ListBox*, _pBox )
     {
         // get the type from the entry data
-        sal_Int16 nSelected = _pBox->GetSelectEntryPos();
-        if (nSelected < 0 || nSelected >= m_aURLPrefixes.size() )
+        sal_uInt16 nSelected = _pBox->GetSelectEntryPos();
+        if (nSelected >= m_aURLPrefixes.size() )
         {
             SAL_WARN("dbaui.OGeneralPage", "Got out-of-range value '" << nSelected <<  "' from the DatasourceType selection ListBox's GetSelectEntryPos(): " << ((nSelected < 0) ? "negative" : "no corresponding URL prefix") );
             return 0L;