[Libreoffice-commits] core.git: vcl/source

Stephan Bergmann sbergman at redhat.com
Thu Jun 13 01:07:35 PDT 2013


 vcl/source/glyphs/graphite_features.cxx |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 9760621b5c93edb829478c284e4b61537824e702
Author: Stephan Bergmann <sbergman at redhat.com>
Date:   Thu Jun 13 10:04:20 2013 +0200

    Work around -Werror=type-limits when plain char is unsigned
    
    ...assuming the original intent of the code was to check for ASCII range 0x20--
    0x7F.
    
    Change-Id: I8033890a76e059d997efb01431207a453f00a981

diff --git a/vcl/source/glyphs/graphite_features.cxx b/vcl/source/glyphs/graphite_features.cxx
index ec33500..609c88b 100644
--- a/vcl/source/glyphs/graphite_features.cxx
+++ b/vcl/source/glyphs/graphite_features.cxx
@@ -207,7 +207,7 @@ bool GrFeatureParser::isCharId(const OString & id, size_t offset, size_t length)
     for (size_t i = 0; i < length; i++)
     {
         if (i > 0 && id[offset+i] == '\0') continue;
-        if ((id[offset+i] < 0x20) || (id[offset+i] < 0))
+        if (id[offset+i] < 0x20 || static_cast<signed char>(id[offset+i]) < 0)
             return false;
         if (i==0 && (id[offset+i] < 0x41))
             return false;


More information about the Libreoffice-commits mailing list