[Libreoffice-commits] core.git: 2 commits - extensions/source

[Stephan Bergmann]

 extensions/source/update/check/download.cxx       |    2 --
 extensions/source/update/check/updateprotocol.cxx |    2 +-
 2 files changed, 1 insertion(+), 3 deletions(-)

New commits:
commit f4a4fee523ff8a6d272eabda2ce9ca96bd3bbbb1
Author: Stephan Bergmann <sbergman at redhat.com>
Date:   Sat Jun 15 01:03:22 2013 +0200

    loplugin:literalalternative
    
    Change-Id: Ie2af2b013f95e8cdf7aab82498ce686dfa965cc8

diff --git a/extensions/source/update/check/updateprotocol.cxx b/extensions/source/update/check/updateprotocol.cxx
index 59ef0d9..7ad26518 100644
--- a/extensions/source/update/check/updateprotocol.cxx
+++ b/extensions/source/update/check/updateprotocol.cxx
@@ -171,7 +171,7 @@ checkForUpdates(
                     {
                         uno::Reference< xml::dom::XElement > xParent(xNode2->getParentNode(), uno::UNO_QUERY_THROW);
                         OUString aType = xParent->getAttribute("type");
-                        bool bIsDirect = ( sal_False == aType.equalsIgnoreAsciiCaseAsciiL(RTL_CONSTASCII_STRINGPARAM("text/html")) );
+                        bool bIsDirect = !aType.equalsIgnoreAsciiCase("text/html");
 
                         o_rUpdateInfo.Sources.push_back( DownloadSource(bIsDirect, xNode2->getNodeValue()) );
                     }
commit c128736aad595cdb4de9ced2b6471f1c05806546
Author: Stephan Bergmann <sbergman at redhat.com>
Date:   Sat Jun 15 00:57:19 2013 +0200

    loplugin:unusedvariablecheck
    
    Change-Id: I2202b5fcca4bf4c0a552d25c5c363209fcb6bd84

diff --git a/extensions/source/update/check/download.cxx b/extensions/source/update/check/download.cxx
index 3ceb70a..4660da3 100644
--- a/extensions/source/update/check/download.cxx
+++ b/extensions/source/update/check/download.cxx
@@ -104,8 +104,6 @@ static void openFile( OutData& out )
 static inline OString
 getStringValue(const uno::Reference< container::XNameAccess >& xNameAccess, const OUString& aName)
 {
-    OString aRet;
-
     OSL_ASSERT(xNameAccess->hasByName(aName));
     uno::Any aValue = xNameAccess->getByName(aName);