[Libreoffice-commits] core.git: chart2/source

Jelle van der Waa jelle at vdwaa.nl
Mon Jun 17 08:03:53 PDT 2013


 chart2/source/tools/ObjectIdentifier.cxx |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

New commits:
commit d30df91b1e5ce90826a96e4f494791c0b61b8b7c
Author: Jelle van der Waa <jelle at vdwaa.nl>
Date:   Mon Jun 17 16:32:16 2013 +0200

    fdo#43460 chart2: use isEmpty()
    
    Change-Id: Ia74923ed8f00adfa3f7758edb4e5755fedb0ec8a
    Reviewed-on: https://gerrit.libreoffice.org/4315
    Reviewed-by: Noel Power <noel.power at suse.com>
    Tested-by: Noel Power <noel.power at suse.com>

diff --git a/chart2/source/tools/ObjectIdentifier.cxx b/chart2/source/tools/ObjectIdentifier.cxx
index 9dc31b1..2358057 100644
--- a/chart2/source/tools/ObjectIdentifier.cxx
+++ b/chart2/source/tools/ObjectIdentifier.cxx
@@ -1005,7 +1005,7 @@ OUString ObjectIdentifier::addChildParticle( const OUString& rParticle, const OU
 {
     OUStringBuffer aRet(rParticle);
 
-    if( aRet.getLength() && !rChildParticle.isEmpty() )
+    if( !aRet.isEmpty() && !rChildParticle.isEmpty() )
         aRet.appendAscii(":");
     if( !rChildParticle.isEmpty() )
         aRet.append(rChildParticle);
@@ -1016,7 +1016,7 @@ OUString ObjectIdentifier::addChildParticle( const OUString& rParticle, const OU
 OUString ObjectIdentifier::createChildParticleWithIndex( ObjectType eObjectType, sal_Int32 nIndex )
 {
     OUStringBuffer aRet( getStringForType( eObjectType ) );
-    if( aRet.getLength() )
+    if( !aRet.isEmpty() )
     {
         aRet.appendAscii("=");
         aRet.append(OUString::valueOf(nIndex));


More information about the Libreoffice-commits mailing list