[Libreoffice-commits] core.git: forms/source

Jelle van der Waa jelle at vdwaa.nl
Mon Jun 17 12:54:04 PDT 2013


 forms/source/xforms/model_ui.cxx                            |    2 +-
 forms/source/xforms/submission/serialization_urlencoded.cxx |    2 +-
 forms/source/xforms/submission/submission_get.cxx           |    2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)

New commits:
commit af7cfa0071f5b2be33e9b887e6221c5047d21262
Author: Jelle van der Waa <jelle at vdwaa.nl>
Date:   Mon Jun 17 20:14:39 2013 +0200

    fdo#43460 forms: use isEmpty()
    
    Change-Id: If51c22cb28646e7af3785cb086fb4a48af0f7d68
    Reviewed-on: https://gerrit.libreoffice.org/4323
    Reviewed-by: Noel Power <noel.power at suse.com>
    Tested-by: Noel Power <noel.power at suse.com>

diff --git a/forms/source/xforms/model_ui.cxx b/forms/source/xforms/model_ui.cxx
index 7e28623..4dec45b 100644
--- a/forms/source/xforms/model_ui.cxx
+++ b/forms/source/xforms/model_ui.cxx
@@ -219,7 +219,7 @@ OUString Model::getDefaultBindingExpressionForNode(
          xCurrent = xCurrent->getParentNode() )
     {
         // insert a '/' for every step except the first
-        if( aBuffer.getLength() > 0 )
+        if( !aBuffer.isEmpty() )
             aBuffer.insert( 0, sal_Unicode('/') );
 
         switch( xCurrent->getNodeType() )
diff --git a/forms/source/xforms/submission/serialization_urlencoded.cxx b/forms/source/xforms/submission/serialization_urlencoded.cxx
index 0cc80e2..3c85741 100644
--- a/forms/source/xforms/submission/serialization_urlencoded.cxx
+++ b/forms/source/xforms/submission/serialization_urlencoded.cxx
@@ -134,7 +134,7 @@ void CSerializationURLEncoded::serialize_node(const Reference< XNode >& aNode)
         }
 
         // found anything?
-        if (aValue.getLength() > 0)
+        if (!aValue.isEmpty())
         {
             OUString aUnencValue = aValue.makeStringAndClear();
             OStringBuffer aEncodedBuffer;
diff --git a/forms/source/xforms/submission/submission_get.cxx b/forms/source/xforms/submission/submission_get.cxx
index 62efea1..4698241 100644
--- a/forms/source/xforms/submission/submission_get.cxx
+++ b/forms/source/xforms/submission/submission_get.cxx
@@ -80,7 +80,7 @@ CSubmission::SubmissionResult CSubmissionGet::submit(const CSS::uno::Reference<
         Sequence< sal_Int8 > aByteBuffer(size);
         while ((n = aInStream->readSomeBytes(aByteBuffer, size-1)) != 0)
             aQueryString.append((sal_Char*)aByteBuffer.getArray(), n);
-        if (aQueryString.getLength() > 0 && m_aURLObj.GetProtocol() != INET_PROT_FILE)
+        if (!aQueryString.isEmpty() && m_aURLObj.GetProtocol() != INET_PROT_FILE)
         {
             aUTF8QueryURL.append('?');
             aUTF8QueryURL.append(aQueryString.makeStringAndClear());


More information about the Libreoffice-commits mailing list