[Libreoffice-commits] core.git: Branch 'libreoffice-4-1' - forms/source

[Lionel Elie Mamane]

 forms/source/component/ListBox.cxx |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 9cca4617c4e020e5562b5023030da7418af67f55
Author: Lionel Elie Mamane <lionel at mamane.lu>
Date:   Sun Jun 23 17:28:58 2013 +0200

    Use unsigned values in m_a(Converted)BoundValues
    
    Values that come from the database are always signed
    (we inherit that from sdbc that inherits that from jdbc
     that inherits that from Java's type system that does not have unsigned values)
    So when using unsigned values, they always operator==-compare false!
    
    Change-Id: I604b04afa23ede835c1f3db1f8c1bdeafbfba7ea
    Reviewed-on: https://gerrit.libreoffice.org/4460
    Reviewed-by: David Tardon <dtardon at redhat.com>
    Tested-by: David Tardon <dtardon at redhat.com>

diff --git a/forms/source/component/ListBox.cxx b/forms/source/component/ListBox.cxx
index ee7c327..68ca37e 100644
--- a/forms/source/component/ListBox.cxx
+++ b/forms/source/component/ListBox.cxx
@@ -913,7 +913,7 @@ namespace frm
                             aBoundValue.fill( *aBoundColumn + 1, m_nBoundColumnType, xCursorRow );
                         else
                             // -1 because getRow() is 1-indexed, but ListBox positions are 0-indexed
-                            aBoundValue = static_cast<sal_uInt16>(xListCursor->getRow()-1);
+                            aBoundValue = static_cast<sal_Int16>(xListCursor->getRow()-1);
                         aValueList.push_back( aBoundValue );
 
                         if ( bUseNULL && ( m_nNULLPos == -1 ) && aStr.isEmpty() )