[Libreoffice-commits] core.git: sal/rtl

Norbert Thiebaud nthiebaud at gmail.com
Tue Jun 25 06:55:02 PDT 2013


 sal/rtl/digest.cxx |    8 ++++++++
 1 file changed, 8 insertions(+)

New commits:
commit 55599c4a1ece11d840c869db44e351468786916b
Author: Norbert Thiebaud <nthiebaud at gmail.com>
Date:   Tue Jun 25 00:00:32 2013 -0500

    coverity #982634 and 5 other : Intentional fallthrough in cases
    
    Change-Id: Ie6cfcc32c1ff80dab0f9835524c89d40503f69f0
    Reviewed-on: https://gerrit.libreoffice.org/4498
    Reviewed-by: Norbert Thiebaud <nthiebaud at gmail.com>
    Tested-by: Norbert Thiebaud <nthiebaud at gmail.com>

diff --git a/sal/rtl/digest.cxx b/sal/rtl/digest.cxx
index e7cd528..75cf209 100644
--- a/sal/rtl/digest.cxx
+++ b/sal/rtl/digest.cxx
@@ -703,9 +703,13 @@ static void __rtl_digest_endMD5 (DigestContextMD5 *ctx)
     switch (ctx->m_nDatLen & 0x03)
     {
         case 0: X[i]  = ((sal_uInt32)(*(p++))) <<  0L;
+            /* fallthrough */
         case 1: X[i] |= ((sal_uInt32)(*(p++))) <<  8L;
+            /* fallthrough */
         case 2: X[i] |= ((sal_uInt32)(*(p++))) << 16L;
+            /* fallthrough */
         case 3: X[i] |= ((sal_uInt32)(*p)) << 24L;
+            /* fallthrough */
     }
 
     i += 1;
@@ -1154,9 +1158,13 @@ static void __rtl_digest_endSHA (DigestContextSHA *ctx)
     switch (ctx->m_nDatLen & 0x03)
     {
         case 0: X[i]  = ((sal_uInt32)(*(p++))) <<  0L;
+            /* fallthrough */
         case 1: X[i] |= ((sal_uInt32)(*(p++))) <<  8L;
+            /* fallthrough */
         case 2: X[i] |= ((sal_uInt32)(*(p++))) << 16L;
+            /* fallthrough */
         case 3: X[i] |= ((sal_uInt32)(*(p++))) << 24L;
+            /* fallthrough */
     }
 
     __rtl_digest_swapLong (X, i + 1);


More information about the Libreoffice-commits mailing list