[Libreoffice-commits] core.git: 2 commits - chart2/source

[Markus Mohrhard]

 chart2/source/controller/dialogs/res_ErrorBar.cxx |    2 +-
 chart2/source/controller/dialogs/tp_ErrorBars.cxx |    2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

New commits:
commit c510281181c647fc3c32e0d08aab99cd46bd3769
Author: Markus Mohrhard <markus.mohrhard at googlemail.com>
Date:   Mon Mar 4 14:07:07 2013 +0100

    no need for the dynamic cast anymore
    
    Change-Id: Ieef97a7c2bff0d5aaffb6034e057b33bc9c65a5b

diff --git a/chart2/source/controller/dialogs/tp_ErrorBars.cxx b/chart2/source/controller/dialogs/tp_ErrorBars.cxx
index b7b00fa..70b3128 100644
--- a/chart2/source/controller/dialogs/tp_ErrorBars.cxx
+++ b/chart2/source/controller/dialogs/tp_ErrorBars.cxx
@@ -35,7 +35,7 @@ ErrorBarsTabPage::ErrorBarsTabPage( Window* pParent, const SfxItemSet& rInAttrs
         m_aErrorBarResources(
             this,
             // the parent is the tab control, of which the parent is the dialog
-            dynamic_cast< Dialog * >( pParent->GetParentDialog() ),
+            pParent->GetParentDialog(),
             rInAttrs, /* bNoneAvailable = */ false )
 {
     FreeResource();
commit d8105ab9f3c7b4e846b4422b6b0eb1dc66d806a8
Author: Markus Mohrhard <markus.mohrhard at googlemail.com>
Date:   Mon Mar 4 13:59:17 2013 +0100

    make this a real assert to find these problems earlier
    
    Change-Id: Ie23de38f5f79a7a72b6ce8d4da7aa0f5e4dd2a93

diff --git a/chart2/source/controller/dialogs/res_ErrorBar.cxx b/chart2/source/controller/dialogs/res_ErrorBar.cxx
index 4c18778..31f945a 100644
--- a/chart2/source/controller/dialogs/res_ErrorBar.cxx
+++ b/chart2/source/controller/dialogs/res_ErrorBar.cxx
@@ -466,7 +466,7 @@ IMPL_LINK( ErrorBarResources, ChooseRange, RangeSelectionButton *, pButton )
         aUIString = String( SchResId( STR_DATA_SELECT_RANGE_FOR_NEGATIVE_ERRORBARS ));
     }
 
-    OSL_ASSERT( m_pParentDialog );
+    assert( m_pParentDialog );
     if( m_pParentDialog )
     {
         lcl_enableRangeChoosing( true, m_pParentDialog );