[Libreoffice-commits] core.git: extensions/source

[Julien Nabet]

 extensions/source/plugin/base/xplugin.cxx |    3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

New commits:
commit 7146eaf9b3a7ac49604d2400686bc86343468aeb
Author: Julien Nabet <serval2412 at yahoo.fr>
Date:   Fri Mar 1 18:32:32 2013 +0100

    coverity#984440: Use after free
    
    Change-Id: Ia6d62ce5421d51fe4fc0128f60e9b39ab736276b
    Reviewed-on: https://gerrit.libreoffice.org/2496
    Reviewed-by: Fridrich Strba <fridrich at documentfoundation.org>
    Tested-by: Fridrich Strba <fridrich at documentfoundation.org>

diff --git a/extensions/source/plugin/base/xplugin.cxx b/extensions/source/plugin/base/xplugin.cxx
index ea77d38..a456c63 100644
--- a/extensions/source/plugin/base/xplugin.cxx
+++ b/extensions/source/plugin/base/xplugin.cxx
@@ -444,9 +444,8 @@ void XPlugin_Impl::modelChanged()
 
     m_nProvidingState = PROVIDING_MODEL_UPDATE;
 
-    destroyInstance();
-
     m_aDescription = fitDescription( getCreationURL() );
+    destroyInstance();
     if( m_aDescription.Mimetype.isEmpty() )
     {
         m_nProvidingState = PROVIDING_NONE;