[Libreoffice-commits] core.git: vcl/source

Tor Lillqvist tml at iki.fi
Tue Mar 12 22:42:11 PDT 2013


 vcl/source/app/dbggui.cxx |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

New commits:
commit b125dd74a238242d2c2414f5d3d6c32bedf3cff9
Author: Tor Lillqvist <tml at iki.fi>
Date:   Wed Mar 13 07:32:31 2013 +0200

    Avoid misleading leading zeros in hex digit
    
    The hex literal 0x00000001 is a 32-bit unsigned int on all our platforms. Here
    it is being cast to a pointer,resulting in 32 or 64 bits. Using exactly eight
    hex digits with leading zeroes gives the impression that the leading zeroes
    and the total number of hex digits would have some significance.
    
    Change-Id: I75904dc4261c195dfaaf45aa3de729994da6d8dc

diff --git a/vcl/source/app/dbggui.cxx b/vcl/source/app/dbggui.cxx
index 1fe7385..7a2b99b 100644
--- a/vcl/source/app/dbggui.cxx
+++ b/vcl/source/app/dbggui.cxx
@@ -626,7 +626,7 @@ void DbgWindow::InsertLine( const OUString& rLine )
 
         sal_uInt16 nInsertionPos = maLstBox.InsertEntry( aStr.copy( 0, nPos ) );
         if ( bFirstEntry )
-            maLstBox.SetEntryData( nInsertionPos, reinterpret_cast< void* >( 0x00000001 ) );
+            maLstBox.SetEntryData( nInsertionPos, reinterpret_cast< void* >( 1 ) );
         bFirstEntry = sal_False;
 
         aStr = aStr.replaceAt( 0, nPos+1, "" );
@@ -636,7 +636,7 @@ void DbgWindow::InsertLine( const OUString& rLine )
         maLstBox.RemoveEntry( 0 );
     sal_uInt16 nInsertionPos = maLstBox.InsertEntry( aStr );
     if ( bFirstEntry )
-        maLstBox.SetEntryData( nInsertionPos, reinterpret_cast< void* >( 0x00000001 ) );
+        maLstBox.SetEntryData( nInsertionPos, reinterpret_cast< void* >( 1 ) );
     maLstBox.SetTopEntry( DBGWIN_MAXLINES-1 );
     maLstBox.Update();
 }


More information about the Libreoffice-commits mailing list