[Libreoffice-commits] core.git: svx/source

Julien Nabet serval2412 at yahoo.fr
Fri Mar 15 00:09:55 PDT 2013


 svx/source/gallery2/galtheme.cxx |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 62c5214272035f6c597a4c7636a8fe2e15ceede3
Author: Julien Nabet <serval2412 at yahoo.fr>
Date:   Fri Mar 15 07:38:23 2013 +0100

    coverity#708921: Use after free
    
    Change-Id: I446fa717dfd11fc5d6045cb1e8dc3eaf8861262e
    Reviewed-on: https://gerrit.libreoffice.org/2738
    Reviewed-by: Fridrich Strba <fridrich at documentfoundation.org>
    Tested-by: Fridrich Strba <fridrich at documentfoundation.org>

diff --git a/svx/source/gallery2/galtheme.cxx b/svx/source/gallery2/galtheme.cxx
index 3db3a8a..0afd03e 100644
--- a/svx/source/gallery2/galtheme.cxx
+++ b/svx/source/gallery2/galtheme.cxx
@@ -87,8 +87,8 @@ GalleryTheme::~GalleryTheme()
     {
         GalleryObject* pEntry = aObjectList[ i ];
         Broadcast( GalleryHint( GALLERY_HINT_CLOSE_OBJECT, GetName(), reinterpret_cast< sal_uIntPtr >( pEntry ) ) );
-        delete pEntry;
         Broadcast( GalleryHint( GALLERY_HINT_OBJECT_REMOVED, GetName(), reinterpret_cast< sal_uIntPtr >( pEntry ) ) );
+        delete pEntry;
     }
     aObjectList.clear();
 


More information about the Libreoffice-commits mailing list