[Libreoffice-commits] core.git: svx/source

Julien Nabet serval2412 at yahoo.fr
Fri Mar 15 16:28:49 PDT 2013


 svx/source/gallery2/galtheme.cxx |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit e799a47983c6e9f0ff312124ebf8fbea1e336b66
Author: Julien Nabet <serval2412 at yahoo.fr>
Date:   Sat Mar 16 00:18:40 2013 +0100

    coverity#738979 Use after free
    
    Change-Id: I843556f18542ac601fd7e16c6f51218ef913de31
    Reviewed-on: https://gerrit.libreoffice.org/2766
    Reviewed-by: Fridrich Strba <fridrich at documentfoundation.org>
    Tested-by: Fridrich Strba <fridrich at documentfoundation.org>

diff --git a/svx/source/gallery2/galtheme.cxx b/svx/source/gallery2/galtheme.cxx
index 0afd03e..952898b 100644
--- a/svx/source/gallery2/galtheme.cxx
+++ b/svx/source/gallery2/galtheme.cxx
@@ -604,11 +604,11 @@ void GalleryTheme::Actualize( const Link& rActualizeLink, GalleryProgress* pProg
             if( pEntry->bDummy )
             {
                 Broadcast( GalleryHint( GALLERY_HINT_CLOSE_OBJECT, GetName(), reinterpret_cast< sal_uIntPtr >( pEntry ) ) );
+                Broadcast( GalleryHint( GALLERY_HINT_OBJECT_REMOVED, GetName(), reinterpret_cast< sal_uLong >( pEntry ) ) );
                 GalleryObjectList::iterator it = aObjectList.begin();
                 ::std::advance( it, i );
                 aObjectList.erase( it );
                 delete pEntry;
-                Broadcast( GalleryHint( GALLERY_HINT_OBJECT_REMOVED, GetName(), reinterpret_cast< sal_uLong >( pEntry ) ) );
             }
             else ++i;
         }


More information about the Libreoffice-commits mailing list