[Libreoffice-commits] core.git: Branch 'feature/formula-core-rework' - sc/qa

Kohei Yoshida kohei.yoshida at gmail.com
Mon Mar 18 11:35:23 PDT 2013


 sc/qa/unit/ucalc.cxx |    5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

New commits:
commit 873c4bed403133b39ddf90858976ee431f1a4a09
Author: Kohei Yoshida <kohei.yoshida at gmail.com>
Date:   Mon Mar 18 14:37:34 2013 -0400

    Fix minor stuff in the test code...
    
    Change-Id: I6c1ebf29d357c1a575a8b7d5421043ddec44f0af

diff --git a/sc/qa/unit/ucalc.cxx b/sc/qa/unit/ucalc.cxx
index 4d93eb1..b6addd1 100644
--- a/sc/qa/unit/ucalc.cxx
+++ b/sc/qa/unit/ucalc.cxx
@@ -1206,8 +1206,8 @@ void Test::testFormulaGrouping()
     // different cell functions.
     aPos1.IncRow();
     aPos2.IncRow();
-    m_pDoc->SetString(aPos1, "=SUM(1,2,3,4,5)");
-    m_pDoc->SetString(aPos2, "=AVERAGE(1,2,3,4,5)");
+    m_pDoc->SetString(aPos1, "=SUM(1;2;3;4;5)");
+    m_pDoc->SetString(aPos2, "=AVERAGE(1;2;3;4;5)");
     nHashVal1 = m_pDoc->GetFormulaHash(aPos1);
     nHashVal2 = m_pDoc->GetFormulaHash(aPos2);
     CPPUNIT_ASSERT_MESSAGE("These hashes should differ.", nHashVal1 != nHashVal2);
@@ -1229,6 +1229,7 @@ void Test::testFormulaGrouping()
     nHashVal1 = m_pDoc->GetFormulaHash(aPos1);
     CPPUNIT_ASSERT_MESSAGE("These hashes should be equal.", nHashVal1 == nHashVal2);
 
+    // string constant vs numeric constant.
     aPos1.IncRow();
     aPos2.IncRow();
     m_pDoc->SetString(aPos1, "=3*4*5");


More information about the Libreoffice-commits mailing list