[Libreoffice-commits] core.git: Branch 'feature/formula-core-rework' - 2 commits - sc/source

Kohei Yoshida kohei.yoshida at gmail.com
Wed Mar 20 21:27:48 PDT 2013


 sc/source/ui/undo/undocell.cxx |    7 +++++++
 1 file changed, 7 insertions(+)

New commits:
commit c8620e606c8cf4f1b185f7c027dc313202118664
Author: Kohei Yoshida <kohei.yoshida at gmail.com>
Date:   Thu Mar 21 00:29:23 2013 -0400

    I think I need to add these just like all the other undo classes do.
    
    Change-Id: Ia5dc41027c144b771a4071a35b7ed699ea00cfb0

diff --git a/sc/source/ui/undo/undocell.cxx b/sc/source/ui/undo/undocell.cxx
index 76fa36e..b7dfef5 100644
--- a/sc/source/ui/undo/undocell.cxx
+++ b/sc/source/ui/undo/undocell.cxx
@@ -550,12 +550,16 @@ ScUndoSetCell::~ScUndoSetCell() {}
 
 void ScUndoSetCell::Undo()
 {
+    BeginUndo();
     SetValue(maOldValue);
+    EndUndo();
 }
 
 void ScUndoSetCell::Redo()
 {
+    BeginRedo();
     SetValue(maNewValue);
+    EndRedo();
 }
 
 void ScUndoSetCell::Repeat( SfxRepeatTarget& /*rTarget*/ )
commit a5965179515479518e9586f2d68fae893b2e044f
Author: Kohei Yoshida <kohei.yoshida at gmail.com>
Date:   Thu Mar 21 00:20:52 2013 -0400

    Forgot to add break here...
    
    Change-Id: I4350c05bdf72c9b582da3b156dc398ea407efa24

diff --git a/sc/source/ui/undo/undocell.cxx b/sc/source/ui/undo/undocell.cxx
index 878a077..76fa36e 100644
--- a/sc/source/ui/undo/undocell.cxx
+++ b/sc/source/ui/undo/undocell.cxx
@@ -516,6 +516,7 @@ ScUndoSetCell::Value::Value( const Value& r ) : meType(r.meType), mfValue(r.mfVa
         break;
         case CELLTYPE_FORMULA:
             mpFormula = r.mpFormula->Clone();
+        break;
         default:
             ;
     }
@@ -530,8 +531,10 @@ ScUndoSetCell::Value::~Value()
         break;
         case CELLTYPE_EDIT:
             delete mpEditText;
+        break;
         case CELLTYPE_FORMULA:
             mpFormula->Delete();
+        break;
         default:
             ;
     }


More information about the Libreoffice-commits mailing list