[Libreoffice-commits] core.git: sd/source

Julien Nabet serval2412 at yahoo.fr
Sun Mar 24 10:46:57 PDT 2013


 sd/source/ui/dlg/tpoption.cxx |    4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

New commits:
commit 8b08aceb3d254909f2ee38f8c3c72162e3717717
Author: Julien Nabet <serval2412 at yahoo.fr>
Date:   Sun Mar 24 18:44:07 2013 +0100

    coverity#704293 Logically dead code
    
    Change-Id: I1e2ad99d19b647607805c7447f5f81f853d411a5

diff --git a/sd/source/ui/dlg/tpoption.cxx b/sd/source/ui/dlg/tpoption.cxx
index e777320..aee8b26 100644
--- a/sd/source/ui/dlg/tpoption.cxx
+++ b/sd/source/ui/dlg/tpoption.cxx
@@ -77,7 +77,6 @@ SdTpOptionsSnap::~SdTpOptionsSnap()
 sal_Bool SdTpOptionsSnap::FillItemSet( SfxItemSet& rAttrs )
 {
     SvxGridTabPage::FillItemSet(rAttrs);
-    SdOptionsSnapItem* pOptsItem = NULL;
     SdOptionsSnapItem aOptsItem( ATTR_OPTIONS_SNAP );
 
     aOptsItem.GetOptionsSnap().SetSnapHelplines( aCbxSnapHelplines.IsChecked() );
@@ -91,8 +90,7 @@ sal_Bool SdTpOptionsSnap::FillItemSet( SfxItemSet& rAttrs )
     aOptsItem.GetOptionsSnap().SetAngle( (sal_Int16) aMtrFldAngle.GetValue() );
     aOptsItem.GetOptionsSnap().SetEliminatePolyPointLimitAngle( (sal_Int16) aMtrFldBezAngle.GetValue() );
 
-    if( pOptsItem == NULL || !(aOptsItem == *pOptsItem) )
-        rAttrs.Put( aOptsItem );
+    rAttrs.Put( aOptsItem );
 
     // we get a possible existing GridItem, this ensures that we do net set
     // some default values by accident


More information about the Libreoffice-commits mailing list