[Libreoffice-commits] core.git: Branch 'feature/formula-core-rework' - 10 commits - connectivity/source cppuhelper/inc dbaccess/inc embedserv/source filter/source fpicker/source framework/inc idlc/source libmariadb/configs lotuswordpro/source RepositoryExternal.mk rsc/inc rsc/source sal/inc sal/osl sal/qa sc/inc sc/source svl/source svtools/inc sw/inc sw/source ucb/source vcl/inc vcl/source vcl/unx writerfilter/source xmloff/source
Kohei Yoshida
kohei.yoshida at gmail.com
Tue Mar 26 13:44:46 PDT 2013
Rebased ref, commits from common ancestor:
commit 2614386d89c3222d2c395c7d30c836cdb6370d13
Author: Kohei Yoshida <kohei.yoshida at gmail.com>
Date: Tue Mar 26 16:44:45 2013 -0400
This can return const reference.
Change-Id: I1cf3e58167b883fee1b8cb32783a7892f6e0faa5
diff --git a/sc/inc/dociter.hxx b/sc/inc/dociter.hxx
index 4f3ab26..acb31e2 100644
--- a/sc/inc/dociter.hxx
+++ b/sc/inc/dociter.hxx
@@ -239,7 +239,7 @@ public:
const ScFormulaCell* getFormulaCell() const;
double getValue() const;
ScCellValue getCellValue() const;
- ScRefCellValue getRefCellValue() const;
+ const ScRefCellValue& getRefCellValue() const;
bool hasString() const;
bool hasNumeric() const;
diff --git a/sc/source/core/data/dociter.cxx b/sc/source/core/data/dociter.cxx
index adb7787..87b832d 100644
--- a/sc/source/core/data/dociter.cxx
+++ b/sc/source/core/data/dociter.cxx
@@ -1131,7 +1131,7 @@ ScCellValue ScCellIterator::getCellValue() const
return aRet;
}
-ScRefCellValue ScCellIterator::getRefCellValue() const
+const ScRefCellValue& ScCellIterator::getRefCellValue() const
{
return maCurCell;
}
commit 6188e1d3f61175cb080c4d5feb37547b0ae9468c
Author: Julien Nabet <serval2412 at yahoo.fr>
Date: Tue Mar 26 21:39:42 2013 +0100
Blind fix for commons-codec 1.6
Change-Id: I19c57855ee35d4327622608cb57cf52651fdfc9c
diff --git a/RepositoryExternal.mk b/RepositoryExternal.mk
index 6fad496..2a66b3d 100644
--- a/RepositoryExternal.mk
+++ b/RepositoryExternal.mk
@@ -2533,14 +2533,14 @@ gb_ExternalProject__use_commons-logging :=
else # !SYSTEM_APACHE_COMMONS
$(eval $(call gb_Helper_register_jars,OXT,\
- commons-codec-1.3 \
+ commons-codec-1.6 \
commons-httpclient-3.1 \
commons-lang-2.3 \
commons-logging-1.1.1 \
))
define gb_Jar__use_commons-codec
-$(call gb_Jar_use_jar,$(1),commons-codec-1.3)
+$(call gb_Jar_use_jar,$(1),commons-codec-1.6)
endef
define gb_ExternalProject__use_commons-codec
$(call gb_ExternalProject_use_external_project,$(1),apache_commons_codec)
commit 2db140d5118ab58e51654d8d10a047c17f650d15
Author: Julien Nabet <serval2412 at yahoo.fr>
Date: Tue Mar 26 21:30:58 2013 +0100
coverity#735533 Logically dead code
Change-Id: Iebc7a7284df0899d31eb6161b25a2e4c2f4cf272
diff --git a/sw/source/filter/ww8/wrtw8num.cxx b/sw/source/filter/ww8/wrtw8num.cxx
index 25d1ece..628cb41 100644
--- a/sw/source/filter/ww8/wrtw8num.cxx
+++ b/sw/source/filter/ww8/wrtw8num.cxx
@@ -312,7 +312,6 @@ void MSWordExportBase::AbstractNumberingDefinitions()
for ( n = 0; n < WW8ListManager::nMaxLevel; ++n )
aNumVector.push_back( n );
- StarSymbolToMSMultiFont *pConvert = 0;
for( n = 0; n < nCount; ++n )
{
AttrOutput().StartAbstractNumbering( n + 1 );
@@ -499,7 +498,6 @@ void MSWordExportBase::AbstractNumberingDefinitions()
}
AttrOutput().EndAbstractNumbering();
}
- delete pConvert;
}
void WW8Export::OutOverrideListTab()
commit b39975bc01a7a25393ff8ee95d8c9f453d2dfdd7
Author: Eike Rathke <erack at redhat.com>
Date: Tue Mar 26 21:21:49 2013 +0100
fixed out of bounds substring access
assuming is not good enough ...
Change-Id: Icd4f090fe94797ecf7e968855df3bb62609037c1
diff --git a/vcl/unx/gtk/fpicker/SalGtkFilePicker.cxx b/vcl/unx/gtk/fpicker/SalGtkFilePicker.cxx
index 0983642..3558993 100644
--- a/vcl/unx/gtk/fpicker/SalGtkFilePicker.cxx
+++ b/vcl/unx/gtk/fpicker/SalGtkFilePicker.cxx
@@ -1851,7 +1851,9 @@ GtkFileFilter* SalGtkFilePicker::implAddFilter( const OUString& rFilter, const O
{
aToken = rType.getToken( 0, ';', nIndex );
// Assume all have the "*.<extn>" syntax
- aToken = aToken.copy( aToken.lastIndexOf( aStarDot ) + 2 );
+ sal_Int32 nStarDot = aToken.lastIndexOf( aStarDot );
+ if (nStarDot >= 0)
+ aToken = aToken.copy( nStarDot + 2 );
if (!aToken.isEmpty())
{
if (!aTokens.isEmpty())
commit 74364dad3fcacc32008f59fab2b5fd8aacd19c9d
Author: Stephan Bergmann <sbergman at redhat.com>
Date: Tue Mar 26 21:15:37 2013 +0100
At least Mac OS X SDK 10.7 does have strnlen
Change-Id: I35b1299eda7a66c578041be479051031734bc864
diff --git a/libmariadb/configs/mac_my_config.h b/libmariadb/configs/mac_my_config.h
index baa4f18..38db37e 100644
--- a/libmariadb/configs/mac_my_config.h
+++ b/libmariadb/configs/mac_my_config.h
@@ -140,7 +140,9 @@
#define HAVE_STPCPY 1
#define HAVE_STRERROR 1
#define HAVE_STRLCPY 1
-/* #undef HAVE_STRNLEN */
+#if MACOSX_SDK_VERSION >= 1070
+#define HAVE_STRNLEN 1
+#endif
#define HAVE_STRPBRK 1
#define HAVE_STRSEP 1
#define HAVE_STRSTR 1
commit d83c63bea70baf4b19b2a6a8bef96bb5e0e6f262
Author: Philipp Weissenbacher <p.weissenbacher at gmail.com>
Date: Tue Mar 26 19:11:33 2013 +0100
Translate German comments, fix some ws
Change-Id: Ic7cf80655e6520f09a0b63b7839e46ad50de8fb1
Reviewed-on: https://gerrit.libreoffice.org/3063
Reviewed-by: Thomas Arnhold <thomas at arnhold.org>
Tested-by: Thomas Arnhold <thomas at arnhold.org>
diff --git a/vcl/source/gdi/gdimtf.cxx b/vcl/source/gdi/gdimtf.cxx
index 798d4d8..da87d31 100644
--- a/vcl/source/gdi/gdimtf.cxx
+++ b/vcl/source/gdi/gdimtf.cxx
@@ -132,7 +132,7 @@ GDIMetaFile::GDIMetaFile( const GDIMetaFile& rMtf ) :
bRecord ( sal_False ),
bUseCanvas ( rMtf.bUseCanvas )
{
- // RefCount der MetaActions erhoehen
+ // Increment RefCount of MetaActions
for( size_t i = 0, n = rMtf.GetActionSize(); i < n; ++i )
{
rMtf.GetAction( i )->Duplicate();
@@ -195,7 +195,7 @@ GDIMetaFile& GDIMetaFile::operator=( const GDIMetaFile& rMtf )
{
Clear();
- // RefCount der MetaActions erhoehen
+ // Increment RefCount of MetaActions
for( size_t i = 0, n = rMtf.GetActionSize(); i < n; ++i )
{
rMtf.GetAction( i )->Duplicate();
@@ -690,7 +690,6 @@ void GDIMetaFile::push_back( MetaAction* pAction )
aList.push_back( pAction );
}
-// @since #110496#
void GDIMetaFile::RemoveAction( size_t nPos )
{
if ( nPos < aList.size() )
@@ -908,8 +907,7 @@ void GDIMetaFile::ImplAddGradientEx( GDIMetaFile& rMtf,
const PolyPolygon& rPolyPoly,
const Gradient& rGrad )
{
- // #105055# Generate comment, GradientEx and Gradient actions
- // (within DrawGradient)
+ // Generate comment, GradientEx and Gradient actions (within DrawGradient)
VirtualDevice aVDev( rMapDev, 0 );
aVDev.EnableOutput( sal_False );
GDIMetaFile aGradMtf;
@@ -1162,7 +1160,7 @@ void GDIMetaFile::Rotate( long nAngle10 )
}
break;
- // #105055# Handle gradientex comment block correctly
+ // Handle gradientex comment block correctly
case( META_COMMENT_ACTION ):
{
MetaCommentAction* pCommentAct = (MetaCommentAction*) pAction;
@@ -2888,8 +2886,6 @@ sal_Bool GDIMetaFile::CreateThumbnail( sal_uInt32 nMaximumExtent,
const BitmapEx* pOverlay,
const Rectangle* pOverlayRect ) const
{
- // the implementation is provided by KA
-
// initialization seems to be complicated but is used to avoid rounding errors
VirtualDevice aVDev;
const Point aNullPt;
@@ -3011,7 +3007,7 @@ MetaCommentAction* makePluggableRendererAction( const rtl::OUString& rRendererSe
{
const sal_uInt8* pData=(sal_uInt8*)_pData;
- // data gets copied twice, unfortunately
+ // FIXME: Data gets copied twice, unfortunately
rtl::OString aRendererServiceName(
rRendererServiceName.getStr(),
rRendererServiceName.getLength(),
diff --git a/vcl/source/gdi/gfxlink.cxx b/vcl/source/gdi/gfxlink.cxx
index 27dacf74..effa86c 100644
--- a/vcl/source/gdi/gfxlink.cxx
+++ b/vcl/source/gdi/gfxlink.cxx
@@ -29,10 +29,6 @@
#include <vcl/cvtgrf.hxx>
#include <com/sun/star/ucb/CommandAbortedException.hpp>
-// -----------
-// - GfxLink -
-// -----------
-
GfxLink::GfxLink() :
meType ( GFX_LINK_TYPE_NONE ),
mpBuf ( NULL ),
@@ -43,16 +39,12 @@ GfxLink::GfxLink() :
{
}
-// ------------------------------------------------------------------------
-
GfxLink::GfxLink( const GfxLink& rGfxLink ) :
mpImpData( new ImpGfxLink )
{
ImplCopy( rGfxLink );
}
-// ------------------------------------------------------------------------
-
GfxLink::GfxLink( sal_uInt8* pBuf, sal_uInt32 nSize, GfxLinkType nType, sal_Bool bOwns ) :
mpImpData( new ImpGfxLink )
{
@@ -75,8 +67,6 @@ GfxLink::GfxLink( sal_uInt8* pBuf, sal_uInt32 nSize, GfxLinkType nType, sal_Bool
mpBuf = NULL;
}
-// ------------------------------------------------------------------------
-
GfxLink::~GfxLink()
{
if( mpBuf && !( --mpBuf->mnRefCount ) )
@@ -88,8 +78,6 @@ GfxLink::~GfxLink()
delete mpImpData;
}
-// ------------------------------------------------------------------------
-
GfxLink& GfxLink::operator=( const GfxLink& rGfxLink )
{
if( &rGfxLink != this )
@@ -106,8 +94,6 @@ GfxLink& GfxLink::operator=( const GfxLink& rGfxLink )
return *this;
}
-// ------------------------------------------------------------------------
-
sal_Bool GfxLink::IsEqual( const GfxLink& rGfxLink ) const
{
sal_Bool bIsEqual = sal_False;
@@ -128,8 +114,6 @@ sal_Bool GfxLink::IsEqual( const GfxLink& rGfxLink ) const
return bIsEqual;
}
-// ------------------------------------------------------------------------
-
void GfxLink::ImplCopy( const GfxLink& rGfxLink )
{
mnBufSize = rGfxLink.mnBufSize;
@@ -146,29 +130,21 @@ void GfxLink::ImplCopy( const GfxLink& rGfxLink )
mpSwap->mnRefCount++;
}
-// ------------------------------------------------------------------------
-
GfxLinkType GfxLink::GetType() const
{
return meType;
}
-// ------------------------------------------------------------------------
-
sal_Bool GfxLink::IsNative() const
{
return( meType >= GFX_LINK_FIRST_NATIVE_ID && meType <= GFX_LINK_LAST_NATIVE_ID );
}
-// ------------------------------------------------------------------------
-
sal_uInt32 GfxLink::GetDataSize() const
{
return mnBufSize;
}
-// ------------------------------------------------------------------------
-
const sal_uInt8* GfxLink::GetData() const
{
if( IsSwappedOut() )
@@ -177,52 +153,38 @@ const sal_uInt8* GfxLink::GetData() const
return( mpBuf ? mpBuf->mpBuffer : NULL );
}
-// ------------------------------------------------------------------------
-
const Size& GfxLink::GetPrefSize() const
{
return mpImpData->maPrefSize;
}
-// ------------------------------------------------------------------------
-
void GfxLink::SetPrefSize( const Size& rPrefSize )
{
mpImpData->maPrefSize = rPrefSize;
mpImpData->mbPrefSizeValid = true;
}
-// ------------------------------------------------------------------------
-
bool GfxLink::IsPrefSizeValid()
{
return mpImpData->mbPrefSizeValid;
}
-// ------------------------------------------------------------------------
-
const MapMode& GfxLink::GetPrefMapMode() const
{
return mpImpData->maPrefMapMode;
}
-// ------------------------------------------------------------------------
-
void GfxLink::SetPrefMapMode( const MapMode& rPrefMapMode )
{
mpImpData->maPrefMapMode = rPrefMapMode;
mpImpData->mbPrefMapModeValid = true;
}
-// ------------------------------------------------------------------------
-
bool GfxLink::IsPrefMapModeValid()
{
return mpImpData->mbPrefMapModeValid;
}
-// ------------------------------------------------------------------------
-
sal_Bool GfxLink::LoadNative( Graphic& rGraphic )
{
sal_Bool bRet = sal_False;
@@ -260,8 +222,6 @@ sal_Bool GfxLink::LoadNative( Graphic& rGraphic )
return bRet;
}
-// ------------------------------------------------------------------------
-
void GfxLink::SwapOut()
{
if( !IsSwappedOut() && mpBuf )
@@ -283,8 +243,6 @@ void GfxLink::SwapOut()
}
}
-// ------------------------------------------------------------------------
-
void GfxLink::SwapIn()
{
if( IsSwappedOut() )
@@ -298,8 +256,6 @@ void GfxLink::SwapIn()
}
}
-// ------------------------------------------------------------------------
-
sal_Bool GfxLink::ExportNative( SvStream& rOStream ) const
{
if( GetDataSize() )
@@ -313,8 +269,6 @@ sal_Bool GfxLink::ExportNative( SvStream& rOStream ) const
return ( rOStream.GetError() == ERRCODE_NONE );
}
-// ------------------------------------------------------------------------
-
SvStream& operator<<( SvStream& rOStream, const GfxLink& rGfxLink )
{
VersionCompat* pCompat = new VersionCompat( rOStream, STREAM_WRITE, 2 );
@@ -338,8 +292,6 @@ SvStream& operator<<( SvStream& rOStream, const GfxLink& rGfxLink )
return rOStream;
}
-// ------------------------------------------------------------------------
-
SvStream& operator>>( SvStream& rIStream, GfxLink& rGfxLink)
{
Size aSize;
@@ -377,10 +329,6 @@ SvStream& operator>>( SvStream& rIStream, GfxLink& rGfxLink)
return rIStream;
}
-// -----------
-// - ImpSwap -
-// -----------
-
ImpSwap::ImpSwap( sal_uInt8* pData, sal_uLong nDataSize ) :
mnDataSize( nDataSize ),
mnRefCount( 1UL )
@@ -409,16 +357,12 @@ ImpSwap::ImpSwap( sal_uInt8* pData, sal_uLong nDataSize ) :
}
}
-// ------------------------------------------------------------------------
-
ImpSwap::~ImpSwap()
{
if( IsSwapped() )
osl_removeFile( maURL.pData );
}
-// ------------------------------------------------------------------------
-
sal_uInt8* ImpSwap::GetData() const
{
sal_uInt8* pData;
@@ -445,8 +389,6 @@ sal_uInt8* ImpSwap::GetData() const
return pData;
}
-// ------------------------------------------------------------------------
-
void ImpSwap::WriteTo( SvStream& rOStm ) const
{
sal_uInt8* pData = GetData();
diff --git a/vcl/source/gdi/gradient.cxx b/vcl/source/gdi/gradient.cxx
index 72d5ffc..b4099b5 100644
--- a/vcl/source/gdi/gradient.cxx
+++ b/vcl/source/gdi/gradient.cxx
@@ -23,12 +23,8 @@
#include <tools/gen.hxx>
#include <vcl/gradient.hxx>
-// =======================================================================
-
DBG_NAME( Gradient )
-// -----------------------------------------------------------------------
-
Impl_Gradient::Impl_Gradient() :
maStartColor( COL_BLACK ),
maEndColor( COL_WHITE )
@@ -44,8 +40,6 @@ Impl_Gradient::Impl_Gradient() :
mnStepCount = 0;
}
-// -----------------------------------------------------------------------
-
Impl_Gradient::Impl_Gradient( const Impl_Gradient& rImplGradient ) :
maStartColor( rImplGradient.maStartColor ),
maEndColor( rImplGradient.maEndColor )
@@ -61,11 +55,9 @@ Impl_Gradient::Impl_Gradient( const Impl_Gradient& rImplGradient ) :
mnStepCount = rImplGradient.mnStepCount;
}
-// -----------------------------------------------------------------------
-
void Gradient::MakeUnique()
{
- // Falls noch andere Referenzen bestehen, dann kopieren
+ // If there are still other references, copy
if ( mpImplGradient->mnRefCount != 1 )
{
if( mpImplGradient->mnRefCount )
@@ -75,8 +67,6 @@ void Gradient::MakeUnique()
}
}
-// -----------------------------------------------------------------------
-
Gradient::Gradient()
{
DBG_CTOR( Gradient, NULL );
@@ -84,20 +74,16 @@ Gradient::Gradient()
mpImplGradient = new Impl_Gradient;
}
-// -----------------------------------------------------------------------
-
Gradient::Gradient( const Gradient& rGradient )
{
DBG_CTOR( Gradient, NULL );
DBG_CHKOBJ( &rGradient, Gradient, NULL );
- // Instance Daten uebernehmen und Referenzcounter erhoehen
+ // Take over instance data and increment refcount
mpImplGradient = rGradient.mpImplGradient;
mpImplGradient->mnRefCount++;
}
-// -----------------------------------------------------------------------
-
Gradient::Gradient( GradientStyle eStyle,
const Color& rStartColor, const Color& rEndColor )
{
@@ -109,22 +95,18 @@ Gradient::Gradient( GradientStyle eStyle,
mpImplGradient->maEndColor = rEndColor;
}
-// -----------------------------------------------------------------------
-
Gradient::~Gradient()
{
DBG_DTOR( Gradient, NULL );
- // Wenn es die letzte Referenz ist, loeschen,
- // sonst Referenzcounter decrementieren
+ // If it's the last reference, delete it, otherwise
+ // decrement refcount
if ( mpImplGradient->mnRefCount == 1 )
delete mpImplGradient;
else
mpImplGradient->mnRefCount--;
}
-// -----------------------------------------------------------------------
-
void Gradient::SetStyle( GradientStyle eStyle )
{
DBG_CHKTHIS( Gradient, NULL );
@@ -133,8 +115,6 @@ void Gradient::SetStyle( GradientStyle eStyle )
mpImplGradient->meStyle = eStyle;
}
-// -----------------------------------------------------------------------
-
void Gradient::SetStartColor( const Color& rColor )
{
DBG_CHKTHIS( Gradient, NULL );
@@ -143,8 +123,6 @@ void Gradient::SetStartColor( const Color& rColor )
mpImplGradient->maStartColor = rColor;
}
-// -----------------------------------------------------------------------
-
void Gradient::SetEndColor( const Color& rColor )
{
DBG_CHKTHIS( Gradient, NULL );
@@ -153,8 +131,6 @@ void Gradient::SetEndColor( const Color& rColor )
mpImplGradient->maEndColor = rColor;
}
-// -----------------------------------------------------------------------
-
void Gradient::SetAngle( sal_uInt16 nAngle )
{
DBG_CHKTHIS( Gradient, NULL );
@@ -163,8 +139,6 @@ void Gradient::SetAngle( sal_uInt16 nAngle )
mpImplGradient->mnAngle = nAngle;
}
-// -----------------------------------------------------------------------
-
void Gradient::SetBorder( sal_uInt16 nBorder )
{
DBG_CHKTHIS( Gradient, NULL );
@@ -173,8 +147,6 @@ void Gradient::SetBorder( sal_uInt16 nBorder )
mpImplGradient->mnBorder = nBorder;
}
-// -----------------------------------------------------------------------
-
void Gradient::SetOfsX( sal_uInt16 nOfsX )
{
DBG_CHKTHIS( Gradient, NULL );
@@ -183,8 +155,6 @@ void Gradient::SetOfsX( sal_uInt16 nOfsX )
mpImplGradient->mnOfsX = nOfsX;
}
-// -----------------------------------------------------------------------
-
void Gradient::SetOfsY( sal_uInt16 nOfsY )
{
DBG_CHKTHIS( Gradient, NULL );
@@ -193,8 +163,6 @@ void Gradient::SetOfsY( sal_uInt16 nOfsY )
mpImplGradient->mnOfsY = nOfsY;
}
-// -----------------------------------------------------------------------
-
void Gradient::SetStartIntensity( sal_uInt16 nIntens )
{
DBG_CHKTHIS( Gradient, NULL );
@@ -203,8 +171,6 @@ void Gradient::SetStartIntensity( sal_uInt16 nIntens )
mpImplGradient->mnIntensityStart = nIntens;
}
-// -----------------------------------------------------------------------
-
void Gradient::SetEndIntensity( sal_uInt16 nIntens )
{
DBG_CHKTHIS( Gradient, NULL );
@@ -213,8 +179,6 @@ void Gradient::SetEndIntensity( sal_uInt16 nIntens )
mpImplGradient->mnIntensityEnd = nIntens;
}
-// -----------------------------------------------------------------------
-
void Gradient::SetSteps( sal_uInt16 nSteps )
{
DBG_CHKTHIS( Gradient, NULL );
@@ -223,8 +187,6 @@ void Gradient::SetSteps( sal_uInt16 nSteps )
mpImplGradient->mnStepCount = nSteps;
}
-// -----------------------------------------------------------------------
-
void Gradient::GetBoundRect( const Rectangle& rRect, Rectangle& rBoundRect, Point& rCenter ) const
{
Rectangle aRect( rRect );
@@ -277,29 +239,29 @@ void Gradient::GetBoundRect( const Rectangle& rRect, Rectangle& rBoundRect, Poin
if( GetStyle() == GradientStyle_RADIAL )
{
- // Radien-Berechnung fuer Kreis
+ // Calculation of radii for circle
aSize.Width() = (long)(0.5 + sqrt((double)aSize.Width()*(double)aSize.Width() + (double)aSize.Height()*(double)aSize.Height()));
aSize.Height() = aSize.Width();
}
else if( GetStyle() == GradientStyle_ELLIPTICAL )
{
- // Radien-Berechnung fuer Ellipse
+ // Calculation of radii for ellipse
aSize.Width() = (long)( 0.5 + (double) aSize.Width() * 1.4142 );
aSize.Height() = (long)( 0.5 + (double) aSize.Height() * 1.4142 );
}
- // neue Mittelpunkte berechnen
+ // Calculate new centers
long nZWidth = aRect.GetWidth() * (long) GetOfsX() / 100;
long nZHeight = aRect.GetHeight() * (long) GetOfsY() / 100;
long nBorderX = (long) GetBorder() * aSize.Width() / 100;
long nBorderY = (long) GetBorder() * aSize.Height() / 100;
rCenter = Point( aRect.Left() + nZWidth, aRect.Top() + nZHeight );
- // Rand beruecksichtigen
+ // Respect borders
aSize.Width() -= nBorderX;
aSize.Height() -= nBorderY;
- // Ausgaberechteck neu setzen
+ // Recalculate output rectangle
aRect.Left() = rCenter.X() - ( aSize.Width() >> 1 );
aRect.Top() = rCenter.Y() - ( aSize.Height() >> 1 );
@@ -308,18 +270,15 @@ void Gradient::GetBoundRect( const Rectangle& rRect, Rectangle& rBoundRect, Poin
}
}
-// -----------------------------------------------------------------------
-
Gradient& Gradient::operator=( const Gradient& rGradient )
{
DBG_CHKTHIS( Gradient, NULL );
DBG_CHKOBJ( &rGradient, Gradient, NULL );
- // Zuerst Referenzcounter erhoehen, damit man sich selbst zuweisen kann
+ // Increment refcount first so that we can reference ourselves
rGradient.mpImplGradient->mnRefCount++;
- // Wenn es die letzte Referenz ist, loeschen,
- // sonst Referenzcounter decrementieren
+ // If it's the last reference, delete it, otherwise decrement
if ( mpImplGradient->mnRefCount == 1 )
delete mpImplGradient;
else
@@ -329,8 +288,6 @@ Gradient& Gradient::operator=( const Gradient& rGradient )
return *this;
}
-// -----------------------------------------------------------------------
-
sal_Bool Gradient::operator==( const Gradient& rGradient ) const
{
DBG_CHKTHIS( Gradient, NULL );
@@ -374,8 +331,6 @@ SvStream& operator>>( SvStream& rIStm, Impl_Gradient& rImpl_Gradient )
return rIStm;
}
-// -----------------------------------------------------------------------
-
SvStream& operator<<( SvStream& rOStm, const Impl_Gradient& rImpl_Gradient )
{
VersionCompat aCompat( rOStm, STREAM_WRITE, 1 );
@@ -394,16 +349,12 @@ SvStream& operator<<( SvStream& rOStm, const Impl_Gradient& rImpl_Gradient )
return rOStm;
}
-// -----------------------------------------------------------------------
-
SvStream& operator>>( SvStream& rIStm, Gradient& rGradient )
{
rGradient.MakeUnique();
return( rIStm >> *rGradient.mpImplGradient );
}
-// -----------------------------------------------------------------------
-
SvStream& operator<<( SvStream& rOStm, const Gradient& rGradient )
{
return( rOStm << *rGradient.mpImplGradient );
diff --git a/vcl/source/gdi/graph.cxx b/vcl/source/gdi/graph.cxx
index fcfaf61..464cb62 100644
--- a/vcl/source/gdi/graph.cxx
+++ b/vcl/source/gdi/graph.cxx
@@ -32,10 +32,6 @@
using namespace ::com::sun::star;
-// -----------------------
-// - Default-Drawmethode -
-// -----------------------
-
static void ImplDrawDefault( OutputDevice* pOutDev, const OUString* pText,
Font* pFont, const Bitmap* pBitmap, const BitmapEx* pBitmapEx,
const Point& rDestPt, const Size& rDestSize )
@@ -51,7 +47,7 @@ static void ImplDrawDefault( OutputDevice* pOutDev, const OUString* pText,
pOutDev->SetFillColor();
- // Auf dem Drucker ein schwarzes Rechteck und auf dem Bildschirm eins mit 3D-Effekt
+ // On the printer a black rectangle and on the screen one with 3D effect
if ( pOutDev->GetOutDevType() == OUTDEV_PRINTER )
pOutDev->SetLineColor( COL_BLACK );
else
@@ -112,10 +108,10 @@ static void ImplDrawDefault( OutputDevice* pOutDev, const OUString* pText,
long nTextWidth = pOutDev->GetTextWidth( *pText );
if ( nTextHeight )
{
- // Die N"aherung ber"ucksichtigt keine Ungenauigkeiten durch
- // Wortumbr"uche
+ // The approximation does not respect imprecisions caused
+ // by word wraps
long nLines = aSize.Height() / nTextHeight;
- long nWidth = aSize.Width() * nLines; // N"aherung!!!
+ long nWidth = aSize.Width() * nLines; // Approximation!!!
if ( nTextWidth <= nWidth || aSz.Height() <= nThreshold )
{
@@ -165,8 +161,7 @@ static void ImplDrawDefault( OutputDevice* pOutDev, const OUString* pText,
}
}
- // Falls die Default-Graphik keinen Inhalt hat,
- // malen wir ein rotes Kreuz
+ // If the default graphic does not have content, we draw a red rectangle
if( !bFilled )
{
aBorderRect.Left()++;
@@ -182,21 +177,13 @@ static void ImplDrawDefault( OutputDevice* pOutDev, const OUString* pText,
pOutDev->Pop();
}
-// -----------
-// - Graphic -
-// -----------
-
TYPEINIT1_AUTOFACTORY( Graphic, SvDataCopyStream );
-// ------------------------------------------------------------------------
-
Graphic::Graphic()
{
mpImpGraphic = new ImpGraphic;
}
-// ------------------------------------------------------------------------
-
Graphic::Graphic( const Graphic& rGraphic ) :
SvDataCopyStream()
{
@@ -209,43 +196,31 @@ SvDataCopyStream()
}
}
-// ------------------------------------------------------------------------
-
Graphic::Graphic( const Bitmap& rBmp )
{
mpImpGraphic = new ImpGraphic( rBmp );
}
-// ------------------------------------------------------------------------
-
Graphic::Graphic( const BitmapEx& rBmpEx )
{
mpImpGraphic = new ImpGraphic( rBmpEx );
}
-// ------------------------------------------------------------------------
-
Graphic::Graphic(const SvgDataPtr& rSvgDataPtr)
{
mpImpGraphic = new ImpGraphic(rSvgDataPtr);
}
-// ------------------------------------------------------------------------
-
Graphic::Graphic( const Animation& rAnimation )
{
mpImpGraphic = new ImpGraphic( rAnimation );
}
-// ------------------------------------------------------------------------
-
Graphic::Graphic( const GDIMetaFile& rMtf )
{
mpImpGraphic = new ImpGraphic( rMtf );
}
-// ------------------------------------------------------------------------
-
Graphic::Graphic( const ::com::sun::star::uno::Reference< ::com::sun::star::graphic::XGraphic >& rxGraphic )
{
uno::Reference< lang::XUnoTunnel > xTunnel( rxGraphic, uno::UNO_QUERY );
@@ -268,8 +243,6 @@ Graphic::Graphic( const ::com::sun::star::uno::Reference< ::com::sun::star::grap
mpImpGraphic = new ImpGraphic;
}
-// ------------------------------------------------------------------------
-
Graphic::~Graphic()
{
if( mpImpGraphic->mnRefCount == 1UL )
@@ -278,8 +251,6 @@ Graphic::~Graphic()
mpImpGraphic->mnRefCount--;
}
-// ------------------------------------------------------------------------
-
void Graphic::ImplTestRefCount()
{
if( mpImpGraphic->mnRefCount > 1UL )
@@ -289,8 +260,6 @@ void Graphic::ImplTestRefCount()
}
}
-// ------------------------------------------------------------------------
-
Graphic& Graphic::operator=( const Graphic& rGraphic )
{
if( &rGraphic != this )
@@ -320,136 +289,98 @@ Graphic& Graphic::operator=( const Graphic& rGraphic )
return *this;
}
-// ------------------------------------------------------------------------
-
sal_Bool Graphic::operator==( const Graphic& rGraphic ) const
{
return( *mpImpGraphic == *rGraphic.mpImpGraphic );
}
-// ------------------------------------------------------------------------
-
sal_Bool Graphic::operator!=( const Graphic& rGraphic ) const
{
return( *mpImpGraphic != *rGraphic.mpImpGraphic );
}
-// ------------------------------------------------------------------------
-
sal_Bool Graphic::operator!() const
{
return( GRAPHIC_NONE == mpImpGraphic->ImplGetType() );
}
-// ------------------------------------------------------------------------
-
void Graphic::Load( SvStream& rIStm )
{
rIStm >> *this;
}
-// ------------------------------------------------------------------------
-
void Graphic::Save( SvStream& rOStm )
{
rOStm << *this;
}
-// ------------------------------------------------------------------------
-
void Graphic::Assign( const SvDataCopyStream& rCopyStream )
{
*this = (const Graphic& ) rCopyStream;
}
-// ------------------------------------------------------------------------
-
void Graphic::Clear()
{
ImplTestRefCount();
mpImpGraphic->ImplClear();
}
-// ------------------------------------------------------------------------
-
GraphicType Graphic::GetType() const
{
return mpImpGraphic->ImplGetType();
}
-// ------------------------------------------------------------------------
-
void Graphic::SetDefaultType()
{
ImplTestRefCount();
mpImpGraphic->ImplSetDefaultType();
}
-// ------------------------------------------------------------------------
-
sal_Bool Graphic::IsSupportedGraphic() const
{
return mpImpGraphic->ImplIsSupportedGraphic();
}
-// ------------------------------------------------------------------------
-
sal_Bool Graphic::IsTransparent() const
{
return mpImpGraphic->ImplIsTransparent();
}
-// ------------------------------------------------------------------------
-
sal_Bool Graphic::IsAlpha() const
{
return mpImpGraphic->ImplIsAlpha();
}
-// ------------------------------------------------------------------------
-
sal_Bool Graphic::IsAnimated() const
{
return mpImpGraphic->ImplIsAnimated();
}
-// ------------------------------------------------------------------------
-
sal_Bool Graphic::IsEPS() const
{
return mpImpGraphic->ImplIsEPS();
}
-// ------------------------------------------------------------------------
-
Bitmap Graphic::GetBitmap(const GraphicConversionParameters& rParameters) const
{
return mpImpGraphic->ImplGetBitmap(rParameters);
}
-// ------------------------------------------------------------------------
-
BitmapEx Graphic::GetBitmapEx(const GraphicConversionParameters& rParameters) const
{
return mpImpGraphic->ImplGetBitmapEx(rParameters);
}
-// ------------------------------------------------------------------------
-
Animation Graphic::GetAnimation() const
{
return mpImpGraphic->ImplGetAnimation();
}
-// ------------------------------------------------------------------------
-
const GDIMetaFile& Graphic::GetGDIMetaFile() const
{
return mpImpGraphic->ImplGetGDIMetaFile();
}
-// ------------------------------------------------------------------------
-
uno::Reference< graphic::XGraphic > Graphic::GetXGraphic() const
{
uno::Reference< graphic::XGraphic > xRet;
@@ -471,38 +402,28 @@ uno::Reference< graphic::XGraphic > Graphic::GetXGraphic() const
return xRet;
}
-// ------------------------------------------------------------------------
-
Size Graphic::GetPrefSize() const
{
return mpImpGraphic->ImplGetPrefSize();
}
-// ------------------------------------------------------------------------
-
void Graphic::SetPrefSize( const Size& rPrefSize )
{
ImplTestRefCount();
mpImpGraphic->ImplSetPrefSize( rPrefSize );
}
-// ------------------------------------------------------------------------
-
MapMode Graphic::GetPrefMapMode() const
{
return mpImpGraphic->ImplGetPrefMapMode();
}
-// ------------------------------------------------------------------------
-
void Graphic::SetPrefMapMode( const MapMode& rPrefMapMode )
{
ImplTestRefCount();
mpImpGraphic->ImplSetPrefMapMode( rPrefMapMode );
}
-// ------------------------------------------------------------------
-
Size Graphic::GetSizePixel( const OutputDevice* pRefDevice ) const
{
Size aRet;
@@ -515,22 +436,16 @@ Size Graphic::GetSizePixel( const OutputDevice* pRefDevice ) const
return aRet;
}
-// ------------------------------------------------------------------
-
sal_uLong Graphic::GetSizeBytes() const
{
return mpImpGraphic->ImplGetSizeBytes();
}
-// ------------------------------------------------------------------------
-
void Graphic::Draw( OutputDevice* pOutDev, const Point& rDestPt ) const
{
mpImpGraphic->ImplDraw( pOutDev, rDestPt );
}
-// ------------------------------------------------------------------------
-
void Graphic::Draw( OutputDevice* pOutDev,
const Point& rDestPt, const Size& rDestSz ) const
{
@@ -540,8 +455,6 @@ void Graphic::Draw( OutputDevice* pOutDev,
mpImpGraphic->ImplDraw( pOutDev, rDestPt, rDestSz );
}
-// ------------------------------------------------------------------------
-
void Graphic::DrawEx( OutputDevice* pOutDev, const OUString& rText,
Font& rFont, const BitmapEx& rBitmap,
const Point& rDestPt, const Size& rDestSz )
@@ -549,8 +462,6 @@ void Graphic::DrawEx( OutputDevice* pOutDev, const OUString& rText,
ImplDrawDefault( pOutDev, &rText, &rFont, NULL, &rBitmap, rDestPt, rDestSz );
}
-// ------------------------------------------------------------------------
-
void Graphic::StartAnimation( OutputDevice* pOutDev, const Point& rDestPt,
const Size& rDestSz, long nExtraData,
OutputDevice* pFirstFrameOutDev )
@@ -559,162 +470,118 @@ void Graphic::StartAnimation( OutputDevice* pOutDev, const Point& rDestPt,
mpImpGraphic->ImplStartAnimation( pOutDev, rDestPt, rDestSz, nExtraData, pFirstFrameOutDev );
}
-// ------------------------------------------------------------------------
-
void Graphic::StopAnimation( OutputDevice* pOutDev, long nExtraData )
{
ImplTestRefCount();
mpImpGraphic->ImplStopAnimation( pOutDev, nExtraData );
}
-// ------------------------------------------------------------------------
-
void Graphic::SetAnimationNotifyHdl( const Link& rLink )
{
mpImpGraphic->ImplSetAnimationNotifyHdl( rLink );
}
-// ------------------------------------------------------------------------
-
Link Graphic::GetAnimationNotifyHdl() const
{
return mpImpGraphic->ImplGetAnimationNotifyHdl();
}
-// ------------------------------------------------------------------------
-
sal_uLong Graphic::GetAnimationLoopCount() const
{
return mpImpGraphic->ImplGetAnimationLoopCount();
}
-// ------------------------------------------------------------------------
-
GraphicReader* Graphic::GetContext()
{
return mpImpGraphic->ImplGetContext();
}
-// ------------------------------------------------------------------------
-
void Graphic::SetContext( GraphicReader* pReader )
{
mpImpGraphic->ImplSetContext( pReader );
}
-// ------------------------------------------------------------------------
-
void Graphic::SetDocFileName( const String& rName, sal_uLong nFilePos )
{
mpImpGraphic->ImplSetDocFileName( rName, nFilePos );
}
-// ------------------------------------------------------------------------
-
const String& Graphic::GetDocFileName() const
{
return mpImpGraphic->ImplGetDocFileName();
}
-// ------------------------------------------------------------------------
-
sal_uLong Graphic::GetDocFilePos() const
{
return mpImpGraphic->ImplGetDocFilePos();
}
-// ------------------------------------------------------------------------
-
sal_Bool Graphic::SwapOut()
{
ImplTestRefCount();
return mpImpGraphic->ImplSwapOut();
}
-// ------------------------------------------------------------------------
-
sal_Bool Graphic::SwapOut( SvStream* pOStream )
{
ImplTestRefCount();
return mpImpGraphic->ImplSwapOut( pOStream );
}
-// ------------------------------------------------------------------------
-
sal_Bool Graphic::SwapIn()
{
ImplTestRefCount();
return mpImpGraphic->ImplSwapIn();
}
-// ------------------------------------------------------------------------
-
sal_Bool Graphic::SwapIn( SvStream* pStrm )
{
ImplTestRefCount();
return mpImpGraphic->ImplSwapIn( pStrm );
}
-// ------------------------------------------------------------------------
-
sal_Bool Graphic::IsSwapOut() const
{
return mpImpGraphic->ImplIsSwapOut();
}
-// ------------------------------------------------------------------------
-
void Graphic::SetLink( const GfxLink& rGfxLink )
{
ImplTestRefCount();
mpImpGraphic->ImplSetLink( rGfxLink );
}
-// ------------------------------------------------------------------------
-
GfxLink Graphic::GetLink() const
{
return mpImpGraphic->ImplGetLink();
}
-// ------------------------------------------------------------------------
-
sal_Bool Graphic::IsLink() const
{
return mpImpGraphic->ImplIsLink();
}
-// ------------------------------------------------------------------------
-
sal_uLong Graphic::GetChecksum() const
{
return mpImpGraphic->ImplGetChecksum();
}
-// ------------------------------------------------------------------------
-
sal_Bool Graphic::ExportNative( SvStream& rOStream ) const
{
return mpImpGraphic->ImplExportNative( rOStream );
}
-// ------------------------------------------------------------------------
-
SvStream& operator>>( SvStream& rIStream, Graphic& rGraphic )
{
rGraphic.ImplTestRefCount();
return rIStream >> *rGraphic.mpImpGraphic;
}
-// ------------------------------------------------------------------------
-
SvStream& operator<<( SvStream& rOStream, const Graphic& rGraphic )
{
return rOStream << *rGraphic.mpImpGraphic;
}
-// ------------------------------------------------------------------------
-
const SvgDataPtr& Graphic::getSvgData() const
{
return mpImpGraphic->getSvgData();
diff --git a/vcl/source/gdi/graphictools.cxx b/vcl/source/gdi/graphictools.cxx
index 0c25eda..26cb977 100644
--- a/vcl/source/gdi/graphictools.cxx
+++ b/vcl/source/gdi/graphictools.cxx
@@ -21,16 +21,12 @@
#include <vcl/graphictools.hxx>
-////////////////////////////////////////////////////////////////////////////
-
SvtGraphicFill::Transform::Transform()
{
matrix[0] = 1.0; matrix[1] = 0.0; matrix[2] = 0.0;
matrix[3] = 0.0; matrix[4] = 1.0; matrix[5] = 0.0;
}
-////////////////////////////////////////////////////////////////////////////
-
SvtGraphicStroke::SvtGraphicStroke() :
maPath(),
maStartArrow(),
@@ -177,9 +173,6 @@ SvStream& operator>>( SvStream& rIStm, SvtGraphicStroke& rClass )
return rIStm;
}
-
-/////////////////////////////////////////////////////////////////////////////
-
SvtGraphicFill::SvtGraphicFill() :
maPath(),
maFillColor( COL_BLACK ),
diff --git a/vcl/source/gdi/hatch.cxx b/vcl/source/gdi/hatch.cxx
index 8b5cf17..037a194 100644
--- a/vcl/source/gdi/hatch.cxx
+++ b/vcl/source/gdi/hatch.cxx
@@ -24,10 +24,6 @@
DBG_NAME( Hatch )
-// --------------
-// - ImplHatch -
-// --------------
-
ImplHatch::ImplHatch() :
mnRefCount ( 1 ),
maColor ( COL_BLACK ),
@@ -37,8 +33,6 @@ ImplHatch::ImplHatch() :
{
}
-// -----------------------------------------------------------------------
-
ImplHatch::ImplHatch( const ImplHatch& rImplHatch ) :
mnRefCount ( 1 ),
maColor ( rImplHatch.maColor ),
@@ -48,18 +42,12 @@ ImplHatch::ImplHatch( const ImplHatch& rImplHatch ) :
{
}
-// ---------
-// - Hatch -
-// ---------
-
Hatch::Hatch()
{
DBG_CTOR( Hatch, NULL );
mpImplHatch = new ImplHatch;
}
-// -----------------------------------------------------------------------
-
Hatch::Hatch( const Hatch& rHatch )
{
DBG_CTOR( Hatch, NULL );
@@ -68,8 +56,6 @@ Hatch::Hatch( const Hatch& rHatch )
mpImplHatch->mnRefCount++;
}
-// -----------------------------------------------------------------------
-
Hatch::Hatch( HatchStyle eStyle, const Color& rColor,
long nDistance, sal_uInt16 nAngle10 )
{
@@ -81,8 +67,6 @@ Hatch::Hatch( HatchStyle eStyle, const Color& rColor,
mpImplHatch->mnAngle = nAngle10;
}
-// -----------------------------------------------------------------------
-
Hatch::~Hatch()
{
DBG_DTOR( Hatch, NULL );
@@ -90,8 +74,6 @@ Hatch::~Hatch()
delete mpImplHatch;
}
-// -----------------------------------------------------------------------
-
Hatch& Hatch::operator=( const Hatch& rHatch )
{
DBG_CHKTHIS( Hatch, NULL );
@@ -106,8 +88,6 @@ Hatch& Hatch::operator=( const Hatch& rHatch )
return *this;
}
-// -----------------------------------------------------------------------
-
sal_Bool Hatch::operator==( const Hatch& rHatch ) const
{
DBG_CHKTHIS( Hatch, NULL );
@@ -120,8 +100,6 @@ sal_Bool Hatch::operator==( const Hatch& rHatch ) const
mpImplHatch->mnAngle == rHatch.mpImplHatch->mnAngle ) );
}
-// -----------------------------------------------------------------------
-
void Hatch::ImplMakeUnique()
{
if( mpImplHatch->mnRefCount != 1 )
@@ -133,8 +111,6 @@ void Hatch::ImplMakeUnique()
}
}
-// -----------------------------------------------------------------------
-
void Hatch::SetColor( const Color& rColor )
{
DBG_CHKTHIS( Hatch, NULL );
@@ -142,8 +118,6 @@ void Hatch::SetColor( const Color& rColor )
mpImplHatch->maColor = rColor;
}
-// -----------------------------------------------------------------------
-
void Hatch::SetDistance( long nDistance )
{
DBG_CHKTHIS( Hatch, NULL );
@@ -151,8 +125,6 @@ void Hatch::SetDistance( long nDistance )
mpImplHatch->mnDistance = nDistance;
}
-// -----------------------------------------------------------------------
-
void Hatch::SetAngle( sal_uInt16 nAngle10 )
{
DBG_CHKTHIS( Hatch, NULL );
@@ -160,8 +132,6 @@ void Hatch::SetAngle( sal_uInt16 nAngle10 )
mpImplHatch->mnAngle = nAngle10;
}
-// -----------------------------------------------------------------------
-
SvStream& operator>>( SvStream& rIStm, ImplHatch& rImplHatch )
{
VersionCompat aCompat( rIStm, STREAM_READ );
@@ -176,8 +146,6 @@ SvStream& operator>>( SvStream& rIStm, ImplHatch& rImplHatch )
return rIStm;
}
-// -----------------------------------------------------------------------
-
SvStream& operator<<( SvStream& rOStm, const ImplHatch& rImplHatch )
{
VersionCompat aCompat( rOStm, STREAM_WRITE, 1 );
@@ -189,16 +157,12 @@ SvStream& operator<<( SvStream& rOStm, const ImplHatch& rImplHatch )
return rOStm;
}
-// -----------------------------------------------------------------------
-
SvStream& operator>>( SvStream& rIStm, Hatch& rHatch )
{
rHatch.ImplMakeUnique();
return( rIStm >> *rHatch.mpImplHatch );
}
-// -----------------------------------------------------------------------
-
SvStream& operator<<( SvStream& rOStm, const Hatch& rHatch )
{
return( rOStm << *rHatch.mpImplHatch );
diff --git a/vcl/source/gdi/image.cxx b/vcl/source/gdi/image.cxx
index 9c6bbef..415ae14 100644
--- a/vcl/source/gdi/image.cxx
+++ b/vcl/source/gdi/image.cxx
@@ -45,18 +45,12 @@ DBG_NAME( ImageList )
using namespace ::com::sun::star;
-// ---------
-// - Image -
-// ---------
-
Image::Image() :
mpImplData( NULL )
{
DBG_CTOR( Image, NULL );
}
-// -----------------------------------------------------------------------
-
Image::Image( const ResId& rResId ) :
mpImplData( NULL )
{
@@ -104,8 +98,6 @@ Image::Image( const ResId& rResId ) :
}
}
-// -----------------------------------------------------------------------
-
Image::Image( const Image& rImage ) :
mpImplData( rImage.mpImplData )
{
@@ -115,8 +107,6 @@ Image::Image( const Image& rImage ) :
++mpImplData->mnRefCount;
}
-// -----------------------------------------------------------------------
-
Image::Image( const BitmapEx& rBitmapEx ) :
mpImplData( NULL )
{
@@ -125,8 +115,6 @@ Image::Image( const BitmapEx& rBitmapEx ) :
ImplInit( rBitmapEx );
}
-// -----------------------------------------------------------------------
-
Image::Image( const Bitmap& rBitmap ) :
mpImplData( NULL )
{
@@ -135,8 +123,6 @@ Image::Image( const Bitmap& rBitmap ) :
ImplInit( rBitmap );
}
-// -----------------------------------------------------------------------
-
Image::Image( const Bitmap& rBitmap, const Bitmap& rMaskBitmap ) :
mpImplData( NULL )
{
@@ -147,8 +133,6 @@ Image::Image( const Bitmap& rBitmap, const Bitmap& rMaskBitmap ) :
ImplInit( aBmpEx );
}
-// -----------------------------------------------------------------------
-
Image::Image( const Bitmap& rBitmap, const Color& rColor ) :
mpImplData( NULL )
{
@@ -159,8 +143,6 @@ Image::Image( const Bitmap& rBitmap, const Color& rColor ) :
ImplInit( aBmpEx );
}
-// -----------------------------------------------------------------------
-
Image::Image( const uno::Reference< graphic::XGraphic >& rxGraphic ) :
mpImplData( NULL )
{
@@ -170,8 +152,6 @@ Image::Image( const uno::Reference< graphic::XGraphic >& rxGraphic ) :
ImplInit( aGraphic.GetBitmapEx() );
}
-// -----------------------------------------------------------------------
-
Image::~Image()
{
DBG_DTOR( Image, NULL );
@@ -180,8 +160,6 @@ Image::~Image()
delete mpImplData;
}
-// -----------------------------------------------------------------------
-
void Image::ImplInit( const BitmapEx& rBmpEx )
{
if( !rBmpEx.IsEmpty() )
@@ -202,8 +180,6 @@ void Image::ImplInit( const BitmapEx& rBmpEx )
}
}
-// -----------------------------------------------------------------------
-
Size Image::GetSizePixel() const
{
DBG_CHKTHIS( Image, NULL );
@@ -227,8 +203,6 @@ Size Image::GetSizePixel() const
return aRet;
}
-// -----------------------------------------------------------------------
-
BitmapEx Image::GetBitmapEx() const
{
DBG_CHKTHIS( Image, NULL );
@@ -252,8 +226,6 @@ BitmapEx Image::GetBitmapEx() const
return aRet;
}
-// -----------------------------------------------------------------------
-
uno::Reference< graphic::XGraphic > Image::GetXGraphic() const
{
const Graphic aGraphic( GetBitmapEx() );
@@ -261,8 +233,6 @@ uno::Reference< graphic::XGraphic > Image::GetXGraphic() const
return aGraphic.GetXGraphic();
}
-// -----------------------------------------------------------------------
-
Image& Image::operator=( const Image& rImage )
{
DBG_CHKTHIS( Image, NULL );
@@ -279,8 +249,6 @@ Image& Image::operator=( const Image& rImage )
return *this;
}
-// -----------------------------------------------------------------------
-
sal_Bool Image::operator==( const Image& rImage ) const
{
DBG_CHKTHIS( Image, NULL );
@@ -315,10 +283,6 @@ sal_Bool Image::operator==( const Image& rImage ) const
return bRet;
}
-// -------------
-// - ImageList -
-// -------------
-
ImageList::ImageList( sal_uInt16 nInit, sal_uInt16 nGrow ) :
mpImplData( NULL ),
mnInitSize( nInit ),
@@ -327,8 +291,6 @@ ImageList::ImageList( sal_uInt16 nInit, sal_uInt16 nGrow ) :
DBG_CTOR( ImageList, NULL );
}
-// -----------------------------------------------------------------------
-
ImageList::ImageList( const ResId& rResId ) :
mpImplData( NULL ),
mnInitSize( 1 ),
@@ -377,8 +339,6 @@ ImageList::ImageList( const ResId& rResId ) :
}
}
-// -----------------------------------------------------------------------
-
ImageList::ImageList( const ::std::vector< ::rtl::OUString >& rNameVector,
const ::rtl::OUString& rPrefix,
const Color* ) :
@@ -399,8 +359,6 @@ ImageList::ImageList( const ::std::vector< ::rtl::OUString >& rNameVector,
}
}
-// -----------------------------------------------------------------------
-
ImageList::ImageList( const ImageList& rImageList ) :
mpImplData( rImageList.mpImplData ),
mnInitSize( rImageList.mnInitSize ),
@@ -412,8 +370,6 @@ ImageList::ImageList( const ImageList& rImageList ) :
++mpImplData->mnRefCount;
}
-// -----------------------------------------------------------------------
-
ImageList::~ImageList()
{
DBG_DTOR( ImageList, NULL );
@@ -430,8 +386,6 @@ void ImageList::ImplInit( sal_uInt16 nItems, const Size &rSize )
mpImplData->maImageSize = rSize;
}
-// -----------------------------------------------------------------------
-
void ImageAryData::Load(const rtl::OUString &rPrefix)
{
static ImplImageTreeSingletonRef aImageTree;
@@ -458,8 +412,7 @@ void ImageAryData::Load(const rtl::OUString &rPrefix)
#endif
}
-// -----------------------------------------------------------------------
-// Rather a performance hazard:
+// FIXME: Rather a performance hazard
BitmapEx ImageList::GetAsHorizontalStrip() const
{
Size aSize( mpImplData->maImageSize );
@@ -498,8 +451,6 @@ BitmapEx ImageList::GetAsHorizontalStrip() const
return aResult;
}
-// -----------------------------------------------------------------------
-
void ImageList::InsertFromHorizontalStrip( const BitmapEx &rBitmapEx,
const std::vector< rtl::OUString > &rNameVector )
{
@@ -521,8 +472,6 @@ void ImageList::InsertFromHorizontalStrip( const BitmapEx &rBitmapEx,
}
}
-// -----------------------------------------------------------------------
-
void ImageList::InsertFromHorizontalBitmap( const ResId& rResId,
sal_uInt16 nCount,
const Color *pMaskColor,
@@ -545,8 +494,6 @@ void ImageList::InsertFromHorizontalBitmap( const ResId& rResId,
InsertFromHorizontalStrip( aBmpEx, aNames );
}
-// -----------------------------------------------------------------------
-
sal_uInt16 ImageList::ImplGetImageId( const ::rtl::OUString& rImageName ) const
{
DBG_CHKTHIS( ImageList, NULL );
@@ -558,8 +505,6 @@ sal_uInt16 ImageList::ImplGetImageId( const ::rtl::OUString& rImageName ) const
return 0;
}
-// -----------------------------------------------------------------------
-
void ImageList::AddImage( const ::rtl::OUString& rImageName, const Image& rImage )
{
DBG_ASSERT( GetImagePos( rImageName ) == IMAGELIST_IMAGE_NOTFOUND, "ImageList::AddImage() - ImageName already exists" );
@@ -571,8 +516,6 @@ void ImageList::AddImage( const ::rtl::OUString& rImageName, const Image& rImage
rImage.GetBitmapEx() );
}
-// -----------------------------------------------------------------------
-
void ImageList::ReplaceImage( const ::rtl::OUString& rImageName, const Image& rImage )
{
const sal_uInt16 nId = ImplGetImageId( rImageName );
@@ -587,8 +530,6 @@ void ImageList::ReplaceImage( const ::rtl::OUString& rImageName, const Image& rI
}
}
-// -----------------------------------------------------------------------
-
void ImageList::RemoveImage( sal_uInt16 nId )
{
DBG_CHKTHIS( ImageList, NULL );
@@ -603,8 +544,6 @@ void ImageList::RemoveImage( sal_uInt16 nId )
}
}
-// -----------------------------------------------------------------------
-
Image ImageList::GetImage( sal_uInt16 nId ) const
{
DBG_CHKTHIS( ImageList, NULL );
@@ -638,8 +577,6 @@ Image ImageList::GetImage( sal_uInt16 nId ) const
return aRet;
}
-// -----------------------------------------------------------------------
-
Image ImageList::GetImage( const ::rtl::OUString& rImageName ) const
{
if( mpImplData )
@@ -657,8 +594,6 @@ Image ImageList::GetImage( const ::rtl::OUString& rImageName ) const
return Image();
}
-// -----------------------------------------------------------------------
-
sal_uInt16 ImageList::GetImageCount() const
{
DBG_CHKTHIS( ImageList, NULL );
@@ -666,8 +601,6 @@ sal_uInt16 ImageList::GetImageCount() const
return mpImplData ? static_cast< sal_uInt16 >( mpImplData->maImages.size() ) : 0;
}
-// -----------------------------------------------------------------------
-
sal_uInt16 ImageList::GetImagePos( sal_uInt16 nId ) const
{
DBG_CHKTHIS( ImageList, NULL );
@@ -689,8 +622,6 @@ bool ImageList::HasImageAtPos( sal_uInt16 nId ) const
return GetImagePos( nId ) != IMAGELIST_IMAGE_NOTFOUND;
}
-// -----------------------------------------------------------------------
-
sal_uInt16 ImageList::GetImagePos( const ::rtl::OUString& rImageName ) const
{
DBG_CHKTHIS( ImageList, NULL );
@@ -707,8 +638,6 @@ sal_uInt16 ImageList::GetImagePos( const ::rtl::OUString& rImageName ) const
return IMAGELIST_IMAGE_NOTFOUND;
}
-// -----------------------------------------------------------------------
-
sal_uInt16 ImageList::GetImageId( sal_uInt16 nPos ) const
{
DBG_CHKTHIS( ImageList, NULL );
@@ -719,8 +648,6 @@ sal_uInt16 ImageList::GetImageId( sal_uInt16 nPos ) const
return 0;
}
-// -----------------------------------------------------------------------
-
::rtl::OUString ImageList::GetImageName( sal_uInt16 nPos ) const
{
DBG_CHKTHIS( ImageList, NULL );
@@ -731,8 +658,6 @@ sal_uInt16 ImageList::GetImageId( sal_uInt16 nPos ) const
return ::rtl::OUString();
}
-// -----------------------------------------------------------------------
-
void ImageList::GetImageNames( ::std::vector< ::rtl::OUString >& rNames ) const
{
RTL_LOGFILE_CONTEXT( aLog, "vcl: ImageList::GetImageNames" );
@@ -752,8 +677,6 @@ void ImageList::GetImageNames( ::std::vector< ::rtl::OUString >& rNames ) const
}
}
-// -----------------------------------------------------------------------
-
Size ImageList::GetImageSize() const
{
DBG_CHKTHIS( ImageList, NULL );
@@ -775,8 +698,6 @@ Size ImageList::GetImageSize() const
return aRet;
}
-// -----------------------------------------------------------------------
-
ImageList& ImageList::operator=( const ImageList& rImageList )
{
DBG_CHKTHIS( ImageList, NULL );
@@ -793,8 +714,6 @@ ImageList& ImageList::operator=( const ImageList& rImageList )
return *this;
}
-// -----------------------------------------------------------------------
-
sal_Bool ImageList::operator==( const ImageList& rImageList ) const
{
DBG_CHKTHIS( ImageList, NULL );
diff --git a/vcl/source/gdi/impanmvw.cxx b/vcl/source/gdi/impanmvw.cxx
index 7be51d2..5ee810a 100644
--- a/vcl/source/gdi/impanmvw.cxx
+++ b/vcl/source/gdi/impanmvw.cxx
@@ -23,10 +23,6 @@
#include <vcl/window.hxx>
#include <tools/helpers.hxx>
-// ----------------
-// - ImplAnimView -
-// ----------------
-
ImplAnimView::ImplAnimView( Animation* pParent, OutputDevice* pOut,
const Point& rPt, const Size& rSz,
sal_uLong nExtraData,
@@ -48,7 +44,7 @@ ImplAnimView::ImplAnimView( Animation* pParent, OutputDevice* pOut,
{
mpParent->ImplIncAnimCount();
- // mirrored horizontically?
+ // Mirrored horizontally?
if( mbHMirr )
{
maDispPt.X() = maPt.X() + maSz.Width() + 1L;
@@ -61,7 +57,7 @@ ImplAnimView::ImplAnimView( Animation* pParent, OutputDevice* pOut,
maDispSz.Width() = maSz.Width();
}
- // mirrored vertically?
+ // Mirrored vertically?
if( mbVMirr )
{
maDispPt.Y() = maPt.Y() + maSz.Height() + 1L;
@@ -88,16 +84,14 @@ ImplAnimView::ImplAnimView( Animation* pParent, OutputDevice* pOut,
else
mpBackground->DrawOutDev( Point(), maSzPix, maDispPt, maDispSz, *mpOut );
- // initial drawing to actual position
+ // Initialize drawing to actual position
ImplDrawToPos( mpParent->ImplGetCurPos() );
- // if first frame OutputDevice is set, update variables now for real OutputDevice
+ // If first frame OutputDevice is set, update variables now for real OutputDevice
if( pFirstFrameOutDev )
maClip = ( mpOut = pOut )->GetClipRegion();
}
-// ------------------------------------------------------------------------
-
ImplAnimView::~ImplAnimView()
{
delete mpBackground;
@@ -106,8 +100,6 @@ ImplAnimView::~ImplAnimView()
mpParent->ImplDecAnimCount();
}
-// ------------------------------------------------------------------------
-
sal_Bool ImplAnimView::ImplMatches( OutputDevice* pOut, long nExtraData ) const
{
sal_Bool bRet = sal_False;
@@ -123,8 +115,6 @@ sal_Bool ImplAnimView::ImplMatches( OutputDevice* pOut, long nExtraData ) const
return bRet;
}
-// ------------------------------------------------------------------------
-
void ImplAnimView::ImplGetPosSize( const AnimationBitmap& rAnm, Point& rPosPix, Size& rSizePix )
{
const Size& rAnmSize = mpParent->GetDisplaySizePixel();
@@ -153,17 +143,15 @@ void ImplAnimView::ImplGetPosSize( const AnimationBitmap& rAnm, Point& rPosPix,
rSizePix.Width() = aPt2.X() - rPosPix.X() + 1L;
rSizePix.Height() = aPt2.Y() - rPosPix.Y() + 1L;
- // mirrored horizontically?
+ // Mirrored horizontally?
if( mbHMirr )
rPosPix.X() = maSzPix.Width() - 1L - aPt2.X();
- // mirrored vertically?
+ // Mirrored vertically?
if( mbVMirr )
rPosPix.Y() = maSzPix.Height() - 1L - aPt2.Y();
}
-// ------------------------------------------------------------------------
-
void ImplAnimView::ImplDrawToPos( sal_uLong nPos )
{
VirtualDevice aVDev;
@@ -187,15 +175,11 @@ void ImplAnimView::ImplDrawToPos( sal_uLong nPos )
}
}
-// ------------------------------------------------------------------------
-
void ImplAnimView::ImplDraw( sal_uLong nPos )
{
ImplDraw( nPos, NULL );
}
-// ------------------------------------------------------------------------
-
void ImplAnimView::ImplDraw( sal_uLong nPos, VirtualDevice* pVDev )
{
Rectangle aOutRect( mpOut->PixelToLogic( Point() ), mpOut->GetOutputSize() );
@@ -215,7 +199,7 @@ void ImplAnimView::ImplDraw( sal_uLong nPos, VirtualDevice* pVDev )
ImplGetPosSize( rAnm, aPosPix, aSizePix );
- // mirrored horizontically?
+ // Mirrored horizontally?
if( mbHMirr )
{
aBmpPosPix.X() = aPosPix.X() + aSizePix.Width() - 1L;
@@ -227,7 +211,7 @@ void ImplAnimView::ImplDraw( sal_uLong nPos, VirtualDevice* pVDev )
aBmpSizePix.Width() = aSizePix.Width();
}
- // mirrored vertically?
+ // Mirrored vertically?
if( mbVMirr )
{
aBmpPosPix.Y() = aPosPix.Y() + aSizePix.Height() - 1L;
@@ -270,9 +254,9 @@ void ImplAnimView::ImplDraw( sal_uLong nPos, VirtualDevice* pVDev )
maRestPt = aPosPix;
maRestSz = aSizePix;
- // Was muessen wir beim naechsten Mal restaurieren ?
- // ==> ggf. in eine Bitmap stecken, ansonsten SaveBitmap
- // aus Speichergruenden loeschen
+ // What do we need to restore the next time?
+ // Put it into a bitmap if needed, else delete
+ // SaveBitmap to conserve memory
if( ( meLastDisposal == DISPOSE_BACK ) || ( meLastDisposal == DISPOSE_NOT ) )
mpRestore->SetOutputSizePixel( Size( 1, 1 ), sal_False );
else
@@ -306,8 +290,6 @@ void ImplAnimView::ImplDraw( sal_uLong nPos, VirtualDevice* pVDev )
}
}
-// ------------------------------------------------------------------------
-
void ImplAnimView::ImplRepaint()
{
const sal_Bool bOldPause = mbPause;
@@ -328,8 +310,6 @@ void ImplAnimView::ImplRepaint()
mbPause = bOldPause;
}
-// ------------------------------------------------------------------------
-
AInfo* ImplAnimView::ImplCreateAInfo() const
{
AInfo* pAInfo = new AInfo;
diff --git a/vcl/source/gdi/impanmvw.hxx b/vcl/source/gdi/impanmvw.hxx
index fe728a5..4e20f1d 100644
--- a/vcl/source/gdi/impanmvw.hxx
+++ b/vcl/source/gdi/impanmvw.hxx
@@ -22,10 +22,6 @@
#include <vcl/animate.hxx>
-// ----------------
-// - ImplAnimView -
-// ----------------
-
class Animation;
class OutputDevice;
class VirtualDevice;
diff --git a/vcl/source/gdi/jobset.cxx b/vcl/source/gdi/jobset.cxx
index fdd4f5a..dd72bf8 100644
--- a/vcl/source/gdi/jobset.cxx
+++ b/vcl/source/gdi/jobset.cxx
@@ -25,8 +25,6 @@
#include <jobset.h>
-// =======================================================================
-
DBG_NAME( JobSetup )
#define JOBSET_FILEFORMAT2 3780
@@ -53,8 +51,6 @@ struct Impl364JobSetupData
SVBT32 nPaperHeight;
};
-// =======================================================================
-
ImplJobSetup::ImplJobSetup()
{
mnRefCount = 1;
@@ -69,8 +65,6 @@ ImplJobSetup::ImplJobSetup()
mpDriverData = NULL;
}
-// -----------------------------------------------------------------------
-
ImplJobSetup::ImplJobSetup( const ImplJobSetup& rJobSetup ) :
maPrinterName( rJobSetup.maPrinterName ),
maDriver( rJobSetup.maDriver )
@@ -94,15 +88,11 @@ ImplJobSetup::ImplJobSetup( const ImplJobSetup& rJobSetup ) :
maValueMap = rJobSetup.maValueMap;
}
-// -----------------------------------------------------------------------
-
ImplJobSetup::~ImplJobSetup()
{
rtl_freeMemory( mpDriverData );
}
-// =======================================================================
-
ImplJobSetup* JobSetup::ImplGetData()
{
if ( !mpData )
@@ -116,8 +106,6 @@ ImplJobSetup* JobSetup::ImplGetData()
return mpData;
}
-// -----------------------------------------------------------------------
-
ImplJobSetup* JobSetup::ImplGetConstData()
{
if ( !mpData )
@@ -125,8 +113,6 @@ ImplJobSetup* JobSetup::ImplGetConstData()
return mpData;
}
-// -----------------------------------------------------------------------
-
const ImplJobSetup* JobSetup::ImplGetConstData() const
{
if ( !mpData )
@@ -134,8 +120,6 @@ const ImplJobSetup* JobSetup::ImplGetConstData() const
return mpData;
}
-// =======================================================================
-
JobSetup::JobSetup()
{
DBG_CTOR( JobSetup, NULL );
@@ -143,8 +127,6 @@ JobSetup::JobSetup()
mpData = NULL;
}
-// -----------------------------------------------------------------------
-
JobSetup::JobSetup( const JobSetup& rJobSetup )
{
DBG_CTOR( JobSetup, NULL );
@@ -156,8 +138,6 @@ JobSetup::JobSetup( const JobSetup& rJobSetup )
mpData->mnRefCount++;
}
-// -----------------------------------------------------------------------
-
JobSetup::~JobSetup()
{
DBG_DTOR( JobSetup, NULL );
@@ -171,8 +151,6 @@ JobSetup::~JobSetup()
}
}
-// -----------------------------------------------------------------------
-
rtl::OUString JobSetup::GetPrinterName() const
{
if ( mpData )
@@ -181,8 +159,6 @@ rtl::OUString JobSetup::GetPrinterName() const
return rtl::OUString();
}
-// -----------------------------------------------------------------------
-
rtl::OUString JobSetup::GetDriverName() const
{
if ( mpData )
@@ -191,8 +167,6 @@ rtl::OUString JobSetup::GetDriverName() const
return rtl::OUString();
}
-// -----------------------------------------------------------------------
-
void JobSetup::SetValue( const rtl::OUString& rKey, const rtl::OUString& rValue )
{
if( ! mpData )
@@ -201,20 +175,18 @@ void JobSetup::SetValue( const rtl::OUString& rKey, const rtl::OUString& rValue
mpData->maValueMap[ rKey ] = rValue;
}
-// -----------------------------------------------------------------------
-
JobSetup& JobSetup::operator=( const JobSetup& rJobSetup )
{
DBG_CHKTHIS( JobSetup, NULL );
DBG_CHKOBJ( &rJobSetup, JobSetup, NULL );
DBG_ASSERT( !rJobSetup.mpData || (rJobSetup.mpData->mnRefCount) < 0xFFFE, "JobSetup: RefCount overflow" );
- // Zuerst Referenzcounter erhoehen, damit man sich selbst zuweisen kann
+ // Increment refcount first, so that we can assign to ourselves
if ( rJobSetup.mpData )
rJobSetup.mpData->mnRefCount++;
- // Wenn es keine statischen ImpDaten sind, dann loeschen, wenn es
- // die letzte Referenz ist, sonst Referenzcounter decrementieren
+ // If it's not static ImpData and the last reference, delete it, else
+ // decrement refcount
if ( mpData )
{
if ( mpData->mnRefCount == 1 )
@@ -228,8 +200,6 @@ JobSetup& JobSetup::operator=( const JobSetup& rJobSetup )
return *this;
}
-// -----------------------------------------------------------------------
-
sal_Bool JobSetup::operator==( const JobSetup& rJobSetup ) const
{
DBG_CHKTHIS( JobSetup, NULL );
@@ -261,8 +231,6 @@ sal_Bool JobSetup::operator==( const JobSetup& rJobSetup ) const
return sal_False;
}
-// -----------------------------------------------------------------------
-
SvStream& operator>>( SvStream& rIStream, JobSetup& rJobSetup )
{
DBG_ASSERTWARNING( rIStream.GetVersion(), "JobSetup::>> - Solar-Version not set on rOStream" );
@@ -300,7 +268,7 @@ SvStream& operator>>( SvStream& rIStream, JobSetup& rJobSetup )
pJobData->maPrinterName = OStringToOUString(pData->cPrinterName, aStreamEncoding);
pJobData->maDriver = OStringToOUString(pData->cDriverName, aStreamEncoding);
- // Sind es unsere neuen JobSetup-Daten?
+ // Are these our new JobSetup files?
if ( nSystem == JOBSET_FILE364_SYSTEM ||
nSystem == JOBSET_FILE605_SYSTEM )
{
@@ -353,14 +321,12 @@ SvStream& operator>>( SvStream& rIStream, JobSetup& rJobSetup )
return rIStream;
}
-// -----------------------------------------------------------------------
-
SvStream& operator<<( SvStream& rOStream, const JobSetup& rJobSetup )
{
DBG_ASSERTWARNING( rOStream.GetVersion(), "JobSetup::<< - Solar-Version not set on rOStream" );
- // Zur Zeit haben wir noch kein neues FileFormat
-// if ( rOStream.GetVersion() < JOBSET_FILEFORMAT2 )
+ // We do not have a new FileFormat at this point in time
+ // if ( rOStream.GetVersion() < JOBSET_FILEFORMAT2 )
{
sal_uInt16 nLen = 0;
if ( !rJobSetup.mpData )
@@ -371,7 +337,7 @@ SvStream& operator<<( SvStream& rOStream, const JobSetup& rJobSetup )
const ImplJobSetup* pJobData = rJobSetup.ImplGetConstData();
Impl364JobSetupData aOldJobData;
- sal_uInt16 nOldJobDataSize = sizeof( aOldJobData );
+ sal_uInt16 nOldJobDataSize = sizeof( aOldJobData );
ShortToSVBT16( nOldJobDataSize, aOldJobData.nSize );
ShortToSVBT16( pJobData->mnSystem, aOldJobData.nSystem );
UInt32ToSVBT32( pJobData->mnDriverDataLen, aOldJobData.nDriverDataLen );
@@ -422,11 +388,6 @@ SvStream& operator<<( SvStream& rOStream, const JobSetup& rJobSetup )
rOStream.Seek( nPos + nLen );
}
}
-/*
- else
- {
- }
-*/
return rOStream;
}
diff --git a/vcl/source/gdi/mapmod.cxx b/vcl/source/gdi/mapmod.cxx
index fd3861d..768e979 100644
--- a/vcl/source/gdi/mapmod.cxx
+++ b/vcl/source/gdi/mapmod.cxx
@@ -22,12 +22,8 @@
#include <tools/debug.hxx>
#include <vcl/mapmod.hxx>
-// =======================================================================
-
DBG_NAME( MapMode )
-// -----------------------------------------------------------------------
-
ImplMapMode::ImplMapMode() :
maOrigin( 0, 0 ),
maScaleX( 1, 1 ),
@@ -38,8 +34,6 @@ ImplMapMode::ImplMapMode() :
mbSimple = sal_False;
}
-// -----------------------------------------------------------------------
-
ImplMapMode::ImplMapMode( const ImplMapMode& rImplMapMode ) :
maOrigin( rImplMapMode.maOrigin ),
maScaleX( rImplMapMode.maScaleX ),
@@ -50,8 +44,6 @@ ImplMapMode::ImplMapMode( const ImplMapMode& rImplMapMode ) :
mbSimple = sal_False;
}
-// -----------------------------------------------------------------------
-
SvStream& operator>>( SvStream& rIStm, ImplMapMode& rImplMapMode )
{
VersionCompat aCompat( rIStm, STREAM_READ );
@@ -64,8 +56,6 @@ SvStream& operator>>( SvStream& rIStm, ImplMapMode& rImplMapMode )
return rIStm;
}
-// -----------------------------------------------------------------------
-
SvStream& operator<<( SvStream& rOStm, const ImplMapMode& rImplMapMode )
{
VersionCompat aCompat( rOStm, STREAM_WRITE, 1 );
@@ -79,8 +69,6 @@ SvStream& operator<<( SvStream& rOStm, const ImplMapMode& rImplMapMode )
return rOStm;
}
-// -----------------------------------------------------------------------
-
ImplMapMode* ImplMapMode::ImplGetStaticMapMode( MapUnit eUnit )
{
static long aStaticImplMapModeAry[(MAP_LASTENUMDUMMY)*sizeof(ImplMapMode)/sizeof(long)];
@@ -102,11 +90,9 @@ ImplMapMode* ImplMapMode::ImplGetStaticMapMode( MapUnit eUnit )
return pImplMapMode;
}
-// -----------------------------------------------------------------------
-
inline void MapMode::ImplMakeUnique()
{
- // Falls noch andere Referenzen bestehen, dann kopieren
+ // If there are other references, copy
if ( mpImplMapMode->mnRefCount != 1 )
{
if ( mpImplMapMode->mnRefCount )
@@ -115,8 +101,6 @@ inline void MapMode::ImplMakeUnique()
}
}
-// -----------------------------------------------------------------------
-
MapMode::MapMode()
{
DBG_CTOR( MapMode, NULL );
@@ -124,23 +108,19 @@ MapMode::MapMode()
mpImplMapMode = ImplMapMode::ImplGetStaticMapMode( MAP_PIXEL );
}
-// -----------------------------------------------------------------------
-
MapMode::MapMode( const MapMode& rMapMode )
{
DBG_CTOR( MapMode, NULL );
DBG_CHKOBJ( &rMapMode, MapMode, NULL );
DBG_ASSERT( rMapMode.mpImplMapMode->mnRefCount < 0xFFFFFFFE, "MapMode: RefCount overflow" );
- // shared Instance Daten uebernehmen und Referenzcounter erhoehen
+ // Take over Shared Instance Data and increment refcount
mpImplMapMode = rMapMode.mpImplMapMode;
- // RefCount == 0 fuer statische Objekte
+ // RefCount == 0 for static objects
if ( mpImplMapMode->mnRefCount )
mpImplMapMode->mnRefCount++;
}
-// -----------------------------------------------------------------------
-
MapMode::MapMode( MapUnit eUnit )
{
DBG_CTOR( MapMode, NULL );
@@ -148,8 +128,6 @@ MapMode::MapMode( MapUnit eUnit )
mpImplMapMode = ImplMapMode::ImplGetStaticMapMode( eUnit );
}
-// -----------------------------------------------------------------------
-
MapMode::MapMode( MapUnit eUnit, const Point& rLogicOrg,
const Fraction& rScaleX, const Fraction& rScaleY )
{
@@ -162,14 +140,12 @@ MapMode::MapMode( MapUnit eUnit, const Point& rLogicOrg,
mpImplMapMode->maScaleY = rScaleY;
}
-// -----------------------------------------------------------------------
-
MapMode::~MapMode()
{
DBG_DTOR( MapMode, NULL );
- // Wenn es keine statischen ImpDaten sind, dann loeschen, wenn es
- // die letzte Referenz ist, sonst Referenzcounter decrementieren
+ // If it's not static ImpData and it's the last reference, delete it,
+ // else decrement refcounter
if ( mpImplMapMode->mnRefCount )
{
if ( mpImplMapMode->mnRefCount == 1 )
@@ -179,8 +155,6 @@ MapMode::~MapMode()
}
}
-// -----------------------------------------------------------------------
-
void MapMode::SetMapUnit( MapUnit eUnit )
{
DBG_CHKTHIS( MapMode, NULL );
@@ -189,8 +163,6 @@ void MapMode::SetMapUnit( MapUnit eUnit )
mpImplMapMode->meUnit = eUnit;
}
-// -----------------------------------------------------------------------
-
void MapMode::SetOrigin( const Point& rLogicOrg )
{
DBG_CHKTHIS( MapMode, NULL );
@@ -199,8 +171,6 @@ void MapMode::SetOrigin( const Point& rLogicOrg )
mpImplMapMode->maOrigin = rLogicOrg;
}
-// -----------------------------------------------------------------------
-
void MapMode::SetScaleX( const Fraction& rScaleX )
{
DBG_CHKTHIS( MapMode, NULL );
@@ -209,8 +179,6 @@ void MapMode::SetScaleX( const Fraction& rScaleX )
mpImplMapMode->maScaleX = rScaleX;
}
-// -----------------------------------------------------------------------
-
void MapMode::SetScaleY( const Fraction& rScaleY )
{
DBG_CHKTHIS( MapMode, NULL );
@@ -219,21 +187,19 @@ void MapMode::SetScaleY( const Fraction& rScaleY )
mpImplMapMode->maScaleY = rScaleY;
}
-// -----------------------------------------------------------------------
-
MapMode& MapMode::operator=( const MapMode& rMapMode )
{
DBG_CHKTHIS( MapMode, NULL );
DBG_CHKOBJ( &rMapMode, MapMode, NULL );
DBG_ASSERT( rMapMode.mpImplMapMode->mnRefCount < 0xFFFFFFFE, "MapMode: RefCount overflow" );
- // Zuerst Referenzcounter erhoehen, damit man sich selbst zuweisen kann
- // RefCount == 0 fuer statische Objekte
+ // First increment refcount so that we can reference ourselves
+ // RefCount == 0 for static objects
if ( rMapMode.mpImplMapMode->mnRefCount )
rMapMode.mpImplMapMode->mnRefCount++;
- // Wenn es keine statischen ImpDaten sind, dann loeschen, wenn es
- // die letzte Referenz ist, sonst Referenzcounter decrementieren
+ // If it's not static ImpData and it's the last reference, delete it,
+ // else decrement refcounter
if ( mpImplMapMode->mnRefCount )
{
if ( mpImplMapMode->mnRefCount == 1 )
@@ -247,8 +213,6 @@ MapMode& MapMode::operator=( const MapMode& rMapMode )
return *this;
}
-// -----------------------------------------------------------------------
-
sal_Bool MapMode::operator==( const MapMode& rMapMode ) const
{
DBG_CHKTHIS( MapMode, NULL );
@@ -266,8 +230,6 @@ sal_Bool MapMode::operator==( const MapMode& rMapMode ) const
return sal_False;
}
-// -----------------------------------------------------------------------
-
sal_Bool MapMode::IsDefault() const
{
DBG_CHKTHIS( MapMode, NULL );
@@ -285,16 +247,12 @@ sal_Bool MapMode::IsDefault() const
return sal_False;
}
-// -----------------------------------------------------------------------
-
SvStream& operator>>( SvStream& rIStm, MapMode& rMapMode )
{
rMapMode.ImplMakeUnique();
return (rIStm >> *rMapMode.mpImplMapMode);
}
-// -----------------------------------------------------------------------
-
SvStream& operator<<( SvStream& rOStm, const MapMode& rMapMode )
{
return (rOStm << *rMapMode.mpImplMapMode);
commit 488e6875e992e11601611a119476624822fc4635
Author: Thomas Arnhold <thomas at arnhold.org>
Date: Mon Mar 25 19:56:20 2013 +0100
remove external include guards
Change-Id: If5758e02baa8e019923355b6c97043b306223fdd
diff --git a/connectivity/source/inc/hsqldb/HConnection.hxx b/connectivity/source/inc/hsqldb/HConnection.hxx
index 42748d9..408d26c 100644
--- a/connectivity/source/inc/hsqldb/HConnection.hxx
+++ b/connectivity/source/inc/hsqldb/HConnection.hxx
@@ -23,9 +23,7 @@
#include "connectivity/ConnectionWrapper.hxx"
#include <com/sun/star/util/XFlushable.hpp>
#include <com/sun/star/sdbc/XDriver.hpp>
-#ifndef __com_sun_star_sdb_application_XTableUIProvider_hpp__
#include <com/sun/star/sdb/application/XTableUIProvider.hpp>
-#endif
#include <com/sun/star/ui/dialogs/XExecutableDialog.hpp>
#include <cppuhelper/compbase2.hxx>
#include <comphelper/uno3.hxx>
diff --git a/connectivity/source/parse/sqlbison.y b/connectivity/source/parse/sqlbison.y
index 0bb7c31..14a89d5 100644
--- a/connectivity/source/parse/sqlbison.y
+++ b/connectivity/source/parse/sqlbison.y
@@ -22,63 +22,26 @@
#include <string.h>
#include "parse/sqlbison_exports.hxx"
-#ifndef _CONNECTIVITY_SQLNODE_HXX
#include <connectivity/sqlnode.hxx>
-#endif
-#ifndef _CONNECTIVITY_SQLPARSE_HXX
#include <connectivity/sqlparse.hxx>
-#endif
-#ifndef _CONNECTIVITY_SQLINTERNALNODE_HXX
#include <internalnode.hxx>
-#endif
-#ifndef _COM_SUN_STAR_LANG_LOCALE_HPP_
#include <com/sun/star/lang/Locale.hpp>
-#endif
-#ifndef _COM_SUN_STAR_SDBC_DATATYPE_HPP_
#include <com/sun/star/sdbc/DataType.hpp>
-#endif
-#ifndef _COM_SUN_STAR_UTIL_DATE_HPP_
#include <com/sun/star/util/Date.hpp>
-#endif
-#ifndef _COM_SUN_STAR_UTIL_DATETIME_HPP_
#include <com/sun/star/util/DateTime.hpp>
-#endif
-#ifndef _COM_SUN_STAR_UTIL_TIME_HPP_
#include <com/sun/star/util/Time.hpp>
-#endif
-#ifndef _COM_SUN_STAR_UTIL_XNUMBERFORMATTER_HPP_
#include <com/sun/star/util/XNumberFormatter.hpp>
-#endif
-#ifndef _COM_SUN_STAR_UTIL_XNUMBERFORMATSSUPPLIER_HPP_
#include <com/sun/star/util/XNumberFormatsSupplier.hpp>
-#endif
-#ifndef _COM_SUN_STAR_UTIL_XNUMBERFORMATS_HPP_
#include <com/sun/star/util/XNumberFormats.hpp>
-#endif
-#ifndef _COM_SUN_STAR_UTIL_NUMBERFORMAT_HPP_
#include <com/sun/star/util/NumberFormat.hpp>
-#endif
-#ifndef _COM_SUN_STAR_UTIL_XNUMBERFORMATTYPES_HPP_
#include <com/sun/star/util/XNumberFormatTypes.hpp>
-#endif
-#ifndef _COM_SUN_STAR_BEANS_XPROPERTYSET_HPP_
#include <com/sun/star/beans/XPropertySet.hpp>
-#endif
-#ifndef _COM_SUN_STAR_I18N_KPARSETYPE_HPP_
#include <com/sun/star/i18n/KParseType.hpp>
-#endif
-#ifndef _COM_SUN_STAR_I18N_KPARSETOKENS_HPP_
#include <com/sun/star/i18n/KParseTokens.hpp>
-#endif
-#ifndef _CONNECTIVITY_SQLSCAN_HXX
+
#include "sqlscan.hxx"
-#endif
-#ifndef _OSL_DIAGNOSE_H_
#include <osl/diagnose.h>
-#endif
-#ifndef _DBHELPER_DBCONVERSION_HXX_
#include "connectivity/dbconversion.hxx"
-#endif
#include <rtl/ustrbuf.hxx>
#include <sal/macros.h>
diff --git a/cppuhelper/inc/cppuhelper/interfacecontainer.h b/cppuhelper/inc/cppuhelper/interfacecontainer.h
index 6e935f3..774f900 100644
--- a/cppuhelper/inc/cppuhelper/interfacecontainer.h
+++ b/cppuhelper/inc/cppuhelper/interfacecontainer.h
@@ -24,13 +24,9 @@
#include <rtl/alloc.h>
#include <com/sun/star/uno/Sequence.hxx>
#include <com/sun/star/uno/XInterface.hpp>
-#ifndef _COM_SUN_STAR_LANG_EVENTOBJECT_HXX_
#include <com/sun/star/lang/EventObject.hpp>
-#endif
-#ifndef _COM_SUN_STAR_LANG_DISPOSEDEXCEPTION_HXX_
#include "com/sun/star/lang/DisposedException.hpp"
-#endif
#include "cppuhelperdllapi.h"
/** */ //for docpp
diff --git a/dbaccess/inc/dbaccessdllapi.h b/dbaccess/inc/dbaccessdllapi.h
index 673522d..aff4e96 100644
--- a/dbaccess/inc/dbaccessdllapi.h
+++ b/dbaccess/inc/dbaccessdllapi.h
@@ -20,9 +20,7 @@
#ifndef INCLUDED_DBACCESSDLLAPI_H
#define INCLUDED_DBACCESSDLLAPI_H
-#ifndef _SAL_TYPES_H_
#include "sal/types.h"
-#endif
#if defined(DBACCESS_DLLIMPLEMENTATION)
#define DBACCESS_DLLPUBLIC SAL_DLLPUBLIC_EXPORT
diff --git a/embedserv/source/inc/embservconst.h b/embedserv/source/inc/embservconst.h
index 9322aef..7c876a6 100644
--- a/embedserv/source/inc/embservconst.h
+++ b/embedserv/source/inc/embservconst.h
@@ -22,9 +22,7 @@
#include <guiddef.h>
-#ifndef _COMPHELPER_CLASSIDS_HXX
#include <comphelper/classids.hxx>
-#endif
#if defined __MINGW32__
#pragma GCC diagnostic warning "-Wmissing-braces"
diff --git a/filter/source/svg/impsvgdialog.hxx b/filter/source/svg/impsvgdialog.hxx
index 40318e2..563a874 100644
--- a/filter/source/svg/impsvgdialog.hxx
+++ b/filter/source/svg/impsvgdialog.hxx
@@ -20,13 +20,8 @@
#ifndef IMPSVGDIALOG_HXX
#define IMPSVGDIALOG_HXX
-#ifndef _COM_SUN_STAR_UNO_SEQUENCE_H_
#include <com/sun/star/uno/Sequence.h>
-#endif
-
-#ifndef _COM_SUN_STAR_BEANS_PROPERTYVALUE_HPP_
#include <com/sun/star/beans/PropertyValue.hpp>
-#endif
#include <vcl/dialog.hxx>
#include <vcl/button.hxx>
diff --git a/filter/source/svg/svgdialog.hxx b/filter/source/svg/svgdialog.hxx
index 928d9a9..02a61b5 100644
--- a/filter/source/svg/svgdialog.hxx
+++ b/filter/source/svg/svgdialog.hxx
@@ -20,12 +20,8 @@
#ifndef SVGDIALOG_HXX
#define SVGDIALOG_HXX
-#ifndef _COM_SUN_STAR_BEANS_XPROPERTYACCESS_HPP_
#include <com/sun/star/beans/XPropertyAccess.hpp>
-#endif
-#ifndef _COM_SUN_STAR_DOCUMENT_XEXPORTER_HPP_
#include <com/sun/star/document/XExporter.hpp>
-#endif
#include <svtools/genericunodialog.hxx>
#include <memory>
diff --git a/fpicker/source/aqua/AquaFilePickerDelegate.mm b/fpicker/source/aqua/AquaFilePickerDelegate.mm
index 79d25b9..34385b6 100644
--- a/fpicker/source/aqua/AquaFilePickerDelegate.mm
+++ b/fpicker/source/aqua/AquaFilePickerDelegate.mm
@@ -19,14 +19,8 @@
#include <com/sun/star/ui/dialogs/ExtendedFilePickerElementIds.hpp>
#include <com/sun/star/uno/Any.hxx>
-#ifndef _SALAQUAFILEPICKER_HXX_
#include "SalAquaFilePicker.hxx"
-#endif
-
-#ifndef _FILTERHELPER_HXX_
#include "FilterHelper.hxx"
-#endif
-
#include "AquaFilePickerDelegate.hxx"
@implementation AquaFilePickerDelegate
diff --git a/fpicker/source/aqua/NSString_OOoAdditions.mm b/fpicker/source/aqua/NSString_OOoAdditions.mm
index e722d70..66391a9 100644
--- a/fpicker/source/aqua/NSString_OOoAdditions.mm
+++ b/fpicker/source/aqua/NSString_OOoAdditions.mm
@@ -17,10 +17,7 @@
* the License at http://www.apache.org/licenses/LICENSE-2.0 .
*/
-#ifndef _CFSTRINGUTILITIES_HXX_
#include "CFStringUtilities.hxx"
-#endif
-
#include "NSString_OOoAdditions.hxx"
#define CLASS_NAME "NSString"
diff --git a/fpicker/source/aqua/NSURL_OOoAdditions.mm b/fpicker/source/aqua/NSURL_OOoAdditions.mm
index d7cd854..c4567eb 100644
--- a/fpicker/source/aqua/NSURL_OOoAdditions.mm
+++ b/fpicker/source/aqua/NSURL_OOoAdditions.mm
@@ -17,10 +17,7 @@
* the License at http://www.apache.org/licenses/LICENSE-2.0 .
*/
-#ifndef _NSSTRING_OOOADDITIONS_HXX_
#include "NSString_OOoAdditions.hxx"
-#endif
-
#include "NSURL_OOoAdditions.hxx"
#include "sal/log.hxx"
diff --git a/framework/inc/classes/filtercache.hxx b/framework/inc/classes/filtercache.hxx
index 9fe0fe5..c4521d1 100644
--- a/framework/inc/classes/filtercache.hxx
+++ b/framework/inc/classes/filtercache.hxx
@@ -45,9 +45,7 @@
#include <rtl/ustring.hxx>
#ifdef ENABLE_GENERATEFILTERCACHE
- #ifndef _RTL_USTRBUF_HXX_
#include <rtl/ustrbuf.hxx>
- #endif
#endif
namespace framework{
diff --git a/framework/inc/framework/toolboxconfiguration.hxx b/framework/inc/framework/toolboxconfiguration.hxx
index b8282bc..a296231 100644
--- a/framework/inc/framework/toolboxconfiguration.hxx
+++ b/framework/inc/framework/toolboxconfiguration.hxx
@@ -22,9 +22,7 @@
#include <framework/fwedllapi.h>
#include <vcl/bitmap.hxx>
#include <com/sun/star/io/XInputStream.hpp>
-#ifndef _COM_SUN_STAR_IO_XOUPUTSTREAM_HPP_
#include <com/sun/star/io/XOutputStream.hpp>
-#endif
#include <com/sun/star/container/XIndexContainer.hpp>
#include <com/sun/star/container/XIndexAccess.hpp>
#include <com/sun/star/lang/XMultiServiceFactory.hpp>
diff --git a/framework/inc/macros/debug/assertion.hxx b/framework/inc/macros/debug/assertion.hxx
index 28988ec..9e89007 100644
--- a/framework/inc/macros/debug/assertion.hxx
+++ b/framework/inc/macros/debug/assertion.hxx
@@ -22,13 +22,8 @@
#if defined( ENABLE_ASSERTIONS ) || defined( ENABLE_WARNINGS )
- #ifndef _OSL_DIAGNOSE_H_
#include <osl/diagnose.h>
- #endif
-
- #ifndef _RTL_STRBUF_HXX_
#include <rtl/strbuf.hxx>
- #endif
#endif
diff --git a/framework/inc/macros/debug/event.hxx b/framework/inc/macros/debug/event.hxx
index 72865cf..4a7a05f 100644
--- a/framework/inc/macros/debug/event.hxx
+++ b/framework/inc/macros/debug/event.hxx
@@ -26,9 +26,7 @@
#ifdef ENABLE_EVENTDEBUG
- #ifndef _RTL_STRBUF_HXX_
#include <rtl/strbuf.hxx>
- #endif
/*_____________________________________________________________________________________________________________
LOGFILE_EVENTDEBUG
diff --git a/framework/inc/macros/debug/filterdbg.hxx b/framework/inc/macros/debug/filterdbg.hxx
index ffcc441..05790db 100644
--- a/framework/inc/macros/debug/filterdbg.hxx
+++ b/framework/inc/macros/debug/filterdbg.hxx
@@ -28,9 +28,7 @@
#ifdef ENABLE_FILTERDBG
- #ifndef _RTL_STRBUF_HXX_
#include <rtl/strbuf.hxx>
- #endif
/*_____________________________________________________________________________________________________________
LOGFILE_FILTERDBG
diff --git a/framework/inc/macros/debug/logmechanism.hxx b/framework/inc/macros/debug/logmechanism.hxx
index 59c177a..dd3be0f 100644
--- a/framework/inc/macros/debug/logmechanism.hxx
+++ b/framework/inc/macros/debug/logmechanism.hxx
@@ -26,10 +26,7 @@
#ifdef ENABLE_LOGMECHANISM
- #ifndef _RTL_STRING_HXX_
#include <rtl/string.hxx>
- #endif
-
#include <stdio.h>
/*_____________________________________________________________________________________________________________
diff --git a/framework/inc/macros/debug/mutex.hxx b/framework/inc/macros/debug/mutex.hxx
index e212f99..b7c1b7d 100644
--- a/framework/inc/macros/debug/mutex.hxx
+++ b/framework/inc/macros/debug/mutex.hxx
@@ -26,9 +26,7 @@
#ifdef ENABLE_MUTEXDEBUG
- #ifndef _RTL_STRBUF_HXX_
#include <rtl/strbuf.hxx>
- #endif
/*_____________________________________________________________________________________________________________
LOGFILE_MUTEX
diff --git a/framework/inc/macros/debug/plugin.hxx b/framework/inc/macros/debug/plugin.hxx
index afef0c9..f4cfb0a 100644
--- a/framework/inc/macros/debug/plugin.hxx
+++ b/framework/inc/macros/debug/plugin.hxx
@@ -26,13 +26,8 @@
#ifdef ENABLE_PLUGINDEBUG
- #ifndef _RTL_STRBUF_HXX_
#include <rtl/strbuf.hxx>
- #endif
-
- #ifndef _RTL_STRING_HXX_
#include <rtl/string.hxx>
- #endif
/*_____________________________________________________________________________________________________________
LOGFILE_PLUGIN
diff --git a/framework/inc/macros/debug/registration.hxx b/framework/inc/macros/debug/registration.hxx
index 0b936dd..1d6fc24 100644
--- a/framework/inc/macros/debug/registration.hxx
+++ b/framework/inc/macros/debug/registration.hxx
@@ -26,9 +26,7 @@
#ifdef ENABLE_REGISTRATIONDEBUG
- #ifndef _RTL_STRBUF_HXX_
#include <rtl/strbuf.hxx>
- #endif
/*_____________________________________________________________________________________________________________
LOGFILE_ASSERTIONS
diff --git a/framework/inc/macros/debug/targeting.hxx b/framework/inc/macros/debug/targeting.hxx
index 1e8b54a..0c16898 100644
--- a/framework/inc/macros/debug/targeting.hxx
+++ b/framework/inc/macros/debug/targeting.hxx
@@ -26,9 +26,7 @@
#ifdef ENABLE_TARGETINGDEBUG
- #ifndef _RTL_STRBUF_HXX_
#include <rtl/strbuf.hxx>
- #endif
/*_____________________________________________________________________________________________________________
LOGFILE_TARGETING
diff --git a/framework/inc/stdtypes.h b/framework/inc/stdtypes.h
index 7cb7bfd..c73f0eb 100644
--- a/framework/inc/stdtypes.h
+++ b/framework/inc/stdtypes.h
@@ -26,9 +26,7 @@
#include <general.h>
-#ifndef __COM_SUN_STAR_AWT_KEYEVENT_HPP_
#include <com/sun/star/awt/KeyEvent.hpp>
-#endif
#include <comphelper/sequenceasvector.hxx>
#include <cppuhelper/interfacecontainer.hxx>
diff --git a/idlc/source/parser.y b/idlc/source/parser.y
index 3da099c..8729a63 100644
--- a/idlc/source/parser.y
+++ b/idlc/source/parser.y
@@ -23,69 +23,28 @@
%{
#include <string.h>
-#ifndef _IDLC_IDLC_HXX_
#include <idlc/idlc.hxx>
-#endif
-#ifndef _IDLC_ERRORHANDLER_HXX_
#include <idlc/errorhandler.hxx>
-#endif
-#ifndef _IDLC_FEHELPER_HXX_
#include <idlc/fehelper.hxx>
-#endif
-#ifndef _IDLC_EXPRESSION_HXX_
#include <idlc/astexpression.hxx>
-#endif
-#ifndef _IDLC_ASTCONSTANTS_HXX_
#include <idlc/astconstants.hxx>
-#endif
-#ifndef _IDLC_ASTCONSTANT_HXX_
#include <idlc/astconstant.hxx>
-#endif
-#ifndef _IDLC_ASTARRAY_HXX_
#include <idlc/astarray.hxx>
-#endif
-#ifndef _IDLC_ASTBASETYPE_HXX_
#include <idlc/astbasetype.hxx>
-#endif
-#ifndef _IDLC_ASTTYPEDEF_HXX_
#include <idlc/asttypedef.hxx>
-#endif
-#ifndef _IDLC_ASTEXCEPTION_HXX_
#include <idlc/astexception.hxx>
-#endif
-#ifndef _IDLC_ASTMEMBER_HXX_
#include <idlc/astmember.hxx>
-#endif
-#ifndef _IDLC_ASTENUM_HXX_
#include <idlc/astenum.hxx>
-#endif
-#ifndef _IDLC_ASTSEQUENCE_HXX_
#include <idlc/astsequence.hxx>
-#endif
-#ifndef _IDLC_ASTATTRIBUTE_HXX_
#include <idlc/astattribute.hxx>
-#endif
-#ifndef _IDLC_ASTOPERATION_HXX_
#include <idlc/astoperation.hxx>
-#endif
-#ifndef _IDLC_ASTPARAMETER_HXX_
#include <idlc/astparameter.hxx>
-#endif
-#ifndef _IDLC_ASTINTERFACEMEMBER_HXX_
#include <idlc/astinterfacemember.hxx>
-#endif
-#ifndef _IDLC_ASTSERVICEMEMBER_HXX_
#include <idlc/astservicemember.hxx>
-#endif
-#ifndef _IDLC_ASTOBSERVES_HXX_
#include <idlc/astobserves.hxx>
-#endif
-#ifndef _IDLC_ASTNEEDS_HXX_
#include <idlc/astneeds.hxx>
-#endif
-#ifndef _IDLC_ASTUNION_HXX_
#include <idlc/astunion.hxx>
-#endif
+
#include "idlc/aststructinstance.hxx"
#include "attributeexceptions.hxx"
diff --git a/idlc/source/scanner.l b/idlc/source/scanner.l
index 166c281..aed48cf 100644
--- a/idlc/source/scanner.l
+++ b/idlc/source/scanner.l
@@ -29,15 +29,9 @@
#include <stdlib.h>
#include <string.h>
-#ifndef _IDLC_IDLC_HXX_
#include <idlc/idlc.hxx>
-#endif
-#ifndef _IDLC_ERRORHANDLER_HXX_
#include <idlc/errorhandler.hxx>
-#endif
-#ifndef _IDLC_FEHELPER_HXX_
#include <idlc/fehelper.hxx>
-#endif
#include "attributeexceptions.hxx"
diff --git a/lotuswordpro/source/filter/lwpfoundry.hxx b/lotuswordpro/source/filter/lwpfoundry.hxx
index 60dea4f..e7241e0 100644
--- a/lotuswordpro/source/filter/lwpfoundry.hxx
+++ b/lotuswordpro/source/filter/lwpfoundry.hxx
@@ -66,19 +66,13 @@
#define _LWPFOUNDRY_HXX
#include "lwpheader.hxx"
-
-#ifndef _LWPOBJECTID_HXX
#include "lwpobjid.hxx"
-#endif
-
-#ifndef _LWPOBJECTSTREAM_HXX
#include "lwpobjstrm.hxx"
-#endif
-
#include "lwpcolor.hxx"
#include "lwpbasetype.hxx"
#include "lwpfont.hxx"
#include "lwpdropcapmgr.hxx"
+
class LwpDocument;
class LwpBookMark;
diff --git a/lotuswordpro/source/filter/xfilter/xfglobal.hxx b/lotuswordpro/source/filter/xfilter/xfglobal.hxx
index 53957ae..496c77f 100644
--- a/lotuswordpro/source/filter/xfilter/xfglobal.hxx
+++ b/lotuswordpro/source/filter/xfilter/xfglobal.hxx
@@ -63,33 +63,16 @@
#include <cassert>
-#ifndef _SAL_TYPES_H
#include "sal/types.h"
-#endif
-#ifndef _RTL_USTRING_HXX_
#include <rtl/ustring.hxx>
-#endif
-#ifndef _IXFOBJECT_HXX
#include "ixfobject.hxx"
-#endif
-
-#ifndef _IXFSTREAM_HXX
#include "ixfstream.hxx"
-#endif
-
-#ifndef _IXFATTRLIST_HXX
#include "ixfattrlist.hxx"
-#endif
-#ifndef _XFUTIL_HXX
#include "xfutil.hxx"
-#endif
-
-#ifndef _XFDEFS_HXX
#include "xfdefs.hxx"
-#endif
#define PI 3.1415926
#define FLOAT_MIN 0.001
diff --git a/rsc/inc/rscerror.h b/rsc/inc/rscerror.h
index 56e0d29..28b70162 100644
--- a/rsc/inc/rscerror.h
+++ b/rsc/inc/rscerror.h
@@ -19,9 +19,7 @@
#ifndef _RSCERROR_H
#define _RSCERROR_H
-#ifndef _TOOLS_SOLAR_H
#include <tools/solar.h>
-#endif
/****************** D E F I N I T I O N S ********************************/
/******************* R e t u r n E r r o r s *******************/
diff --git a/rsc/source/rscpp/cpp.h b/rsc/source/rscpp/cpp.h
index 33f4970..e27a64d 100644
--- a/rsc/source/rscpp/cpp.h
+++ b/rsc/source/rscpp/cpp.h
@@ -302,17 +302,9 @@ void InitCpp6();
#define HELLO() fprintf( stderr, "[Hello at %s, %d] ", __FILE__, __LINE__ )
-#ifndef _STDIO_H
#include <stdio.h>
-#endif
-
-#ifndef _STDLIB_H
#include <stdlib.h>
-#endif
-
-#ifndef _STRING_H
#include <string.h>
-#endif
/* cpp1.c */
void output( int c );
diff --git a/rsc/source/rscpp/cpp3.c b/rsc/source/rscpp/cpp3.c
index 48b5d1d..df5a2c7 100644
--- a/rsc/source/rscpp/cpp3.c
+++ b/rsc/source/rscpp/cpp3.c
@@ -26,9 +26,7 @@
#include "time.h" /* BP */
-#ifndef _STRING_H
#include <string.h>
-#endif
#ifndef _NO_PROTO
int AddInclude( char *pIncStr ); /* BP, 11.09.91, Forward-Deklaration */
diff --git a/sal/inc/rtl/textenc.h b/sal/inc/rtl/textenc.h
index 436ffbe..676f8c2 100644
--- a/sal/inc/rtl/textenc.h
+++ b/sal/inc/rtl/textenc.h
@@ -26,9 +26,7 @@
#else /* !_SOLAR_RSC_INVOKED */
-#ifndef _SAL_TYPES_H
#include <sal/types.h>
-#endif
/** The various supported text encodings.
diff --git a/sal/inc/sal/config.h b/sal/inc/sal/config.h
index e990e35..ee230fe 100644
--- a/sal/inc/sal/config.h
+++ b/sal/inc/sal/config.h
@@ -24,10 +24,7 @@
#include "config_global.h"
#endif
-#ifndef INCLUDED_STDLIB_H
#include <stdlib.h>
-#define INCLUDED_STDLIB_H
-#endif
#ifdef WIN32
#define SAL_W32
diff --git a/sal/inc/sal/main.h b/sal/inc/sal/main.h
index 8648e38..634b57c 100644
--- a/sal/inc/sal/main.h
+++ b/sal/inc/sal/main.h
@@ -69,10 +69,7 @@ int SAL_CALL main(int argc, char ** argv) \
#ifdef SAL_W32
-#ifndef INCLUDED_STDLIB_H
#include <stdlib.h>
-#define INCLUDED_STDLIB_H
-#endif
/* Sorry but this is neccessary cause HINSTANCE is a typedef that differs (C++ causes an error) */
diff --git a/sal/osl/unx/file_path_helper.h b/sal/osl/unx/file_path_helper.h
index 61f64e7..28a96c1 100644
--- a/sal/osl/unx/file_path_helper.h
+++ b/sal/osl/unx/file_path_helper.h
@@ -20,15 +20,8 @@
#ifndef _OSL_FILE_PATH_HELPER_H_
#define _OSL_FILE_PATH_HELPER_H_
-
- #ifndef _SAL_TYPES_H_
#include <sal/types.h>
- #endif
-
- #ifndef _RTL_USTRING_H_
#include <rtl/ustring.h>
- #endif
-
#ifdef __cplusplus
extern "C"
diff --git a/sal/osl/unx/tempfile.c b/sal/osl/unx/tempfile.c
index 0f57e04..3d60477 100644
--- a/sal/osl/unx/tempfile.c
+++ b/sal/osl/unx/tempfile.c
@@ -17,10 +17,6 @@
* the License at http://www.apache.org/licenses/LICENSE-2.0 .
*/
-/*****************************************************************/
-/* Includes */
-/*****************************************************************/
-
#include <stdio.h>
#include <stdlib.h>
#include <sys/types.h>
@@ -33,9 +29,7 @@
#include <osl/diagnose.h>
#include <sal/macros.h>
-#ifndef _FILE_URL_H_
#include "file_url.h"
-#endif
oslFileError SAL_CALL osl_getTempDirURL( rtl_uString** pustrTempDir )
{
diff --git a/sal/osl/unx/uunxapi.h b/sal/osl/unx/uunxapi.h
index d13e20e..f6bc1f2 100644
--- a/sal/osl/unx/uunxapi.h
+++ b/sal/osl/unx/uunxapi.h
@@ -20,26 +20,11 @@
#ifndef _OSL_UUNXAPI_H_
#define _OSL_UUNXAPI_H_
- #ifndef _UNISTD_H
#include <unistd.h>
- #endif
-
- #ifndef _STDLIB_H
#include <stdlib.h>
- #endif
-
- #ifndef _TYPES_H
#include <sys/types.h>
- #endif
-
- #ifndef _STAT_H
#include <sys/stat.h>
- #endif
-
- #ifndef _RTL_USTRING_H_
#include <rtl/ustring.h>
- #endif
-
#ifdef __cplusplus
extern "C"
diff --git a/sal/osl/unx/uunxapi.hxx b/sal/osl/unx/uunxapi.hxx
index 066e45e..0419ebe 100644
--- a/sal/osl/unx/uunxapi.hxx
+++ b/sal/osl/unx/uunxapi.hxx
@@ -20,13 +20,9 @@
#ifndef _OSL_UUNXAPI_HXX_
#define _OSL_UUNXAPI_HXX_
-#ifndef _OSL_UUNXAPI_H_
#include "uunxapi.h"
-#endif
-#ifndef _RTL_USTRING_HXX_
#include <rtl/ustring.hxx>
-#endif
namespace osl
{
diff --git a/sal/qa/OStringBuffer/rtl_String_Const.h b/sal/qa/OStringBuffer/rtl_String_Const.h
index 62248d5..d07d7e9 100644
--- a/sal/qa/OStringBuffer/rtl_String_Const.h
+++ b/sal/qa/OStringBuffer/rtl_String_Const.h
@@ -20,23 +20,12 @@
#ifndef _RTL_STRING_CONST_H_
#define _RTL_STRING_CONST_H_
-#ifndef _RTL_STRING_UTILS_HXX_
- #include <rtl_String_Utils.hxx>
-#endif
+#include <rtl_String_Utils.hxx>
#include <limits.h>
-
-#ifndef _SAL_TYPES_H_
- #include <sal/types.h>
-#endif
-
-#ifndef _RTL_TEXTENC_H
- #include <rtl/textenc.h>
-#endif
-
-#ifndef _RTL_USTRING_H_
- #include <rtl/ustring.h>
-#endif
+#include <sal/types.h>
+#include <rtl/textenc.h>
+#include <rtl/ustring.h>
#ifdef __cplusplus
extern "C"
diff --git a/sal/qa/OStringBuffer/rtl_String_Utils.hxx b/sal/qa/OStringBuffer/rtl_String_Utils.hxx
index f0501cb..a824ef9 100644
--- a/sal/qa/OStringBuffer/rtl_String_Utils.hxx
+++ b/sal/qa/OStringBuffer/rtl_String_Utils.hxx
@@ -25,17 +25,9 @@
#include <math.h>
#include <stdlib.h>
-#ifndef _SAL_TYPES_H_
- #include <sal/types.h>
-#endif
-
-#ifndef _RTL_USTRING_H_
- #include <rtl/ustring.h>
-#endif
-
-#ifndef _RTL_STRING_HXX_
- #include <rtl/string.hxx>
-#endif
+#include <sal/types.h>
+#include <rtl/ustring.h>
+#include <rtl/string.hxx>
sal_Char* cpystr( sal_Char* dst, const sal_Char* src );
sal_Char* cpynstr( sal_Char* dst, const sal_Char* src, sal_uInt32 cnt );
diff --git a/sal/qa/OStringBuffer/rtl_String_Utils_Const.h b/sal/qa/OStringBuffer/rtl_String_Utils_Const.h
index 8e8d945..e855199 100644
--- a/sal/qa/OStringBuffer/rtl_String_Utils_Const.h
+++ b/sal/qa/OStringBuffer/rtl_String_Utils_Const.h
@@ -20,9 +20,7 @@
#ifndef _RTL_STRING_UTILS_CONST_H_
#define _RTL_STRING_UTILS_CONST_H_
-#ifndef _SAL_TYPES_H_
- #include <sal/types.h>
-#endif
+#include <sal/types.h>
#ifdef __cplusplus
extern "C"
diff --git a/sal/qa/osl/condition/osl_Condition_Const.h b/sal/qa/osl/condition/osl_Condition_Const.h
index 6101914..04b6d13 100644
--- a/sal/qa/osl/condition/osl_Condition_Const.h
+++ b/sal/qa/osl/condition/osl_Condition_Const.h
@@ -22,16 +22,10 @@
#include <sal/types.h>
#include <rtl/ustring.hxx>
-
-#ifndef _OSL_THREAD_HXX_
#include <osl/thread.hxx>
-#endif
#include <osl/mutex.hxx>
#include <osl/pipe.hxx>
-
-#ifndef _OSL_CONDITION_HXX_
#include <osl/conditn.hxx>
-#endif
#include <osl/time.h>
#ifdef UNX
diff --git a/sal/qa/osl/mutex/osl_Mutex_Const.h b/sal/qa/osl/mutex/osl_Mutex_Const.h
index 717431f..133f1f0 100644
--- a/sal/qa/osl/mutex/osl_Mutex_Const.h
+++ b/sal/qa/osl/mutex/osl_Mutex_Const.h
@@ -22,14 +22,8 @@
#include <sal/types.h>
#include <rtl/ustring.hxx>
-
-#ifndef _OSL_THREAD_HXX
#include <osl/thread.hxx>
-#endif
-
-#ifndef _OSL_MUTEX_HXX
#include <osl/mutex.hxx>
-#endif
#include <osl/time.h>
#ifdef UNX
diff --git a/sal/qa/osl/socket/osl_Socket_Const.h b/sal/qa/osl/socket/osl_Socket_Const.h
index 88ac501..c992fe7 100644
--- a/sal/qa/osl/socket/osl_Socket_Const.h
+++ b/sal/qa/osl/socket/osl_Socket_Const.h
@@ -24,23 +24,11 @@
#include <rtl/textenc.h>
#include <rtl/ustring.hxx>
#include <rtl/ustring.h>
-
-#ifndef _OSL_SOCLET_HXX_
#include <osl/socket.hxx>
-#endif
#include <osl/socket.h>
-
-#ifndef _OSL_THREAD_HXX
#include <osl/thread.hxx>
-#endif
-
-#ifndef _OSL_FILE_HXX
#include <osl/file.hxx>
-#endif
-
-#ifndef _OSL_MUTEX_HXX
#include <osl/mutex.hxx>
-#endif
#include <osl/time.h>
const char * pTestString1 = "test socket";
diff --git a/sal/qa/osl/socket/osl_Socket_Const_orig.h b/sal/qa/osl/socket/osl_Socket_Const_orig.h
index c3d87c1..ce63ed8 100644
--- a/sal/qa/osl/socket/osl_Socket_Const_orig.h
+++ b/sal/qa/osl/socket/osl_Socket_Const_orig.h
@@ -24,23 +24,11 @@
#include <rtl/textenc.h>
#include <rtl/ustring.hxx>
#include <rtl/ustring.h>
-
-#ifndef _OSL_SOCLET_HXX_
#include <osl/socket.hxx>
-#endif
#include <osl/socket.h>
-
-#ifndef _OSL_THREAD_HXX
#include <osl/thread.hxx>
-#endif
-
-#ifndef _OSL_FILE_HXX
#include <osl/file.hxx>
-#endif
-
-#ifndef _OSL_MUTEX_HXX
#include <osl/mutex.hxx>
-#endif
#include <osl/time.h>
const char * pTestString1 = "test socket";
diff --git a/sal/qa/rtl_strings/rtl_String_Const.h b/sal/qa/rtl_strings/rtl_String_Const.h
index e66a063..bc1fbe8 100644
--- a/sal/qa/rtl_strings/rtl_String_Const.h
+++ b/sal/qa/rtl_strings/rtl_String_Const.h
@@ -20,23 +20,13 @@
#ifndef _RTL_STRING_CONST_H_
#define _RTL_STRING_CONST_H_
-#ifndef _RTL_STRING_UTILS_HXX_
- #include <rtl_String_Utils.hxx>
-#endif
+#include <rtl_String_Utils.hxx>
#include <limits.h>
-#ifndef _SAL_TYPES_H_
- #include <sal/types.h>
-#endif
-
-#ifndef _RTL_TEXTENC_H
- #include <rtl/textenc.h>
-#endif
-
-#ifndef _RTL_USTRING_H_
- #include <rtl/ustring.h>
-#endif
+#include <sal/types.h>
+#include <rtl/textenc.h>
+#include <rtl/ustring.h>
... etc. - the rest is truncated
More information about the Libreoffice-commits
mailing list