[Libreoffice-commits] core.git: sc/source

Petr Kraus petr_kraus at email.cz
Wed Mar 27 03:10:41 PDT 2013


 sc/source/core/tool/interpr4.cxx |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

New commits:
commit 00e9accbc591791b6529105807a2944cd92dde78
Author: Petr Kraus <petr_kraus at email.cz>
Date:   Tue Mar 26 18:16:44 2013 +0100

    fdo#42781 WaE: unreachable code
    
    Encapsulate whole switch case code by #if
    so it does not produce unreachable code when TRUE
    Also found second occurence in function overload.
    
    Change-Id: I2f726b4e9cad56850ce360e48f96f45137befe96
    Reviewed-on: https://gerrit.libreoffice.org/3066
    Reviewed-by: Christoph Brill <egore911 at gmail.com>
    Reviewed-by: Tomáš Chvátal <tchvatal at suse.cz>
    Tested-by: Tomáš Chvátal <tchvatal at suse.cz>

diff --git a/sc/source/core/tool/interpr4.cxx b/sc/source/core/tool/interpr4.cxx
index bfd9494..a3d77ff 100644
--- a/sc/source/core/tool/interpr4.cxx
+++ b/sc/source/core/tool/interpr4.cxx
@@ -543,10 +543,10 @@ double ScInterpreter::GetCellValueOrZero( const ScAddress& rPos, const ScBaseCel
         break;
 #if OSL_DEBUG_LEVEL > 0
         case CELLTYPE_DESTROYED:
-#endif
             SetError(errCellNoValue);
             fValue = 0.0;
         break;
+#endif
     }
 
     return fValue;
@@ -610,10 +610,10 @@ double ScInterpreter::GetCellValueOrZero( ScCellIterator& rIter )
         break;
 #if OSL_DEBUG_LEVEL > 0
         case CELLTYPE_DESTROYED:
-#endif
             SetError(errCellNoValue);
             fValue = 0.0;
         break;
+#endif
     }
 
     return fValue;


More information about the Libreoffice-commits mailing list