[Libreoffice-commits] core.git: basctl/source

Armin Le Grand alg at apache.org
Thu May 2 03:27:24 PDT 2013


 basctl/source/basicide/baside3.cxx |    5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

New commits:
commit 96004917df7f93203c04ad879702c3fe03161c16
Author: Armin Le Grand <alg at apache.org>
Date:   Thu Aug 16 08:59:54 2012 +0000

    Related: #i120515# fixed memory leak
    
    (cherry picked from commit b24737fc55e797d03002d44a1fa325a101617c55)
    
    Change-Id: Ib59957fb2c9e198012898293aaa2e5afbe561ef4

diff --git a/basctl/source/basicide/baside3.cxx b/basctl/source/basicide/baside3.cxx
index debf652..2643400 100644
--- a/basctl/source/basicide/baside3.cxx
+++ b/basctl/source/basicide/baside3.cxx
@@ -225,7 +225,10 @@ void DialogWindow::Command( const CommandEvent& rCEvt )
 
 IMPL_LINK( DialogWindow, NotifyUndoActionHdl, SfxUndoAction *, pUndoAction )
 {
-    (void)pUndoAction;
+    // #i120515# pUndoAction needs to be deleted, this hand over is an ownership
+    // change. As long as it does not get added to the undo manager, it needs at
+    // least to be deleted.
+    delete pUndoAction;
 
     return 0;
 }


More information about the Libreoffice-commits mailing list