[Libreoffice-commits] core.git: sd/source

[Gergő Mocsi]

 sd/source/ui/dlg/PhotoAlbumDialog.cxx |   10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

New commits:
commit b971a83f34c3204e9a57874d55e5f23229b62b7f
Author: Gergő Mocsi <gmocsi91 at gmail.com>
Date:   Fri Apr 19 05:14:03 2013 +0200

    Create Photo Album fix
    
    Fixed some UI tweaks in handler function DownHdl: now images can me moved down correctly. Also, made some
    simplification in handler UpHdl: I've moved forvard the declaration of local variable nActPos.
    
    Change-Id: I879a6394865bb8442c0621dc2789efd9eedae87c
    Reviewed-on: https://gerrit.libreoffice.org/3759
    Reviewed-by: Andras Timar <atimar at suse.com>
    Tested-by: Andras Timar <atimar at suse.com>

diff --git a/sd/source/ui/dlg/PhotoAlbumDialog.cxx b/sd/source/ui/dlg/PhotoAlbumDialog.cxx
index 5d6ba1e..fc4b256 100644
--- a/sd/source/ui/dlg/PhotoAlbumDialog.cxx
+++ b/sd/source/ui/dlg/PhotoAlbumDialog.cxx
@@ -650,12 +650,12 @@ IMPL_LINK_NOARG(SdPhotoAlbumDialog, UpHdl)
     if (pImagesLst->GetSelectEntryPos() != LISTBOX_ENTRY_NOTFOUND
         && pImagesLst->GetSelectEntryPos() != 0)
     {
-        OUString sActEntry( pImagesLst->GetEntry(pImagesLst->GetSelectEntryPos()) );
+        sal_uInt16 nActPos = pImagesLst->GetSelectEntryPos();
+        OUString sActEntry( pImagesLst->GetEntry(nActPos) );
         // actual data
-        OUString* pActData = (OUString*) pImagesLst->GetEntryData(pImagesLst->GetSelectEntryPos());
+        OUString* pActData = (OUString*) pImagesLst->GetEntryData(nActPos);
         OUString sAct(*pActData);
 
-        sal_uInt16 nActPos = pImagesLst->GetSelectEntryPos();
         OUString sUpperEntry( pImagesLst->GetEntry(nActPos - 1) );
         // upper data
         OUString* pUpperData = (OUString*) pImagesLst->GetEntryData(nActPos - 1);
@@ -701,10 +701,10 @@ IMPL_LINK_NOARG(SdPhotoAlbumDialog, DownHdl)
         pImagesLst->RemoveEntry( sDownEntry );
 
         pImagesLst->InsertEntry( sDownEntry, nActPos );
-        pImagesLst->SetEntryData( nActPos, (void*) new OUString(sAct));
+        pImagesLst->SetEntryData( nActPos, (void*) new OUString(sDown));
 
         pImagesLst->InsertEntry( sActEntry, nActPos + 1 );
-        pImagesLst->SetEntryData( nActPos + 1, (void*) new OUString(sDown));
+        pImagesLst->SetEntryData( nActPos + 1, (void*) new OUString(sAct));
 
         pImagesLst->SelectEntryPos(nActPos + 1);