[Libreoffice-commits] core.git: dbaccess/source reportdesign/source

Julien Nabet serval2412 at yahoo.fr
Sun May 12 02:57:59 PDT 2013


 dbaccess/source/filter/xml/xmlDataSourceSetting.cxx   |    2 +-
 reportdesign/source/filter/xml/xmlControlProperty.cxx |    2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

New commits:
commit e13bd0cfc7cd395baa125fff86171d030be71f8c
Author: Julien Nabet <serval2412 at yahoo.fr>
Date:   Sun May 12 11:57:18 2013 +0200

    Fix possible inefficient checking for variables emptiness
    
    Change-Id: I95a6784d5448b63b0cdde436484915692f8633be

diff --git a/dbaccess/source/filter/xml/xmlDataSourceSetting.cxx b/dbaccess/source/filter/xml/xmlDataSourceSetting.cxx
index b9c779a..0316905 100644
--- a/dbaccess/source/filter/xml/xmlDataSourceSetting.cxx
+++ b/dbaccess/source/filter/xml/xmlDataSourceSetting.cxx
@@ -73,7 +73,7 @@ OXMLDataSourceSetting::OXMLDataSourceSetting( ODBFilter& rImport
                 {
                     // needs to be translated into a ::com::sun::star::uno::Type
                     static std::map< OUString, css::uno::Type > s_aTypeNameMap;
-                    if (!s_aTypeNameMap.size())
+                    if (s_aTypeNameMap.empty())
                     {
                         s_aTypeNameMap[GetXMLToken( XML_BOOLEAN)]   = ::getBooleanCppuType();
                         s_aTypeNameMap[GetXMLToken( XML_FLOAT)]     = ::getCppuType( static_cast< double* >(NULL) );
diff --git a/reportdesign/source/filter/xml/xmlControlProperty.cxx b/reportdesign/source/filter/xml/xmlControlProperty.cxx
index 7d4ec15..6509da4 100644
--- a/reportdesign/source/filter/xml/xmlControlProperty.cxx
+++ b/reportdesign/source/filter/xml/xmlControlProperty.cxx
@@ -86,7 +86,7 @@ OXMLControlProperty::OXMLControlProperty( ORptFilter& rImport
                 {
                     // needs to be translated into a ::com::sun::star::uno::Type
                     static std::map< OUString, css::uno::Type > s_aTypeNameMap;
-                    if (!s_aTypeNameMap.size())
+                    if (s_aTypeNameMap.empty())
                     {
                         s_aTypeNameMap[GetXMLToken( XML_BOOLEAN)]   = ::getBooleanCppuType();
                         s_aTypeNameMap[GetXMLToken( XML_FLOAT)]     = ::getCppuType( static_cast< double* >(NULL) );


More information about the Libreoffice-commits mailing list