[Libreoffice-commits] core.git: 2 commits - chart2/CppunitTest_chart2_export.mk chart2/CppunitTest_chart2_exporttest.mk chart2/CppunitTest_chart2_import.mk chart2/CppunitTest_chart2_importtest.mk chart2/Module_chart2.mk chart2/qa

Stephan Bergmann sbergman at redhat.com
Mon May 13 06:02:46 PDT 2013


 chart2/CppunitTest_chart2_export.mk     |  119 ++++++++++++++++++++++++++++++++
 chart2/CppunitTest_chart2_exporttest.mk |  119 --------------------------------
 chart2/CppunitTest_chart2_import.mk     |  118 +++++++++++++++++++++++++++++++
 chart2/CppunitTest_chart2_importtest.mk |  118 -------------------------------
 chart2/Module_chart2.mk                 |    2 
 chart2/qa/extras/chart2export.cxx       |   13 ++-
 6 files changed, 246 insertions(+), 243 deletions(-)

New commits:
commit 0ff2115b07c31663db45dcd71a7e6c554153dac2
Author: Stephan Bergmann <sbergman at redhat.com>
Date:   Mon May 13 15:01:55 2013 +0200

    Fix naming
    
    Change-Id: Ib2f9577429a4b9b97540de1eb40837ddafdc05b5

diff --git a/chart2/CppunitTest_chart2_exporttest.mk b/chart2/CppunitTest_chart2_export.mk
similarity index 100%
rename from chart2/CppunitTest_chart2_exporttest.mk
rename to chart2/CppunitTest_chart2_export.mk
diff --git a/chart2/CppunitTest_chart2_importtest.mk b/chart2/CppunitTest_chart2_import.mk
similarity index 100%
rename from chart2/CppunitTest_chart2_importtest.mk
rename to chart2/CppunitTest_chart2_import.mk
diff --git a/chart2/Module_chart2.mk b/chart2/Module_chart2.mk
index 3dacc4c..1cfe2ad 100644
--- a/chart2/Module_chart2.mk
+++ b/chart2/Module_chart2.mk
@@ -17,7 +17,7 @@ $(eval $(call gb_Module_add_targets,chart2,\
 ))
 
 $(eval $(call gb_Module_add_slowcheck_targets,chart2,\
-    CppunitTest_chart2_exporttest \
+    CppunitTest_chart2_export \
 ))
 
 $(eval $(call gb_Module_add_subsequentcheck_targets,chart2,\
commit 0c3a839f1e1ca16c1f41002cf00c8e21f05dd01c
Author: Stephan Bergmann <sbergman at redhat.com>
Date:   Mon May 13 15:01:41 2013 +0200

    -Werror=maybe-uninitialized
    
    Change-Id: I4959f52510b814f4becb47105c7fd61188ab0e31

diff --git a/chart2/qa/extras/chart2export.cxx b/chart2/qa/extras/chart2export.cxx
index ca7105c..3e645ab 100644
--- a/chart2/qa/extras/chart2export.cxx
+++ b/chart2/qa/extras/chart2export.cxx
@@ -39,15 +39,18 @@ namespace {
 void testErrorBar( Reference< XPropertySet > xErrorBar )
 {
     sal_Int32 nErrorBarStyle;
-    xErrorBar->getPropertyValue("ErrorBarStyle") >>= nErrorBarStyle;
+    CPPUNIT_ASSERT(
+        xErrorBar->getPropertyValue("ErrorBarStyle") >>= nErrorBarStyle);
     CPPUNIT_ASSERT_EQUAL(nErrorBarStyle, chart::ErrorBarStyle::RELATIVE);
-    bool bShowPositive, bShowNegative;
-    xErrorBar->getPropertyValue("ShowPositiveError") >>= bShowPositive;
+    bool bShowPositive = bool(), bShowNegative = bool();
+    CPPUNIT_ASSERT(
+        xErrorBar->getPropertyValue("ShowPositiveError") >>= bShowPositive);
     CPPUNIT_ASSERT(bShowPositive);
-    xErrorBar->getPropertyValue("ShowNegativeError") >>= bShowNegative;
+    CPPUNIT_ASSERT(
+        xErrorBar->getPropertyValue("ShowNegativeError") >>= bShowNegative);
     CPPUNIT_ASSERT(bShowNegative);
     double nVal;
-    xErrorBar->getPropertyValue("PositiveError") >>= nVal;
+    CPPUNIT_ASSERT(xErrorBar->getPropertyValue("PositiveError") >>= nVal);
     CPPUNIT_ASSERT_DOUBLES_EQUAL(nVal, 10.0, 1e-10);
 }
 


More information about the Libreoffice-commits mailing list