[Libreoffice-commits] core.git: dbaccess/source

[Petr Mladek]

 dbaccess/source/ui/dlg/generalpage.cxx |   10 +++-------
 1 file changed, 3 insertions(+), 7 deletions(-)

New commits:
commit 13df1b95e83a46e847311b49d4c14260cac682af
Author: Petr Mladek <pmladek at suse.cz>
Date:   Tue May 21 10:46:45 2013 +0200

    allow to create new database using the wizard again (fdo#62937)
    
    To be honest, I do not userstand the code much. Julien pointed out that
    the setParentTitle and onTypeSelected were newer called. The condition
    looked like an optimisation and it helped to remove it.
    
    It would be great to put it back. It might be enough to hand the
    intial values.
    
    Change-Id: Id06cc9c63a9e578cb3c698c8526851fec71ef9da

diff --git a/dbaccess/source/ui/dlg/generalpage.cxx b/dbaccess/source/ui/dlg/generalpage.cxx
index 6e72732..a881472 100644
--- a/dbaccess/source/ui/dlg/generalpage.cxx
+++ b/dbaccess/source/ui/dlg/generalpage.cxx
@@ -193,16 +193,12 @@ namespace dbaui
     {
         initializeTypeList();
 
-        const OUString eOldSelection = m_eCurrentSelection;
-
         m_pDatasourceType->SelectEntry( getDatasourceName( _rSet ) );
 
         // notify our listener that our type selection has changed (if so)
-        if ( eOldSelection != m_eCurrentSelection )
-        {
-            setParentTitle( m_eCurrentSelection );
-            onTypeSelected( m_eCurrentSelection );
-        }
+        // FIXME: how to detect that it did not changed? (fdo#62937)
+        setParentTitle( m_eCurrentSelection );
+        onTypeSelected( m_eCurrentSelection );
 
         // a special message for the current page state
         switchMessage( m_eCurrentSelection );