[Libreoffice-commits] core.git: sd/source

Mark Wielaard mark at klomp.org
Fri May 24 12:26:16 PDT 2013


 sd/source/ui/view/drviewsf.cxx |    3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

New commits:
commit a602bd1a69db5c6b4e0fa818324cdf4e0088778c
Author: Mark Wielaard <mark at klomp.org>
Date:   Fri May 24 08:55:45 2013 +0200

    Fix memory leak in DrawViewShell::GetAttrState().
    
    DrawViewShell::GetAttrState() might create a temporary new SvxNumRule
    object. Make sure it gets deleted when done.
    
    Change-Id: I33ddd9df983193fe87dd076267043d202cdfc3d5
    Reviewed-on: https://gerrit.libreoffice.org/4020
    Reviewed-by: Caolán McNamara <caolanm at redhat.com>
    Tested-by: Caolán McNamara <caolanm at redhat.com>

diff --git a/sd/source/ui/view/drviewsf.cxx b/sd/source/ui/view/drviewsf.cxx
index 4989cd2..89c90d0 100644
--- a/sd/source/ui/view/drviewsf.cxx
+++ b/sd/source/ui/view/drviewsf.cxx
@@ -630,9 +630,10 @@ void DrawViewShell::GetAttrState( SfxItemSet& rSet )
                             }
                         }
                     }
+                  delete pNumRule;
                 }
             }
-                    break;
+            break;
             //End
             // Added by Li Hui for story 179.
             case FN_NUM_BULLET_ON:


More information about the Libreoffice-commits mailing list