[Libreoffice-commits] core.git: sc/qa

Kohei Yoshida kohei.yoshida at collabora.com
Tue Nov 19 09:08:20 PST 2013


 sc/qa/unit/ucalc_formula.cxx |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

New commits:
commit d646612f99be91e0706e2f32ae8371a4e7019eb8
Author: Kohei Yoshida <kohei.yoshida at collabora.com>
Date:   Tue Nov 19 12:01:17 2013 -0500

    Narrow it down a bit for the next visit.
    
    Still no idea what the problem really is (MSVC is pretty silent about it)
    or how to fix it.
    
    Change-Id: I322779046f0adc0b2807a9d46a5c9140839b7ff7

diff --git a/sc/qa/unit/ucalc_formula.cxx b/sc/qa/unit/ucalc_formula.cxx
index b107165..29ecd5a 100644
--- a/sc/qa/unit/ucalc_formula.cxx
+++ b/sc/qa/unit/ucalc_formula.cxx
@@ -33,7 +33,6 @@ using namespace formula;
 
 void Test::testFormulaCreateStringFromTokens()
 {
-#if 0
     // Insert sheets.
     OUString aTabName1("Test");
     OUString aTabName2("Kevin's Data");
@@ -138,18 +137,19 @@ void Test::testFormulaCreateStringFromTokens()
         OUString aFormula = OUString::createFromAscii(aTests[i]);
         ScCompiler aComp(m_pDoc, aPos);
         aComp.SetGrammar(FormulaGrammar::GRAM_ENGLISH);
+#if 0 // TODO: This call to CompileString() causes the cppunittester to somehow fail on Windows.
         pArray.reset(aComp.CompileString(aFormula));
         CPPUNIT_ASSERT_MESSAGE("Failed to compile formula string.", pArray.get());
 
         OUString aCheck = pArray->CreateString(aCxt, aPos);
         CPPUNIT_ASSERT_EQUAL(aFormula, aCheck);
+#endif
     }
 
     m_pDoc->DeleteTab(3);
     m_pDoc->DeleteTab(2);
     m_pDoc->DeleteTab(1);
     m_pDoc->DeleteTab(0);
-#endif
 }
 
 namespace {


More information about the Libreoffice-commits mailing list