[Libreoffice-commits] core.git: 2 commits - basic/source sw/source

Caolán McNamara caolanm at redhat.com
Fri Oct 11 01:12:59 PDT 2013


 basic/source/runtime/methods.cxx |    2 +-
 sw/source/ui/docvw/romenu.cxx    |    3 ++-
 2 files changed, 3 insertions(+), 2 deletions(-)

New commits:
commit d22fb8a60881f96f0347b5eae6c67f056ddc53cc
Author: Caolán McNamara <caolanm at redhat.com>
Date:   Fri Oct 11 09:12:24 2013 +0100

    CID#1103740 uninitialized value
    
    Change-Id: I2d10104277d8ad0781e3dd088d51d62fa759fe57

diff --git a/basic/source/runtime/methods.cxx b/basic/source/runtime/methods.cxx
index 1180a81..4167152 100644
--- a/basic/source/runtime/methods.cxx
+++ b/basic/source/runtime/methods.cxx
@@ -1985,7 +1985,7 @@ RTLFUNC(CDateFromUnoTime)
 
 void SbxDateFromUNODateTime( SbxValue *pVal, const ::com::sun::star::util::DateTime& aUnoDT)
 {
-    double dDate;
+    double dDate(0.0);
     if( implDateTimeSerial( aUnoDT.Year, aUnoDT.Month, aUnoDT.Day,
                             aUnoDT.Hours, aUnoDT.Minutes, aUnoDT.Seconds,
                             dDate ) )
commit 17605133e01c7a58d5e2f10c441bf67582ae4898
Author: Caolán McNamara <caolanm at redhat.com>
Date:   Fri Oct 11 09:10:46 2013 +0100

    CID#1103774 avoid use after free
    
    Change-Id: I0cbe52bf48fb9a2611043c6c3e187b9db4414365

diff --git a/sw/source/ui/docvw/romenu.cxx b/sw/source/ui/docvw/romenu.cxx
index f478471..ea48000 100644
--- a/sw/source/ui/docvw/romenu.cxx
+++ b/sw/source/ui/docvw/romenu.cxx
@@ -198,13 +198,14 @@ SwReadOnlyPopup::SwReadOnlyPopup( const Point &rDPos, SwView &rV ) :
     Check( MN_READONLY_OPENURL,         SID_OPENDOC,        rDis );
     Check( MN_READONLY_OPENURLNEW,      SID_OPENDOC,        rDis );
 
-    SfxPoolItem* pState;
+    SfxPoolItem* pState = NULL;
 
     SfxItemState eState = pVFrame->GetBindings().QueryState( SID_COPY, pState );
     Check( MN_READONLY_COPY,            SID_COPY,           rDis );
     if(eState < SFX_ITEM_AVAILABLE)
         EnableItem( MN_READONLY_COPY, sal_False );
     delete pState;
+    pState = NULL;
 
     eState = pVFrame->GetBindings().QueryState( SID_EDITDOC, pState );
     if (


More information about the Libreoffice-commits mailing list