[Libreoffice-commits] core.git: Changes to 'private/kohei/calc-group-interpreter-3-backport'
Kohei Yoshida
kohei.yoshida at collabora.com
Fri Oct 11 14:56:42 PDT 2013
New branch 'private/kohei/calc-group-interpreter-3-backport' available with the following commits:
commit 3a5d17d4a4174058333ad846192bdf5b2efb5b62
Author: Kohei Yoshida <kohei.yoshida at collabora.com>
Date: Fri Oct 11 15:47:49 2013 -0400
Compare by pointers first.
Change-Id: Iec697f7100c06da37158e564ac64f0248f923638
commit ee01d3fb08a2874d2a5235eec380630c6f66ea17
Author: Kohei Yoshida <kohei.yoshida at collabora.com>
Date: Fri Oct 11 11:33:05 2013 -0400
Fix equality operator for SharedString & write test for it.
Change-Id: Ib592ca2fe359293da6c10aa9e1535a91627cfc43
commit 1ac8559e36e4173b65e9bd791a58a6b6a14c1b78
Author: Kohei Yoshida <kohei.yoshida at collabora.com>
Date: Fri Oct 11 11:23:54 2013 -0400
Use OUString & a bit more fine-grained unit test error messages.
Change-Id: I6d9ce2afd97d6011eaa93855c49f3d7071db0159
commit 2ff52032e26d44b12367a0721ad918d8098f6610
Author: Kohei Yoshida <kohei.yoshida at collabora.com>
Date: Thu Oct 10 23:23:55 2013 -0400
Spell check context can be NULL (when the live spell check is not on).
Change-Id: I785f83b5c2c6329b7a18af9f9721c06894207ea5
commit 1a872f6e12a781967728f42766b6b0a90975c21e
Author: Kohei Yoshida <kohei.yoshida at collabora.com>
Date: Thu Oct 10 23:08:08 2013 -0400
Fix VLOOKUP calculation when the matching value is literal string.
ScRawToken needed to store a shared string value rather than the normal
unicode string array. This fixes a previously failed unit test.
Conflicts:
sc/source/core/tool/compiler.cxx
Change-Id: I87164c018ace0761c40d1493f44fe25909a4499c
commit 4e0f2319290d579b6cdf036c8cfa7a7e2f4a84cd
Author: Kohei Yoshida <kohei.yoshida at collabora.com>
Date: Thu Oct 10 20:24:21 2013 -0400
Formula tokens, formula cells and formula interpreters to use shared strings.
Conflicts:
sc/source/core/inc/interpre.hxx
sc/source/core/tool/compiler.cxx
sc/source/core/tool/interpr1.cxx
sc/source/core/tool/interpr2.cxx
sc/source/core/tool/interpr4.cxx
sc/source/core/tool/interpr5.cxx
sc/source/core/tool/interpr6.cxx
sc/source/filter/excel/xeformula.cxx
sc/source/filter/excel/xelink.cxx
sc/source/filter/excel/xetable.cxx
sc/source/ui/app/transobj.cxx
sc/source/ui/unoobj/chart2uno.cxx
sc/source/ui/view/viewfun6.cxx
Change-Id: I5da99869fc7f61ce698180fa5daa9be9db9ac132
commit 9159e0cbfcac806bd10741c03a38ee9ad51c77d3
Author: Kohei Yoshida <kohei.yoshida at collabora.com>
Date: Thu Oct 10 10:28:35 2013 -0400
GetString() from ScMatrix to return SharedString.
And adjust all its call sites.
Change-Id: Ibb0c754e8fa105bd1a6035f2e0df5cee2d8491c4
commit c243173268dc2cfd35e0bb54ef9ec5dd4e9aa601
Author: Kohei Yoshida <kohei.yoshida at collabora.com>
Date: Wed Oct 9 22:12:12 2013 -0400
Properly intern strings going into matrix objects.
Change-Id: Ieb8befa4f19ebc31f4afa1370c924b469aa77382
commit a4a149f77250753402966ecb7820516049a1bb49
Author: Kohei Yoshida <kohei.yoshida at collabora.com>
Date: Wed Oct 9 19:06:08 2013 -0400
GetEditUrlOrError() is no more. Just use GetEditUrl().
Since it no longer checks for cells with misspelled words....
Change-Id: I372c283e0567c2e0e40d26eeb19dcf6e5d3f9e0f
commit 5835c9c722ef2f21e01692181ab232e7ffc2ae6b
Author: Kohei Yoshida <kohei.yoshida at collabora.com>
Date: Wed Oct 9 18:55:30 2013 -0400
Fix context menu launch on mis-spelled word in a cell.
This was broken when the spell check handler was re-implemented
after the cell storage rework.
Conflicts:
sc/source/ui/inc/gridwin.hxx
sc/source/ui/view/gridwin.cxx
Change-Id: I4e7e718ffba45b2163bea4dd382f2a49f75fd5f9
commit f0e4825d3c4dccd248e8aac49f4db1221a5b538f
Author: Kohei Yoshida <kohei.yoshida at collabora.com>
Date: Wed Oct 9 17:50:10 2013 -0400
We are supposed to keep track of max-length string.
Change-Id: I3a0d999f55d89734b26ee66c16cf8cadbcbac246
commit b93bcd484e66492e01eba8f3d6510d9509ce1c5e
Author: Kohei Yoshida <kohei.yoshida at collabora.com>
Date: Wed Oct 9 17:46:54 2013 -0400
Some cleanups to avoid unnecessary getString() calls.
Change-Id: I334d64f7731915d27e3b81781c91e330dc446010
commit 1c5af12b9c87b2fa16c633ef980563f74bb0b074
Author: Kohei Yoshida <kohei.yoshida at collabora.com>
Date: Wed Oct 9 16:16:46 2013 -0400
Make the same change to the orcus interface & remove unused methods.
Change-Id: I1263026133b694e531c0a99b16d622e1ae12db48
commit 5faacac1f223c11974ed0ce8b6a03daaddc43288
Author: Kohei Yoshida <kohei.yoshida at collabora.com>
Date: Wed Oct 9 15:44:59 2013 -0400
Import shared formulas from xlsx without crashing.
The key here is to only use the shared formula ID's and ignore the ref
range. The ref ranges are not correct half the time.
Change-Id: If65f9b1b44ab6239db37977b6dfe3f822a9cf67e
commit d1f5c9974829adf32165f7bd6cc7ae25b06a8952
Author: Kohei Yoshida <kohei.yoshida at collabora.com>
Date: Wed Oct 9 10:50:23 2013 -0400
Use shared string's fast equality check for ValidQuery().
Change-Id: Ib84087a10cc10a7533e64c4e8998354b52017df7
commit f87ed62d4305b9f6758a09303590eaa73d6beec7
Author: Kohei Yoshida <kohei.yoshida at collabora.com>
Date: Wed Oct 9 10:08:06 2013 -0400
Add isEmpty() to SharedString. This simplies a lot of its call sites.
Change-Id: I0ebc43abe59ac317c053a4f606dbe376d85c03b0
commit af3b27c35e1645544a94b059e484a1bbabffd12d
Author: Kohei Yoshida <kohei.yoshida at collabora.com>
Date: Tue Oct 8 21:46:56 2013 -0400
Store svl::SharedString in query entry items, and adjust all call sites.
Conflicts:
sc/source/core/data/dpcache.cxx
sc/source/core/data/table3.cxx
sc/source/core/tool/interpr1.cxx
sc/source/core/tool/queryparam.cxx
sc/source/filter/excel/excimp8.cxx
Change-Id: Ifd3bbb84c7abbe983a017a169c7e05914ef33450
commit 090cb6d7983872e1599f9717d703834fd1629d90
Author: Kohei Yoshida <kohei.yoshida at collabora.com>
Date: Tue Oct 8 15:18:16 2013 -0400
No more getIdentifier*() calls because they are not efficient.
They shall never be used.
Change-Id: I019c88b1511a67175d782777cd41e0ec0434f497
commit f4397a71ddb0574d3a46d147e9ae2786deb5ad4f
Author: Kohei Yoshida <kohei.yoshida at collabora.com>
Date: Tue Oct 8 13:47:49 2013 -0400
Support for passing non-double formula results from group interpreter.
Change-Id: I1cbe6b32d8a9b86a575e9806802f7a2a45eee873
commit 27d488dab295e51e3add75a668057a155a90e7d7
Author: Kohei Yoshida <kohei.yoshida at collabora.com>
Date: Tue Oct 8 11:24:16 2013 -0400
Add VLOOKUP to the list of functions we support for group calculation.
Change-Id: I2a440b881af14076928e97918bdc5508804ff0ee
commit dc5c7a4d18aba8b3ddf045fae1537d9ab3cdef07
Author: Kohei Yoshida <kohei.yoshida at collabora.com>
Date: Tue Oct 8 11:11:48 2013 -0400
Turns out we are not using OpenCL here in the existing interpreter.
Change-Id: I4d511ef8099b5d7fcff07adf401901c9ee089ad3
commit afc3fe7149627e963f2efddea7103a8ed0a2e8af
Author: Kohei Yoshida <kohei.yoshida at collabora.com>
Date: Tue Oct 8 10:30:15 2013 -0400
Let's not do this.
Change-Id: I93fe9f8c5edbfb08b78b6694771db2dd18d8868c
commit 5c70e6b07921f0308eafb417b140d291594eb49a
Author: Kohei Yoshida <kohei.yoshida at collabora.com>
Date: Tue Oct 8 10:08:59 2013 -0400
Handle edit text cells here as well as the string cells.
Change-Id: I46934341dbde93d963764152f663c4d2d310bea0
commit 2c863e0db33ed5244cbfac6fa168355c6cfe6126
Author: Kohei Yoshida <kohei.yoshida at collabora.com>
Date: Tue Oct 8 09:33:23 2013 -0400
Get the string ID's for case insensitive comparisons.
If we ever need to use this for case sensitive comparisons, we'll have to
find a way to conditionalize it.
Change-Id: Ibb862c4700d2fb660570fc80a80a03eed1d556c3
commit 9da3d1114a155ffdc294c553e35460f645617946
Author: Kohei Yoshida <kohei.yoshida at collabora.com>
Date: Tue Oct 8 09:27:27 2013 -0400
Rename GetCellStringPool() to GetSharedStringPool().
Change-Id: I99d373f7887424bb103cff60d53f5cd8ce337ef7
commit fc01569922445052ccd3b079ec50aa55df684bba
Author: Kohei Yoshida <kohei.yoshida at collabora.com>
Date: Tue Oct 8 09:14:48 2013 -0400
Use the document's string pool rather than a separate one for the formula.
Change-Id: Id13bca1ed493328fb0b8a664275af8c98e3f46c8
commit 491b6be41810aacdec4f266a7fc8a73be4f38268
Author: Kohei Yoshida <kohei.yoshida at collabora.com>
Date: Mon Oct 7 18:03:47 2013 -0400
Unused methods.
Change-Id: I8e70d2c730f0d8fa43a4270fddeca431bd7a5048
commit 060174a3eaf9235f5678c2f3ff9aa74539313401
Author: Kohei Yoshida <kohei.yoshida at collabora.com>
Date: Mon Oct 7 17:27:02 2013 -0400
Store svl::SharedString in document cell storage instead of OUString.
With this, both ScColumn and ScMatrix store svl::SharedString as their
string values, instead of OUString.
Conflicts:
sc/source/core/data/column3.cxx
sc/source/core/tool/interpr1.cxx
sc/source/core/tool/interpr5.cxx
sc/source/core/tool/rangeseq.cxx
Change-Id: I3faece94d98f774881fd72b3ed5f6143504cd350
commit 294101e587e0dee77ba1e7729fa288c548e7751a
Author: Kohei Yoshida <kohei.yoshida at collabora.com>
Date: Mon Oct 7 13:07:28 2013 -0400
ContentInfo to store svl::SharedString instead of OUString.
Change-Id: I633e3bb633317eeb61cd804faf20e79312f569f7
commit 5a57b55ca567ccada8874e3fc558d269821ad462
Author: Kohei Yoshida <kohei.yoshida at collabora.com>
Date: Mon Oct 7 12:31:42 2013 -0400
Avoid exposing aText; encapsulate it.
Change-Id: I7f6ba0735830b55e35b7e352a5e31fdda47a8dfb
commit 089438aee2e74636161e92dfa1376b18166644f7
Author: Kohei Yoshida <kohei.yoshida at collabora.com>
Date: Mon Oct 7 12:15:28 2013 -0400
Re-implement interning in order to return both string arrays.
One is for the cased string and the other one for the non-cased one.
Change-Id: I798687f2efecaaea73a09e0b3348f85a9d9e8c07
commit 680c6259c431065f0453b9b61b66e3c374518797
Author: Kohei Yoshida <kohei.yoshida at collabora.com>
Date: Fri Oct 4 20:36:54 2013 -0400
Slight optimization when copying OUString.
Change-Id: If934e18c0fd68d89d838ca9717aa2e4616bc3b6a
commit 4a86b7fbae884e41f666f5d87be4fde6f77b3e0a
Author: Kohei Yoshida <kohei.yoshida at collabora.com>
Date: Fri Oct 4 19:13:26 2013 -0400
Rename StringPool to SharedStringPool because that's what it is.
Change-Id: I2fc3ce4f0c2291d402cb470346d5561373fb51e7
commit 8cad1ded0b64a35a471e078c6f15654089f6a319
Author: Kohei Yoshida <kohei.yoshida at collabora.com>
Date: Fri Oct 4 15:21:36 2013 -0400
Some attempt to store string ID's into query items.
Change-Id: I8db7cd327728be0974405eabb0fd58156ba231d6
commit e12b2291498d9ca2b36c9d02762d69a780ca749f
Author: Kohei Yoshida <kohei.yoshida at collabora.com>
Date: Fri Oct 4 13:18:12 2013 -0400
ScInterpreter::GetString() now returns a ref to OUString.
Making adjustments in some call sites.
Conflicts:
sc/source/core/tool/interpr2.cxx
Change-Id: I85aca2eeb2aece46be52d90a611a64d85792a05f
commit 01580e2fd13b09bfe12a4c8f8402c674809c652e
Author: Kohei Yoshida <kohei.yoshida at collabora.com>
Date: Thu Oct 3 15:53:18 2013 -0400
Reduce the amount of indentation by early exit.
Change-Id: Ibcf64f57d84dd90a41421522c8082319f1d5796a
commit 893c6e8d0aaac82c32e89f43b1f31a134bded0f4
Author: Kohei Yoshida <kohei.yoshida at collabora.com>
Date: Thu Oct 3 14:58:06 2013 -0400
Test comparison between simple and rich-text string values.
Conflicts:
sc/qa/unit/ucalc.cxx
Change-Id: Icdb9a81b1be80b058b71c23b3fcb58a5e8970e21
commit feee800bb4ab65915e895c320e80a711586014ba
Author: Kohei Yoshida <kohei.yoshida at collabora.com>
Date: Thu Oct 3 14:24:28 2013 -0400
Add methods to turn cell strings into numeric IDs for comparison.
Both in case sensitive and case insensitive comparisons.
Change-Id: I356a655273f0f37157810c86e1cf3f87ea2afa09
commit 9806115bbc657df52129723f53d77c970f896a6d
Author: Kohei Yoshida <kohei.yoshida at collabora.com>
Date: Thu Oct 3 12:16:22 2013 -0400
Add methods to extract string IDs from edit text object.
Note that a single edit text object may have multiple string ID's in case
it consists of multiple paragraphs.
Change-Id: Ie90541de38a639c30a010817dada389e9445d08c
commit 2b44b5d6b01b2045726407f4fad2ad2b61fb17ed
Author: Kohei Yoshida <kohei.yoshida at collabora.com>
Date: Thu Oct 3 11:34:24 2013 -0400
Let's just use sal_uIntPtr straight.
So that the user of this class won't have to include the header just
to get the string ID type.
Change-Id: I0ccbc18fe02644f69701f57b0b1b9c30fd141d83
commit d3c7bc216f9be4deeb71732703569ad7492e147d
Author: Kohei Yoshida <kohei.yoshida at collabora.com>
Date: Thu Oct 3 10:55:48 2013 -0400
Normalize all string objects that are cell contents before they get stored.
Hopefully I've covered all entry points. There may be more lurking in some
dark corneres...
Change-Id: I62e655cc579aad08fa64b5d58e739c55425cd216
commit 6aea653e0df818bf9e12ee09ce8a9767576b6cb1
Author: Kohei Yoshida <kohei.yoshida at collabora.com>
Date: Wed Oct 2 21:46:40 2013 -0400
Add string pool to document.
Change-Id: I7430af7486a2f7a150ed17a0c345aeeb987ec993
commit eab8ad38da85fb5a7218da0d4fd0d0740ac1382b
Author: Kohei Yoshida <kohei.yoshida at collabora.com>
Date: Wed Oct 2 19:11:28 2013 -0400
A little more test on shared string pool's life cycle management.
Change-Id: Ic676dd875c27ce60a0707903d7f22207764829e0
commit 133114754a041d76454ccd7bbef8dae8056b954d
Author: Kohei Yoshida <kohei.yoshida at collabora.com>
Date: Wed Oct 2 18:54:28 2013 -0400
No need to intern strings here; all OUString's are ref-counted.
Calling intern() simply moves it to a global hash storage. Now
the test passes.
Change-Id: I0a93420abce1c3adaaa61d469dff5f359dd5ada4
commit e377849d25b90afa12bacf6f59b9c5927be55ea7
Author: Kohei Yoshida <kohei.yoshida at collabora.com>
Date: Wed Oct 2 16:35:41 2013 -0400
Add purge() method to purge unreferenced strings from the pool.
But this code needs more work.
Change-Id: I538eebf5eb1738a2cfeebc22052b3d5db6001b6b
commit c9726ccafb1d2f5752daf382474dbf77aaf2b538
Author: Kohei Yoshida <kohei.yoshida at collabora.com>
Date: Wed Oct 2 14:06:13 2013 -0400
The map actualy needs to store OUString to have it ref-counted automatically.
Change-Id: Iff6fcf3aba73f2d06ac0c885b39e69ac0febc49f
commit 706b088a2c8d1cd410d2f5f9c6b6e94c6b0a42ae
Author: Kohei Yoshida <kohei.yoshida at collabora.com>
Date: Wed Oct 2 13:06:20 2013 -0400
Correct way to get case-insensitive string identifiers.
Change-Id: Ia343165941231fab34c4904b7a2fa10b07fa32bb
commit 2e402a3cc3aad49d83c275ff96dd8a3df3d2da4d
Author: Kohei Yoshida <kohei.yoshida at collabora.com>
Date: Wed Oct 2 12:19:19 2013 -0400
Let's not expose the internal pointer. Define different ID type.
To prevent the string ID's from being used to instantiate string objects,
which can mess up shared string object's life cycles.
Change-Id: Ibcd9a4fa9f591d5c27a9e1b50bc9f83ae230e86a
commit bbf009d2e4d73a4587931fc0411692fcc9cb4f19
Author: Kohei Yoshida <kohei.yoshida at collabora.com>
Date: Wed Oct 2 11:29:42 2013 -0400
Write some rudimentary tests for the new shared string pool class.
Change-Id: Ie66de46d69f664839aa0a2d056cd3b8df4d4989b
commit b0248b34e6786979ac407acf392c6f33b9c533cb
Author: Kohei Yoshida <kohei.yoshida at collabora.com>
Date: Wed Oct 2 10:47:28 2013 -0400
Establish mapping between original strings and upper strings.
This will be used to retrieve case insensitive string identifiers
later.
Change-Id: Ia34f57d0e8d0cb6bd4630f8d110853ed049770b5
commit 666aa2018f60ffa48c031b662f61368d724a21d2
Author: Kohei Yoshida <kohei.yoshida at collabora.com>
Date: Tue Oct 1 21:51:50 2013 -0400
Add method to normalize strings in EditTextObject.
Change-Id: I1adb57279db0afeb8387599ec11984380e5a2e4a
commit b44eff489536c710dd0dd1389e56012bd29cd832
Author: Kohei Yoshida <kohei.yoshida at collabora.com>
Date: Tue Oct 1 20:57:56 2013 -0400
Move this string pool code to svl.
Change-Id: I1379fbc377607be8831133d64db2e14f8c75bff8
More information about the Libreoffice-commits
mailing list