[Libreoffice-commits] core.git: Branch 'libreoffice-4-1' - sc/source

[Eike Rathke]

 sc/source/ui/docshell/tablink.cxx |   11 +++++------
 1 file changed, 5 insertions(+), 6 deletions(-)

New commits:
commit 856e8cdf9cb67acfc858c9ca55bda5bd24ee7b57
Author: Eike Rathke <erack at redhat.com>
Date:   Thu Oct 10 18:02:25 2013 +0200

    fixed another "Out of bounds substring access"
    
    Introduced with 3c2a26c84e70fd996855181d319970e2230b2459
    Didn't have consequences here because the result was used to check for a
    "startsWith" condition which it wouldn't had matched anyway. However,
    use the real startsWith() now.
    
    (cherry picked from commit b1caf176a44b6979d2e0ea47f495a3dacf86e197)
    
    With f81ed484ffd443e2593627f3d8d3133161817af2 in 4-1 we should have this
    as well.
    
    Change-Id: Ia1d558fc106d9a2010ad41c30f7eb2a2a480c59b
    Reviewed-on: https://gerrit.libreoffice.org/6218
    Reviewed-by: Markus Mohrhard <markus.mohrhard at googlemail.com>
    Tested-by: Markus Mohrhard <markus.mohrhard at googlemail.com>

diff --git a/sc/source/ui/docshell/tablink.cxx b/sc/source/ui/docshell/tablink.cxx
index 14ab878..ba1ed72 100644
--- a/sc/source/ui/docshell/tablink.cxx
+++ b/sc/source/ui/docshell/tablink.cxx
@@ -512,12 +512,11 @@ bool ScDocumentLoader::GetFilterName(
 
 void ScDocumentLoader::RemoveAppPrefix( OUString& rFilterName )
 {
-    OUStringBuffer aAppPrefix;
-    aAppPrefix.appendAscii(STRING_SCAPP);
-    aAppPrefix.appendAscii(": ");
-    sal_Int32 nPreLen = aAppPrefix.getLength();
-    if (rFilterName.copy(0, nPreLen).equals(aAppPrefix.makeStringAndClear()))
-        rFilterName = rFilterName.copy(nPreLen);
+    OUStringBuffer aBuf;
+    aBuf.appendAscii( STRING_SCAPP).appendAscii( ": ");
+    OUString aAppPrefix( aBuf.makeStringAndClear());
+    if (rFilterName.startsWith( aAppPrefix))
+        rFilterName = rFilterName.copy( aAppPrefix.getLength());
 }
 
 ScDocumentLoader::ScDocumentLoader( const OUString& rFileName,