[Libreoffice-commits] core.git: 2 commits - external/jfreereport nss/ExternalProject_nss.mk RepositoryExternal.mk solenv/gbuild swext/Extension_wiki-publisher.mk

Michael Stahl mstahl at redhat.com
Sat Oct 26 12:42:46 PDT 2013 

 RepositoryExternal.mk                                           |    2 -
 external/jfreereport/ExternalProject_jfreereport_flow_engine.mk |    2 -
 external/jfreereport/ExternalProject_jfreereport_liblayout.mk   |    2 -
 nss/ExternalProject_nss.mk                                      |    2 +
 solenv/gbuild/Extension.mk                                      |   12 ----------
 swext/Extension_wiki-publisher.mk                               |    9 +++----
 6 files changed, 9 insertions(+), 20 deletions(-)

New commits:
commit 1aae6f6087214f143886dd4c18d226fb1657b5c3
Author: Michael Stahl <mstahl at redhat.com>
Date:   Sat Oct 26 21:35:32 2013 +0200

    nss: fix build breakage of postgresql
    
    Somehow postgresql needs to link both openssl and NSS (yay) ... and it
    turns out that NSS builds a "libssl.a" on MacOSX and Linux, and of
    course OpenSSL does too... so avoid that by removing *.a in NSS tree,
    which are not needed anyway (some of these are named the same as the
    corresponding .so/.dylib to...).
    
    Change-Id: I5c9718e655d350c2e7d0ae05596f8e3130e9bfe1

diff --git a/nss/ExternalProject_nss.mk b/nss/ExternalProject_nss.mk
index 89f4e74..13a1047 100644
--- a/nss/ExternalProject_nss.mk
+++ b/nss/ExternalProject_nss.mk
@@ -51,6 +51,7 @@ $(call gb_ExternalProject_get_state_target,nss,build): $(call gb_ExternalProject
 			IMPORT_LIB_SUFFIX=dll.a \
 			NSPR_CONFIGURE_OPTS="--build=$(BUILD_PLATFORM) --host=$(HOST_PLATFORM) --enable-shared --disable-static" \
 			NSINSTALL="$(call gb_ExternalExecutable_get_command,python) $(SRCDIR)/nss/nsinstall.py" \
+		&& rm -f $(call gb_UnpackedTarball_get_dir,nss)/mozilla/dist/out/lib/*.a \
 	,mozilla/security/nss)
 
 endif
@@ -65,6 +66,7 @@ $(call gb_ExternalProject_get_state_target,nss,build): $(call gb_ExternalProject
 		NSINSTALL="$(call gb_ExternalExecutable_get_command,python) $(SRCDIR)/nss/nsinstall.py") \
 		NSDISTMODE=copy \
 		$(MAKE) -j1 AR=$(AR) RANLIB=$(RANLIB) NMEDIT=$(NM)edit nss_build_all \
+		&& rm -f $(call gb_UnpackedTarball_get_dir,nss)/mozilla/dist/out/lib/*.a \
 		$(if $(filter MACOSX,$(OS)),&& $(PERL) \
 			$(SOLARENV)/bin/macosx-change-install-names.pl shl OOO \
 			$(gb_Package_SOURCEDIR_nss)/mozilla/dist/out/lib/libfreebl3.dylib \
commit a60427ef5a9861123ffbb78fca769d3b56473af4
Author: Michael Stahl <mstahl at redhat.com>
Date:   Sat Oct 26 20:17:52 2013 +0200

    swext: fix wiki-publisher / apache-commons build
    
    gb_Extension_use_package is inherently broken because it creates cyclic
    dependencies with gb_Extension_add_file.  Fortunately it's not necessary
    because the added file is a target by virtue of being in the Package.
    
    There is another cyclic dependency that can be avoided by not using the
    Package in gb_ExternalProject__use_commons-logging.
    
    Change-Id: Id4ddd4f78d819e47882387533a2d64693b2879ea

diff --git a/RepositoryExternal.mk b/RepositoryExternal.mk
index ccb0fdc..75d2b52 100644
--- a/RepositoryExternal.mk
+++ b/RepositoryExternal.mk
@@ -2860,7 +2860,7 @@ $(call gb_Jar_use_external_project,$(1),apache_commons_logging)
 $(call gb_Jar_use_jar,$(1),commons-logging-1.1.1)
 endef
 define gb_ExternalProject__use_commons-logging
-$(call gb_ExternalProject_use_package,$(1),apache_commons_logging)
+$(call gb_ExternalProject_use_external_project,$(1),apache_commons_logging)
 endef
 
 endif # SYSTEM_APACHE_COMMONS
diff --git a/external/jfreereport/ExternalProject_jfreereport_flow_engine.mk b/external/jfreereport/ExternalProject_jfreereport_flow_engine.mk
index 5e03d95..02ffbad 100644
--- a/external/jfreereport/ExternalProject_jfreereport_flow_engine.mk
+++ b/external/jfreereport/ExternalProject_jfreereport_flow_engine.mk
@@ -25,7 +25,7 @@ $(call gb_ExternalProject_get_state_target,jfreereport_flow_engine,build) :
 			-Dbuild.label="build-$(LIBO_VERSION_MAJOR).$(LIBO_VERSION_MINOR).$(LIBO_VERSION_MICRO).$(LIBO_VERSION_PATCH)" \
 			$(if $(filter YES,$(SYSTEM_APACHE_COMMONS)),\
 				-Dcommons-logging.jar=$(COMMONS_LOGGING_JAR), \
-				-Dcommons-logging.jar=$(INSTROOT)/$(LIBO_SHARE_JAVA_FOLDER)/commons-logging-1.1.1.jar) \
+				-Dcommons-logging.jar="$(call gb_UnpackedTarball_get_dir,apache_commons_logging)/target/commons-logging-1.1.1-SNAPSHOT.jar)" \
 			-Dlibbase.jar=$(call gb_UnpackedTarball_get_dir,jfreereport_libbase)/dist/libbase-$(LIBBASE_VERSION).jar \
 			-Dlibformula.jar=$(call gb_UnpackedTarball_get_dir,jfreereport_libformula)/dist/libformula-$(LIBFORMULA_VERSION).jar \
 			-Dliblayout.jar=$(call gb_UnpackedTarball_get_dir,jfreereport_liblayout)/build/lib/liblayout.jar \
diff --git a/external/jfreereport/ExternalProject_jfreereport_liblayout.mk b/external/jfreereport/ExternalProject_jfreereport_liblayout.mk
index 3a9c273..3a923b3 100644
--- a/external/jfreereport/ExternalProject_jfreereport_liblayout.mk
+++ b/external/jfreereport/ExternalProject_jfreereport_liblayout.mk
@@ -37,7 +37,7 @@ $(call gb_ExternalProject_get_state_target,jfreereport_liblayout,build) :
 			-Dbuild.label="build-$(LIBO_VERSION_MAJOR).$(LIBO_VERSION_MINOR).$(LIBO_VERSION_MICRO).$(LIBO_VERSION_PATCH)" \
 			$(if $(filter YES,$(SYSTEM_APACHE_COMMONS)),\
 				-Dcommons-logging.jar=$(COMMONS_LOGGING_JAR), \
-				-Dcommons-logging.jar=$(INSTROOT)/$(LIBO_SHARE_JAVA_FOLDER)/commons-logging-1.1.1.jar) \
+				-Dcommons-logging.jar="$(call gb_UnpackedTarball_get_dir,apache_commons_logging)/target/commons-logging-1.1.1-SNAPSHOT.jar)" \
 			-Dflute.jar=$(call gb_UnpackedTarball_get_dir,jfreereport_flute)/dist/flute-$(FLUTE_VERSION).jar \
 			-Dlibbase.jar=$(call gb_UnpackedTarball_get_dir,jfreereport_libbase)/dist/libbase-$(LIBBASE_VERSION).jar \
 			-Dlibformula.jar=$(call gb_UnpackedTarball_get_dir,jfreereport_libformula)/dist/libformula-$(LIBFORMULA_VERSION).jar \
diff --git a/solenv/gbuild/Extension.mk b/solenv/gbuild/Extension.mk
index d98259e..b695443 100644
--- a/solenv/gbuild/Extension.mk
+++ b/solenv/gbuild/Extension.mk
@@ -287,18 +287,6 @@ $(call gb_Extension__get_preparation_target,$(1)) \
 
 endef
 
-define gb_Extension_use_package
-$(call gb_Extension__get_preparation_target,$(1)) \
-	:| $(call gb_Package_get_target,$(2))
-
-endef
-
-define gb_Extension_use_packages
-$(foreach package,$(2),$(call gb_Extension_use_package,$(1),$(package)))
-
-endef
-
-
 define gb_Extension__localize_properties_onelang
 $(call gb_Extension_get_target,$(1)) : FILES += $(2)
 ifneq ($(filter-out en-US,$(4)),)
diff --git a/swext/Extension_wiki-publisher.mk b/swext/Extension_wiki-publisher.mk
index 5e04323..d43eb00 100644
--- a/swext/Extension_wiki-publisher.mk
+++ b/swext/Extension_wiki-publisher.mk
@@ -13,16 +13,15 @@ $(eval $(call gb_Extension_Extension,wiki-publisher,swext/mediawiki/src))
 
 $(eval $(call gb_Extension_use_unpacked,wiki-publisher,xsltml))
 
-$(eval $(call gb_Extension_use_package,wiki-publisher,apache_commons_logging))
+$(eval $(call gb_Extension_use_default_description,wiki-publisher))
+$(eval $(call gb_Extension_use_default_license,wiki-publisher))
 
+ifneq ($(SYSTEM_APACHE_COMMONS),YES)
+$(eval $(call gb_Extension_use_external_project,wiki-publisher,apache_commons_logging))
 $(eval $(call gb_Extension_use_external_project,wiki-publisher,apache_commons_codec))
 $(eval $(call gb_Extension_use_external_project,wiki-publisher,apache_commons_httpclient))
 $(eval $(call gb_Extension_use_external_project,wiki-publisher,apache_commons_lang))
 
-$(eval $(call gb_Extension_use_default_description,wiki-publisher))
-$(eval $(call gb_Extension_use_default_license,wiki-publisher))
-
-ifneq ($(SYSTEM_APACHE_COMMONS),YES)
 $(eval $(call gb_Extension_add_file,wiki-publisher,commons-codec-1.6.jar,$(call gb_UnpackedTarball_get_dir,apache_commons_codec)/dist/commons-codec-1.6-SNAPSHOT.jar))
 $(eval $(call gb_Extension_add_file,wiki-publisher,commons-httpclient-3.1.jar,$(call gb_UnpackedTarball_get_dir,apache_commons_httpclient)/dist/commons-httpclient.jar))
 $(eval $(call gb_Extension_add_file,wiki-publisher,commons-lang-2.4.jar,$(call gb_UnpackedTarball_get_dir,apache_commons_lang)/dist/commons-lang-2.4.jar))

More information about the Libreoffice-commits mailing list