[Libreoffice-commits] core.git: sfx2/source

Stephan Bergmann sbergman at redhat.com
Tue Sep 3 05:21:29 PDT 2013


 sfx2/source/control/thumbnailview.cxx |   17 ++++++++---------
 1 file changed, 8 insertions(+), 9 deletions(-)

New commits:
commit 9eefaa56e4bf7d17956e1358e227573dad6a931c
Author: Stephan Bergmann <sbergman at redhat.com>
Date:   Tue Sep 3 14:21:03 2013 +0200

    warning C4701: potentially uninitialized local variable 'pItem' used
    
    Change-Id: I04cc1589139841f50fcaa5ef9e1deaf53fb00096

diff --git a/sfx2/source/control/thumbnailview.cxx b/sfx2/source/control/thumbnailview.cxx
index 18d14a1..6089507 100644
--- a/sfx2/source/control/thumbnailview.cxx
+++ b/sfx2/source/control/thumbnailview.cxx
@@ -89,22 +89,21 @@ void ThumbnailView::MouseMove( const MouseEvent& rMEvt )
         return;
 
     (void) rMEvt; // unused parameter
-    ThumbnailViewItem *pItem;
     size_t      nItemCount = mFilteredItemList.size();
-    bool        bFound = false;
     Point       aPoint = GetPointerState().maPos;
+    OUString    aHelp;
 
-    for ( size_t i = 0; i < nItemCount && !bFound; i++ )
+    for ( size_t i = 0; i < nItemCount; i++ )
     {
-        pItem = mFilteredItemList[i];
+        ThumbnailViewItem *pItem = mFilteredItemList[i];
         if ( pItem->mbVisible && pItem->getDrawArea().IsInside(aPoint) )
-            bFound = true;
+        {
+            aHelp = pItem->maTitle;
+            break;
+        }
     }
 
-    if ( bFound )
-        SetQuickHelpText(pItem->maTitle);
-    else
-        SetQuickHelpText("");
+    SetQuickHelpText(aHelp);
 }
 
 void ThumbnailView::AppendItem(ThumbnailViewItem *pItem)


More information about the Libreoffice-commits mailing list