[Libreoffice-commits] core.git: solenv/gbuild

[Tor Lillqvist]

 solenv/gbuild/platform/com_MSC_defs.mk |    9 +++++++++
 1 file changed, 9 insertions(+)

New commits:
commit 732e8c62ace83522ef0c48c99a26f0bd54cd9d22
Author: Tor Lillqvist <tml at collabora.com>
Date:   Mon Sep 9 21:12:31 2013 +0300

    Add comment about our choice of gb_COMPILEROPTFLAGS
    
    Change-Id: Iaeb9e1637ab4b85735a44f7cd5428e0e0c47c91d

diff --git a/solenv/gbuild/platform/com_MSC_defs.mk b/solenv/gbuild/platform/com_MSC_defs.mk
index e6a1155..374ded0 100644
--- a/solenv/gbuild/platform/com_MSC_defs.mk
+++ b/solenv/gbuild/platform/com_MSC_defs.mk
@@ -275,6 +275,15 @@ gb_CFLAGS+=$(gb_DEBUG_CFLAGS)
 gb_CXXFLAGS+=$(gb_DEBUG_CFLAGS)
 endif
 
+# The optimisation options here might seem like micro-management (see
+# http://www.ffuts.org/blog/dont-spend-time-micromanaging-optimization-options-in-visual-c/
+# ), and the exact rationale for this selection of options for
+# gb_COMPILEROPTFLAGS is probably lost in history. We used -Ob1 -Oxs
+# -Oy- already in OOo 3.2 at least.
+
+# Anyway, changing it to just -O2 broke unit tests. So there must be
+# some reason for this particular choice. And if you want to change it
+# to something simpler, please run a full make check;)
 gb_COMPILEROPTFLAGS := -Ob1 -Oxs -Oy-
 gb_COMPILERNOOPTFLAGS := -Od