[Libreoffice-commits] core.git: 31 commits - basegfx/source canvas/source framework/source i18npool/source include/framework include/svl include/tools include/vcl include/xmloff rsc/source sd/source sfx2/source svtools/source svx/source sw/source tools/source vcl/generic vcl/inc
Caolán McNamara
caolanm at redhat.com
Tue Apr 1 02:38:55 PDT 2014
basegfx/source/polygon/b2dpolypolygontools.cxx | 2
canvas/source/cairo/cairo_devicehelper.hxx | 2
framework/source/recording/dispatchrecorder.cxx | 3 -
framework/source/uielement/menubarmerger.cxx | 1
framework/source/uielement/uicommanddescription.cxx | 10 ++-
i18npool/source/indexentry/indexentrysupplier_default.cxx | 1
include/framework/menuconfiguration.hxx | 16 ++++--
include/svl/filerec.hxx | 10 +++
include/tools/stream.hxx | 1
include/vcl/animate.hxx | 8 ++-
include/vcl/salnativewidgets.hxx | 12 +++-
include/xmloff/numehelp.hxx | 24 ++++++---
rsc/source/parser/rscyacc.y | 1
sd/source/ui/unoidl/unosrch.cxx | 3 -
sfx2/source/dialog/dinfdlg.cxx | 4 +
svtools/source/control/ctrltool.cxx | 3 -
svx/source/dialog/_contdlg.cxx | 2
svx/source/dialog/dlgctrl.cxx | 4 +
svx/source/dialog/fontlb.cxx | 1
svx/source/xoutdev/_xpoly.cxx | 36 +++++++-------
sw/source/core/access/accfrmobj.cxx | 3 +
sw/source/core/attr/calbck.cxx | 5 +
sw/source/core/inc/blink.hxx | 19 +++++--
sw/source/core/text/atrstck.cxx | 6 +-
sw/source/core/text/inftxt.cxx | 21 ++++----
sw/source/core/text/inftxt.hxx | 2
sw/source/core/text/porfld.cxx | 4 +
sw/source/core/unocore/unoframe.cxx | 12 ++--
tools/source/zcodec/zcodec.cxx | 36 ++++++++++----
vcl/generic/print/prtsetup.cxx | 4 -
vcl/inc/salsession.hxx | 6 +-
31 files changed, 177 insertions(+), 85 deletions(-)
New commits:
commit 8fdd994aa793664652da2794b46d3a63a237b189
Author: Caolán McNamara <caolanm at redhat.com>
Date: Mon Mar 31 21:35:45 2014 +0100
coverity#984038 Uninitialized scalar variable
Change-Id: Ibab4b201d9412e0d32630957d4c85762c28974bc
diff --git a/basegfx/source/polygon/b2dpolypolygontools.cxx b/basegfx/source/polygon/b2dpolypolygontools.cxx
index d7b2b5f..35bc6ed 100644
--- a/basegfx/source/polygon/b2dpolypolygontools.cxx
+++ b/basegfx/source/polygon/b2dpolypolygontools.cxx
@@ -355,7 +355,7 @@ namespace basegfx
{
const B2DPolygon aCandidate(rCandidate.getB2DPolygon(a));
sal_uInt32 nNewEdgeIndex;
- double fNewCut;
+ double fNewCut(0.0);
const double fNewDistance(getSmallestDistancePointToPolygon(aCandidate, rTestPoint, nNewEdgeIndex, fNewCut));
if(DBL_MAX == fRetval || fNewDistance < fRetval)
commit baa6b723d1c03348973bd80da529b3c4b8ab9a8e
Author: Caolán McNamara <caolanm at redhat.com>
Date: Mon Mar 31 21:32:36 2014 +0100
coverity#707522 Uninitialized scalar variable
Change-Id: Ib655e3763c1d8deb1c10a10616390d5fdefe2291
diff --git a/rsc/source/parser/rscyacc.y b/rsc/source/parser/rscyacc.y
index 96d8e8e..7325b6d 100644
--- a/rsc/source/parser/rscyacc.y
+++ b/rsc/source/parser/rscyacc.y
@@ -360,6 +360,7 @@ resource_definitions
RscExpType aExpType;
sal_Int32 lValue;
+ aExpType.cUnused = false;
aExpType.cType = RSCEXP_NOTHING;
pExp = new RscExpression( aExpType, '+', $2 );
if( !pExp->Evaluate( &lValue ) )
commit 9dc923b146f9e1c44282271eeb33e230b7927562
Author: Caolán McNamara <caolanm at redhat.com>
Date: Mon Mar 31 21:30:17 2014 +0100
coverity#738544 Uninitialized scalar variable
Change-Id: Idbf32e20ce81e6b726f32183c6f5e1bf0657b5ba
diff --git a/framework/source/uielement/menubarmerger.cxx b/framework/source/uielement/menubarmerger.cxx
index f74a722..5083eb7 100644
--- a/framework/source/uielement/menubarmerger.cxx
+++ b/framework/source/uielement/menubarmerger.cxx
@@ -89,6 +89,7 @@ ReferencePathInfo MenuBarMerger::FindReferencePath(
if ( !nCount )
{
aResult.pPopupMenu = NULL;
+ aResult.nPos = 0;
aResult.eResult = RP_MENUITEM_NOT_FOUND;
return aResult;
}
commit 79bd29fe6d2a383e80d10a9fee1765193eaa0686
Author: Caolán McNamara <caolanm at redhat.com>
Date: Mon Mar 31 21:23:53 2014 +0100
coverity#708217 Uninitialized scalar field
Change-Id: I06129c77b87890d45655da9e22a3b7716bc64d0a
diff --git a/include/xmloff/numehelp.hxx b/include/xmloff/numehelp.hxx
index a90a2b7..a2a7d75 100644
--- a/include/xmloff/numehelp.hxx
+++ b/include/xmloff/numehelp.hxx
@@ -34,13 +34,23 @@ class SvXMLExport;
struct XMLNumberFormat
{
OUString sCurrency;
- sal_Int32 nNumberFormat;
- sal_Int16 nType;
- bool bIsStandard : 1;
- XMLNumberFormat() : nNumberFormat(0), nType(0) {}
- XMLNumberFormat(const OUString& sTempCurrency, sal_Int32 nTempFormat,
- sal_Int16 nTempType) : sCurrency(sTempCurrency), nNumberFormat(nTempFormat),
- nType(nTempType) {}
+ sal_Int32 nNumberFormat;
+ sal_Int16 nType;
+ bool bIsStandard : 1;
+ XMLNumberFormat()
+ : nNumberFormat(0)
+ , nType(0)
+ , bIsStandard(false)
+ {
+ }
+
+ XMLNumberFormat(const OUString& sTempCurrency, sal_Int32 nTempFormat, sal_Int16 nTempType)
+ : sCurrency(sTempCurrency)
+ , nNumberFormat(nTempFormat)
+ , nType(nTempType)
+ , bIsStandard(false)
+ {
+ }
};
struct LessNumberFormat
commit 504cdfeb0a5b432f0f47ca9fa98348abc5b316c0
Author: Caolán McNamara <caolanm at redhat.com>
Date: Mon Mar 31 21:20:42 2014 +0100
coverity#708214 Uninitialized scalar field
Change-Id: I2a2c3ee32df6b88464be5df1faad58e9819b2281
diff --git a/include/vcl/salnativewidgets.hxx b/include/vcl/salnativewidgets.hxx
index eb2d723..6d67efc 100644
--- a/include/vcl/salnativewidgets.hxx
+++ b/include/vcl/salnativewidgets.hxx
@@ -395,11 +395,15 @@ class VCL_DLLPUBLIC SpinbuttonValue : public ImplControlValue
int mnUpperPart;
int mnLowerPart;
- inline SpinbuttonValue()
- : ImplControlValue( CTRL_SPINBUTTONS, BUTTONVALUE_DONTKNOW, 0 )
+ SpinbuttonValue()
+ : ImplControlValue( CTRL_SPINBUTTONS, BUTTONVALUE_DONTKNOW, 0 )
+ , mnUpperState(0)
+ , mnLowerState(0)
+ , mnUpperPart(0)
+ , mnLowerPart(0)
{
- mnUpperState = mnLowerState = 0;
- };
+ }
+
virtual ~SpinbuttonValue();
virtual SpinbuttonValue* clone() const SAL_OVERRIDE;
};
commit c71de3a440b6fe44776691553f2726752f184426
Author: Caolán McNamara <caolanm at redhat.com>
Date: Mon Mar 31 21:19:36 2014 +0100
coverity#708211 Uninitialized scalar field
Change-Id: Id1a96b9f003effe0232a875bfbd3149076096c55
diff --git a/include/vcl/animate.hxx b/include/vcl/animate.hxx
index a8bcfec..f75caf6 100644
--- a/include/vcl/animate.hxx
+++ b/include/vcl/animate.hxx
@@ -52,7 +52,13 @@ struct VCL_DLLPUBLIC AnimationBitmap
Disposal eDisposal;
bool bUserInput;
- AnimationBitmap() {}
+ AnimationBitmap()
+ : nWait(0)
+ , eDisposal(DISPOSE_NOT)
+ , bUserInput(false)
+ {
+ }
+
AnimationBitmap(
const BitmapEx& rBmpEx,
const Point& rPosPix,
commit f6953937df5d92d70c59ff9f0b91042285016b23
Author: Caolán McNamara <caolanm at redhat.com>
Date: Mon Mar 31 21:17:33 2014 +0100
coverity#707923 Uninitialized scalar field
Change-Id: Iab2d5829b28587640058d484ef806d9e9e8c1f96
diff --git a/i18npool/source/indexentry/indexentrysupplier_default.cxx b/i18npool/source/indexentry/indexentrysupplier_default.cxx
index 9956797..567da90 100644
--- a/i18npool/source/indexentry/indexentrysupplier_default.cxx
+++ b/i18npool/source/indexentry/indexentrysupplier_default.cxx
@@ -111,6 +111,7 @@ void IndexTable::init(sal_Unicode start_, sal_Unicode end_, IndexKey *keys, sal_
Index::Index(const com::sun::star::uno::Reference < com::sun::star::uno::XComponentContext >& rxContext)
: table_count(0)
, key_count(0)
+ , mkey_count(0)
{
collator = new CollatorImpl(rxContext);
}
commit 2d737cc401a679f6850679b2c8469ba471d01fb1
Author: Caolán McNamara <caolanm at redhat.com>
Date: Mon Mar 31 21:16:07 2014 +0100
coverity#707886 Uninitialized scalar field
Change-Id: Iefcdcf992f5e25643030ab94e64bd06f9fe7c7e7
diff --git a/framework/source/uielement/uicommanddescription.cxx b/framework/source/uielement/uicommanddescription.cxx
index 8d86857..de2db99 100644
--- a/framework/source/uielement/uicommanddescription.cxx
+++ b/framework/source/uielement/uicommanddescription.cxx
@@ -602,10 +602,11 @@ void SAL_CALL ConfigurationAccess_UICommand::disposing( const EventObject& aEven
}
}
-UICommandDescription::UICommandDescription( const Reference< XComponentContext >& rxContext ) :
- UICommandDescription_BASE(m_aMutex),
- m_aPrivateResourceURL( PRIVATE_RESOURCE_URL ),
- m_xContext( rxContext )
+UICommandDescription::UICommandDescription(const Reference< XComponentContext >& rxContext)
+ : UICommandDescription_BASE(m_aMutex)
+ , m_bConfigRead(false)
+ , m_aPrivateResourceURL(PRIVATE_RESOURCE_URL)
+ , m_xContext(rxContext)
{
Reference< XNameAccess > xEmpty;
OUString aGenericUICommand( "GenericCommands" );
@@ -618,6 +619,7 @@ UICommandDescription::UICommandDescription( const Reference< XComponentContext >
if ( pIter != m_aUICommandsHashMap.end() )
pIter->second = m_xGenericUICommands;
}
+
UICommandDescription::UICommandDescription(const Reference< XComponentContext >& rxContext, bool)
: UICommandDescription_BASE(m_aMutex)
, m_bConfigRead(false)
commit 3156772937c54463741e08804bab47814c423459
Author: Caolán McNamara <caolanm at redhat.com>
Date: Mon Mar 31 21:14:29 2014 +0100
coverity#707881 Uninitialized scalar field
Change-Id: I709bb47bc2cf083805cd8b058b94a763af2ab7ee
diff --git a/framework/source/recording/dispatchrecorder.cxx b/framework/source/recording/dispatchrecorder.cxx
index 1017885..5e5fd49 100644
--- a/framework/source/recording/dispatchrecorder.cxx
+++ b/framework/source/recording/dispatchrecorder.cxx
@@ -100,7 +100,8 @@ Sequence< Any > make_seq_out_of_struct(
DispatchRecorder::DispatchRecorder( const css::uno::Reference< css::uno::XComponentContext >& xContext )
- : m_xConverter( css::script::Converter::create(xContext) )
+ : m_nRecordingID(0)
+ , m_xConverter(css::script::Converter::create(xContext))
{
}
commit 4d8766a29ba0a8e4ae4a80ce4a1be6e72032d387
Author: Caolán McNamara <caolanm at redhat.com>
Date: Mon Mar 31 21:12:55 2014 +0100
coverity#707869 Uninitialized scalar field
Change-Id: Ifd61e6d2af525539f759dbdabc190a7b14fc19fd
diff --git a/include/framework/menuconfiguration.hxx b/include/framework/menuconfiguration.hxx
index a6bc26f..c0c4ee4 100644
--- a/include/framework/menuconfiguration.hxx
+++ b/include/framework/menuconfiguration.hxx
@@ -61,14 +61,22 @@ class FWE_DLLPUBLIC MenuConfiguration
public:
struct Attributes
{
- Attributes() {}
- Attributes( const OUString& aFrame, const OUString& aImageIdStr ) :
- aTargetFrame( aFrame ), aImageId( aImageIdStr ) {}
+ Attributes()
+ : nStyle(0)
+ {
+ }
+
+ Attributes( const OUString& aFrame, const OUString& aImageIdStr )
+ : aTargetFrame(aFrame)
+ , aImageId(aImageIdStr)
+ , nStyle(0)
+ {
+ }
OUString aTargetFrame;
OUString aImageId;
::com::sun::star::uno::WeakReference< ::com::sun::star::frame::XDispatchProvider > xDispatchProvider;
- sal_Int16 nStyle;
+ sal_Int16 nStyle;
};
MenuConfiguration(
commit ce45e3134ce010133f0be1f9fa296d12e92e65a3
Author: Caolán McNamara <caolanm at redhat.com>
Date: Mon Mar 31 21:10:46 2014 +0100
coverity#984151 Uninitialized pointer field
Change-Id: Ife2e699365b28f468c9cdb5e8ad49cee36955b34
diff --git a/svx/source/dialog/fontlb.cxx b/svx/source/dialog/fontlb.cxx
index d60b906..0222e9a 100644
--- a/svx/source/dialog/fontlb.cxx
+++ b/svx/source/dialog/fontlb.cxx
@@ -86,6 +86,7 @@ void SvLBoxFontString::InitViewData( SvTreeListBox* pView, SvTreeListEntry* pEnt
SvxFontListBox::SvxFontListBox(Window* pParent, WinBits nStyle)
: SvTabListBox(pParent, nStyle)
, maStdFont(GetFont())
+ , mpEntryColor(NULL)
, mbUseFont(false)
{
maStdFont.SetTransparent(true);
commit 2591ed293eeb24b6726f5b54bab143e239780588
Author: Caolán McNamara <caolanm at redhat.com>
Date: Mon Mar 31 21:09:42 2014 +0100
coverity#984148 Uninitialized pointer field
Change-Id: I17a4a4e1c5aa1b5481e283f1c232e6483c135e84
diff --git a/svtools/source/control/ctrltool.cxx b/svtools/source/control/ctrltool.cxx
index ca4b68a..4818928 100644
--- a/svtools/source/control/ctrltool.cxx
+++ b/svtools/source/control/ctrltool.cxx
@@ -108,7 +108,8 @@ private:
sal_uInt16 mnType;
ImplFontListNameInfo(const OUString& rSearchName)
- : maSearchName( rSearchName )
+ : maSearchName(rSearchName)
+ , mpFirst(NULL)
, mnType(0)
{
}
commit f0e8a219dc7ed1f343fff83fa1382bbbd7c57abf
Author: Caolán McNamara <caolanm at redhat.com>
Date: Mon Mar 31 21:08:42 2014 +0100
coverity#984141 Uninitialized pointer field
Change-Id: I326923bb14e90a89461283b344cf59c798d647f3
diff --git a/sfx2/source/dialog/dinfdlg.cxx b/sfx2/source/dialog/dinfdlg.cxx
index 8b3a936..9cc6890 100644
--- a/sfx2/source/dialog/dinfdlg.cxx
+++ b/sfx2/source/dialog/dinfdlg.cxx
@@ -1935,6 +1935,10 @@ Sequence< beans::PropertyValue > CustomPropertiesWindow::GetCustomProperties() c
CustomPropertiesControl::CustomPropertiesControl(Window* pParent)
: VclVBox(pParent)
+ , m_pHeaderBar(NULL)
+ , m_pBody(NULL)
+ , m_pPropertiesWin(NULL)
+ , m_pVertScroll(NULL)
, m_nThumbPos(0)
{
}
commit df524c1d306d442672392a6712106d854d61f2e3
Author: Caolán McNamara <caolanm at redhat.com>
Date: Mon Mar 31 21:07:04 2014 +0100
coverity#738924 Uninitialized pointer field
Change-Id: I09cc36edcc73e4f154e57829ed6246c3870d2542
diff --git a/vcl/inc/salsession.hxx b/vcl/inc/salsession.hxx
index 37788b6..eba1a90 100644
--- a/vcl/inc/salsession.hxx
+++ b/vcl/inc/salsession.hxx
@@ -83,8 +83,10 @@ class VCL_PLUGIN_PUBLIC SalSession
void * m_pProcData;
public:
SalSession()
- : m_aProc( 0 )
- {}
+ : m_aProc(0)
+ , m_pProcData(NULL)
+ {
+ }
virtual ~SalSession();
void SetCallback( SessionProc aCallback, void * pCallbackData )
commit d2582bd97ed98428a2b6ac3b410e8312a697cd51
Author: Caolán McNamara <caolanm at redhat.com>
Date: Mon Mar 31 21:06:03 2014 +0100
coverity#738890 Uninitialized pointer field
Change-Id: Id000614b38b1c2702e3f3362ba29c4a0ac6f18a5
diff --git a/sw/source/core/unocore/unoframe.cxx b/sw/source/core/unocore/unoframe.cxx
index 8258f86..3dd741b 100644
--- a/sw/source/core/unocore/unoframe.cxx
+++ b/sw/source/core/unocore/unoframe.cxx
@@ -1149,12 +1149,11 @@ uno::Sequence< OUString > SwXFrame::getSupportedServiceNames(void) throw( uno::R
SwXFrame::SwXFrame(FlyCntType eSet, const :: SfxItemPropertySet* pSet, SwDoc *pDoc)
: m_pImpl(new Impl)
- ,
- m_pPropSet(pSet),
- m_pDoc ( pDoc ),
- eType(eSet),
- bIsDescriptor(true),
- m_pCopySource( 0 )
+ , m_pPropSet(pSet)
+ , m_pDoc(pDoc)
+ , eType(eSet)
+ , bIsDescriptor(true)
+ , m_pCopySource(0)
{
// Register ourselves as a listener to the document (via the page descriptor)
pDoc->GetPageDescFromPool(RES_POOLPAGE_STANDARD)->Add(this);
@@ -1195,6 +1194,7 @@ SwXFrame::SwXFrame(FlyCntType eSet, const :: SfxItemPropertySet* pSet, SwDoc *pD
break;
default:
+ pProps = NULL;
;
}
}
commit 1235c8ae93bcaaf1f2ababdeefe22dc3700078b7
Author: Caolán McNamara <caolanm at redhat.com>
Date: Mon Mar 31 20:52:09 2014 +0100
coverity#738869 Uninitialized pointer field
Change-Id: If0a3eae2bb54979e8a6119b5084fc0d29cbd5ebb
diff --git a/svx/source/dialog/_contdlg.cxx b/svx/source/dialog/_contdlg.cxx
index 9095ce0..c793ef7 100644
--- a/svx/source/dialog/_contdlg.cxx
+++ b/svx/source/dialog/_contdlg.cxx
@@ -209,6 +209,7 @@ void SvxContourDlg::Update( const Graphic& rGraphic, bool bGraphicLinked,
SvxSuperContourDlg::SvxSuperContourDlg( SfxBindings *_pBindings, SfxChildWindow *pCW,
Window* _pParent, const ResId& rResId ) :
SvxContourDlg ( _pBindings, pCW, _pParent, rResId ),
+ pUpdateEditingObject( NULL ),
pCheckObj ( NULL ),
aContourItem ( SID_CONTOUR_EXEC, *this, *_pBindings ),
aTbx1 ( this, ResId( TBX1, *rResId.GetResMgr() ) ),
@@ -217,6 +218,7 @@ SvxSuperContourDlg::SvxSuperContourDlg( SfxBindings *_pBindings, SfxChildWindow
aStbStatus ( this, WB_BORDER | WB_3DLOOK | WB_LEFT ),
nGrfChanged ( 0UL ),
bExecState ( sal_False ),
+ bUpdateGraphicLinked( sal_False ),
bGraphicLinked ( sal_False ),
maImageList ( SVX_RES( CD_IMAPDLG ) )
{
commit 3b0c60be978e76d4ec0612c5d0fbe90a23a4ace6
Author: Caolán McNamara <caolanm at redhat.com>
Date: Mon Mar 31 20:49:19 2014 +0100
coverity#738566 Uninitialized pointer field
Change-Id: I8eefe76a202c11858df0c5bddebfce3559ec8ca4
diff --git a/canvas/source/cairo/cairo_devicehelper.hxx b/canvas/source/cairo/cairo_devicehelper.hxx
index bf9bcd4..aaf3d35 100644
--- a/canvas/source/cairo/cairo_devicehelper.hxx
+++ b/canvas/source/cairo/cairo_devicehelper.hxx
@@ -92,7 +92,6 @@ namespace cairocanvas
void dumpScreenContent() const;
OutputDevice* getOutputDevice() const { return mpRefDevice; }
- const void* getSysData() { return mpSysData; }
::cairo::SurfaceSharedPtr getSurface();
::cairo::SurfaceSharedPtr createSurface( const ::basegfx::B2ISize& rSize, ::cairo::Content aContent = CAIRO_CONTENT_COLOR_ALPHA );
::cairo::SurfaceSharedPtr createSurface( BitmapSystemData& rData, const Size& rSize );
@@ -121,7 +120,6 @@ namespace cairocanvas
SurfaceProvider* mpSurfaceProvider;
OutputDevice* mpRefDevice;
- const void* mpSysData;
::cairo::SurfaceSharedPtr mpSurface;
};
}
commit de0309581b2a539e8ccf370ff0f054a56dba1c11
Author: Caolán McNamara <caolanm at redhat.com>
Date: Mon Mar 31 20:46:31 2014 +0100
coverity#708140 Uninitialized pointer field
Change-Id: Icd313899ea9e70d398a5bc450960e94eafbed055
diff --git a/sd/source/ui/unoidl/unosrch.cxx b/sd/source/ui/unoidl/unosrch.cxx
index 538150d..99b058a 100644
--- a/sd/source/ui/unoidl/unosrch.cxx
+++ b/sd/source/ui/unoidl/unosrch.cxx
@@ -88,8 +88,9 @@ public:
*/
SdUnoSearchReplaceShape::SdUnoSearchReplaceShape( drawing::XDrawPage* pPage ) throw()
+ : mpShape(NULL)
+ , mpPage(pPage)
{
- mpPage = pPage;
}
SdUnoSearchReplaceShape::~SdUnoSearchReplaceShape() throw()
commit b3ef6e07f8c3fd686208264d9514a63c8475915c
Author: Caolán McNamara <caolanm at redhat.com>
Date: Mon Mar 31 20:44:37 2014 +0100
coverity#708187 Uninitialized pointer field
Change-Id: Ie508844977481fab035d20f16c06c95d1f8a21d6
diff --git a/include/svl/filerec.hxx b/include/svl/filerec.hxx
index 637dc7c..321dd44 100644
--- a/include/svl/filerec.hxx
+++ b/include/svl/filerec.hxx
@@ -239,8 +239,14 @@ protected:
sal_uInt8 _nPreTag; // aus dem Header gelesenes Pre-Tag
// Drei-Phasen-Ctor f"ur Subklassen
- SfxMiniRecordReader() {}
- void Construct_Impl( SvStream *pStream, sal_uInt8 nTag )
+ SfxMiniRecordReader()
+ : _pStream(NULL)
+ , _nEofRec(0)
+ , _bSkipped(false)
+ , _nPreTag(0)
+ {
+ }
+ void Construct_Impl( SvStream *pStream, sal_uInt8 nTag )
{
_pStream = pStream;
_bSkipped = false;
commit 6bcabfeb5ca2e0a6e4566f926f82e15e2ef6f318
Author: Caolán McNamara <caolanm at redhat.com>
Date: Mon Mar 31 20:42:48 2014 +0100
coverity#708344 Uninitialized pointer field
Change-Id: I1c5ad05d5ea8a6a2fa42638c72c1d3bcf1de8897
diff --git a/svx/source/dialog/dlgctrl.cxx b/svx/source/dialog/dlgctrl.cxx
index 8bfa03d..2b6e48c 100644
--- a/svx/source/dialog/dlgctrl.cxx
+++ b/svx/source/dialog/dlgctrl.cxx
@@ -1122,8 +1122,10 @@ void SvxPixelCtl::Reset()
// Constructor: BitmapCtl for SvxPixelCtl
SvxBitmapCtl::SvxBitmapCtl( Window* /*pParent*/, const Size& rSize )
+ : aSize(rSize)
+ , nLines(0)
+ , pBmpArray(NULL)
{
- aSize = rSize;
}
SvxBitmapCtl::~SvxBitmapCtl()
commit fb135c7b476f264fd5582fda91059e471c998963
Author: Caolán McNamara <caolanm at redhat.com>
Date: Mon Mar 31 20:40:45 2014 +0100
coverity#708395 Uninitialized pointer field
Change-Id: If7c1d6e628e50bb0be2e1218d4f1d798744a53a1
diff --git a/svx/source/xoutdev/_xpoly.cxx b/svx/source/xoutdev/_xpoly.cxx
index 371d44d..d5b6084 100644
--- a/svx/source/xoutdev/_xpoly.cxx
+++ b/svx/source/xoutdev/_xpoly.cxx
@@ -34,31 +34,31 @@
#include <basegfx/numeric/ftools.hxx>
-ImpXPolygon::ImpXPolygon( sal_uInt16 nInitSize, sal_uInt16 _nResize )
+ImpXPolygon::ImpXPolygon(sal_uInt16 nInitSize, sal_uInt16 _nResize)
+ : pPointAry(NULL)
+ , pFlagAry(NULL)
+ , pOldPointAry(NULL)
+ , bDeleteOldPoints(sal_False)
+ , nSize(0)
+ , nResize(_nResize)
+ , nPoints(0)
+ , nRefCount(1)
{
- pPointAry = NULL;
- pFlagAry = NULL;
- bDeleteOldPoints = sal_False;
- nSize = 0;
- nResize = _nResize;
- nPoints = 0;
- nRefCount = 1;
-
- Resize( nInitSize );
+ Resize(nInitSize);
}
ImpXPolygon::ImpXPolygon( const ImpXPolygon& rImpXPoly )
+ : pPointAry(NULL)
+ , pFlagAry(NULL)
+ , pOldPointAry(NULL)
+ , bDeleteOldPoints(sal_False)
+ , nSize(0)
+ , nResize(rImpXPoly.nResize)
+ , nPoints(0)
+ , nRefCount(1)
{
( (ImpXPolygon&) rImpXPoly ).CheckPointDelete();
- pPointAry = NULL;
- pFlagAry = NULL;
- bDeleteOldPoints = sal_False;
- nSize = 0;
- ImpXPolygon::nResize = rImpXPoly.nResize;
- nPoints = 0;
- nRefCount = 1;
-
Resize( rImpXPoly.nSize );
// copy
commit df3e0d469fadc008aaf2bf1277a28e87a88bf959
Author: Caolán McNamara <caolanm at redhat.com>
Date: Mon Mar 31 20:30:41 2014 +0100
coverity#708559 Uninitialized pointer field
Change-Id: Ic5b0d4634f223c57bb19c49cc853e8ec5582d1d1
diff --git a/tools/source/zcodec/zcodec.cxx b/tools/source/zcodec/zcodec.cxx
index dd993f1..ab50640 100644
--- a/tools/source/zcodec/zcodec.cxx
+++ b/tools/source/zcodec/zcodec.cxx
@@ -38,20 +38,38 @@
static const int gz_magic[2] = { 0x1f, 0x8b }; /* gzip magic header */
ZCodec::ZCodec( sal_uIntPtr nInBufSize, sal_uIntPtr nOutBufSize, sal_uIntPtr nMemUsage )
- : mnCRC(0)
+ : mbInit(0)
+ , mbStatus(false)
+ , mbFinish(false)
+ , mnMemUsage(nMemUsage)
+ , mpIStm(NULL)
+ , mpInBuf(NULL)
+ , mnInBufSize(nInBufSize)
+ , mnInToRead(0)
+ , mpOStm(NULL)
+ , mpOutBuf(NULL)
+ , mnOutBufSize(nOutBufSize)
+ , mnCRC(0)
+ , mnCompressMethod(0)
{
- mnMemUsage = nMemUsage;
- mnInBufSize = nInBufSize;
- mnOutBufSize = nOutBufSize;
mpsC_Stream = new z_stream;
}
-ZCodec::ZCodec( void )
- : mnCRC(0)
+ZCodec::ZCodec()
+ : mbInit(0)
+ , mbStatus(false)
+ , mbFinish(false)
+ , mnMemUsage(MAX_MEM_USAGE)
+ , mpIStm(NULL)
+ , mpInBuf(NULL)
+ , mnInBufSize(DEFAULT_IN_BUFSIZE)
+ , mnInToRead(0)
+ , mpOStm(NULL)
+ , mpOutBuf(NULL)
+ , mnOutBufSize(DEFAULT_OUT_BUFSIZE)
+ , mnCRC(0)
+ , mnCompressMethod(0)
{
- mnMemUsage = MAX_MEM_USAGE;
- mnInBufSize = DEFAULT_IN_BUFSIZE;
- mnOutBufSize = DEFAULT_OUT_BUFSIZE;
mpsC_Stream = new z_stream;
}
commit 4f4de694bd4dea0d3ee2013dc65909d2c05a992e
Author: Caolán McNamara <caolanm at redhat.com>
Date: Mon Mar 31 20:26:38 2014 +0100
coverity#708557 Uninitialized pointer field
Change-Id: I171cabedc5294085833179d46a261d79a93b8d04
diff --git a/include/tools/stream.hxx b/include/tools/stream.hxx
index 81b897d..9e637e2 100644
--- a/include/tools/stream.hxx
+++ b/include/tools/stream.hxx
@@ -195,7 +195,6 @@ class TOOLS_DLLPUBLIC SvStream
{
private:
// LockBytes Interface
- void* pImp; // unused
SvLockBytesRef xLockBytes; // Default implementation
sal_uInt64 m_nActPos;
commit 19b83873886dab626503d830f91ddf67373f8541
Author: Caolán McNamara <caolanm at redhat.com>
Date: Mon Mar 31 20:25:25 2014 +0100
coverity#708454 Uninitialized pointer field
Change-Id: Ie71618fb2001b1d8ce1af6e8ffb728645dae2963
diff --git a/sw/source/core/text/porfld.cxx b/sw/source/core/text/porfld.cxx
index e791b01..e711579 100644
--- a/sw/source/core/text/porfld.cxx
+++ b/sw/source/core/text/porfld.cxx
@@ -150,6 +150,10 @@ public:
};
SwFldSlot::SwFldSlot( const SwTxtFormatInfo* pNew, const SwFldPortion *pPor )
+ : pOldTxt(NULL)
+ , nIdx(0)
+ , nLen(0)
+ , pInf(NULL)
{
bOn = pPor->GetExpTxt( *pNew, aTxt );
commit 0323fc8ac0bbad748e3af5ce00be591797cd32b3
Author: Caolán McNamara <caolanm at redhat.com>
Date: Mon Mar 31 20:23:45 2014 +0100
coverity#708441 Uninitialized pointer field
Change-Id: Ie122f0b2275ce62b8602078f897fb07f2a36234f
diff --git a/sw/source/core/text/inftxt.cxx b/sw/source/core/text/inftxt.cxx
index 550a50c..d1dc520 100644
--- a/sw/source/core/text/inftxt.cxx
+++ b/sw/source/core/text/inftxt.cxx
@@ -1660,10 +1660,13 @@ SwTxtSlot::SwTxtSlot(
bool bTxtLen,
bool bExgLists,
const sal_Char *pCh )
- : pOldTxt( 0 ),
- pOldSmartTagList( 0 ),
- pOldGrammarCheckList( 0 ),
- pTempList( 0 )
+ : pOldTxt(0)
+ , pOldSmartTagList(0)
+ , pOldGrammarCheckList(0)
+ , pTempList(0)
+ , nIdx(0)
+ , nLen(0)
+ , pInf(NULL)
{
if( pCh )
{
diff --git a/sw/source/core/text/inftxt.hxx b/sw/source/core/text/inftxt.hxx
index 24ce4cb..d81d16e 100644
--- a/sw/source/core/text/inftxt.hxx
+++ b/sw/source/core/text/inftxt.hxx
@@ -779,7 +779,7 @@ public:
SwTxtSlot( const SwTxtSizeInfo *pNew, const SwLinePortion *pPor, bool bTxtLen,
bool bExgLists, const sal_Char *pCh = NULL );
~SwTxtSlot();
- inline bool IsOn() const { return bOn; }
+ bool IsOn() const { return bOn; }
};
/*************************************************************************
commit 73fb311ead7882ab99945dbb74d1f2fd027ed9c4
Author: Caolán McNamara <caolanm at redhat.com>
Date: Mon Mar 31 20:21:33 2014 +0100
coverity#708439 Uninitialized pointer field
Change-Id: I63f1878c91dedc176f69ca593e19f8ff53ea1e6b
diff --git a/sw/source/core/text/inftxt.cxx b/sw/source/core/text/inftxt.cxx
index e84bfbd..550a50c 100644
--- a/sw/source/core/text/inftxt.cxx
+++ b/sw/source/core/text/inftxt.cxx
@@ -1741,9 +1741,11 @@ SwTxtSlot::~SwTxtSlot()
}
}
-SwFontSave::SwFontSave( const SwTxtSizeInfo &rInf, SwFont *pNew,
- SwAttrIter* pItr )
- : pFnt( pNew ? ((SwTxtSizeInfo&)rInf).GetFont() : 0 )
+SwFontSave::SwFontSave(const SwTxtSizeInfo &rInf, SwFont *pNew,
+ SwAttrIter* pItr)
+ : pInf(NULL)
+ , pFnt(pNew ? ((SwTxtSizeInfo&)rInf).GetFont() : NULL)
+ , pIter(NULL)
{
if( pFnt )
{
@@ -1772,8 +1774,6 @@ SwFontSave::SwFontSave( const SwTxtSizeInfo &rInf, SwFont *pNew,
pIter = pItr;
pIter->SetFnt( pNew );
}
- else
- pIter = NULL;
}
}
commit 6e4414b73777c9d61fa9dfcf9f614f6aecf81bcf
Author: Caolán McNamara <caolanm at redhat.com>
Date: Mon Mar 31 20:18:58 2014 +0100
coverity#708437 Uninitialized pointer field
Change-Id: I36f766e6b4e098555c8e6e7918f7c952c544670d
diff --git a/sw/source/core/text/atrstck.cxx b/sw/source/core/text/atrstck.cxx
index a623d45..ab7edf3 100644
--- a/sw/source/core/text/atrstck.cxx
+++ b/sw/source/core/text/atrstck.cxx
@@ -383,7 +383,11 @@ sal_uInt16 SwAttrHandler::SwAttrStack::Pos( const SwTxtAttr& rAttr ) const
* SwAttrHandler::SwAttrHandler()
*************************************************************************/
-SwAttrHandler::SwAttrHandler() : mpShell( 0 ), pFnt( 0 ), bVertLayout( false )
+SwAttrHandler::SwAttrHandler()
+ : mpIDocumentSettingAccess(NULL)
+ , mpShell(NULL)
+ , pFnt(NULL)
+ , bVertLayout(false)
{
memset( pDefaultArray, 0, NUM_DEFAULT_VALUES * sizeof(SfxPoolItem*) );
}
commit f1e645624755a05262fb9427abe21b8ad702e6ab
Author: Caolán McNamara <caolanm at redhat.com>
Date: Mon Mar 31 20:17:32 2014 +0100
coverity#708420 Uninitialized pointer field
Change-Id: I5b86736481b2df5ef6ea2c2746a603550051ac49
diff --git a/sw/source/core/inc/blink.hxx b/sw/source/core/inc/blink.hxx
index 8cc8642..a3a7588 100644
--- a/sw/source/core/inc/blink.hxx
+++ b/sw/source/core/inc/blink.hxx
@@ -36,10 +36,19 @@ class SwBlinkPortion
sal_uInt16 nDir;
public:
- SwBlinkPortion( const SwLinePortion* pPortion, sal_uInt16 nDirection )
- { pPor = pPortion; nDir = nDirection; }
- SwBlinkPortion( const SwBlinkPortion* pBlink, const SwLinePortion* pPort )
- { pPor = pPort; pFrm = pBlink->pFrm; aPos = pBlink->aPos; nDir = pBlink->nDir; }
+ SwBlinkPortion(const SwLinePortion* pPortion, sal_uInt16 nDirection)
+ : pPor(pPortion)
+ , pFrm(NULL)
+ , nDir(nDirection)
+ {
+ }
+ SwBlinkPortion(const SwBlinkPortion* pBlink, const SwLinePortion* pPort)
+ : aPos(pBlink->aPos)
+ , pPor(pPort)
+ , pFrm(pBlink->pFrm)
+ , nDir(pBlink->nDir)
+ {
+ }
void SetPos( const Point& aNew ){ aPos = aNew; }
const Point& GetPos() const{ return aPos; }
void SetRootFrm( const SwRootFrm* pNew ){ pFrm = pNew; }
@@ -71,7 +80,7 @@ public:
void Replace( const SwLinePortion* pOld, const SwLinePortion* pNew );
void Delete( const SwLinePortion* pPor );
void FrmDelete( const SwRootFrm* pRoot );
- inline bool IsVisible() const { return bVisible ; }
+ bool IsVisible() const { return bVisible ; }
};
// Blink-Manager, global variable, see Blink.Cxx
commit 31f915401b797ee2ca44157c42c3a5bd0ac226c5
Author: Caolán McNamara <caolanm at redhat.com>
Date: Mon Mar 31 20:15:26 2014 +0100
coverity#708408 Uninitialized pointer field
Change-Id: If701cad29c8a7af4560a504670262db8c91f97c4
diff --git a/sw/source/core/attr/calbck.cxx b/sw/source/core/attr/calbck.cxx
index b987c1d..cb37347 100644
--- a/sw/source/core/attr/calbck.cxx
+++ b/sw/source/core/attr/calbck.cxx
@@ -385,9 +385,10 @@ bool SwDepend::GetInfo( SfxPoolItem& rInfo ) const
// SwClientIter
SwClientIter::SwClientIter( const SwModify& rModify )
- : rRoot( rModify )
+ : rRoot(rModify)
+ , pNxtIter(NULL)
+ , aSrchId(0)
{
- pNxtIter = 0;
if( pClientIters )
{
// append to list of ClientIters
commit bfb58f15d5a4619c0aa600580f9509162434d02e
Author: Caolán McNamara <caolanm at redhat.com>
Date: Mon Mar 31 20:13:42 2014 +0100
coverity#708407 Uninitialized pointer field
Change-Id: Ifa7d8207432111507fedef1922c1b37cd8da6337
diff --git a/sw/source/core/access/accfrmobj.cxx b/sw/source/core/access/accfrmobj.cxx
index 1263a6c..47a37cf 100644
--- a/sw/source/core/access/accfrmobj.cxx
+++ b/sw/source/core/access/accfrmobj.cxx
@@ -72,6 +72,9 @@ SwAccessibleChild::SwAccessibleChild( Window* pWindow )
SwAccessibleChild::SwAccessibleChild( const SwFrm* pFrm,
const SdrObject* pDrawObj,
Window* pWindow )
+ : mpFrm( 0 )
+ , mpDrawObj( 0 )
+ , mpWindow( 0 )
{
if ( pFrm )
{
commit 416d08786a2fabf05b0436cac9ff6ba3ffb940b7
Author: Caolán McNamara <caolanm at redhat.com>
Date: Mon Mar 31 20:12:16 2014 +0100
use pEdit argument
Change-Id: I8e95498e4e4872fd7a9d95d0a1bae2469064837b
diff --git a/vcl/generic/print/prtsetup.cxx b/vcl/generic/print/prtsetup.cxx
index 50e26e1..32f4c6c 100644
--- a/vcl/generic/print/prtsetup.cxx
+++ b/vcl/generic/print/prtsetup.cxx
@@ -429,11 +429,11 @@ sal_uLong RTSDevicePage::getPDFDevice()
return -1; //explicitly PS
}
-IMPL_LINK( RTSDevicePage, ModifyHdl, Edit*, /* pEdit */ )
+IMPL_LINK(RTSDevicePage, ModifyHdl, Edit*, pEdit)
{
if (m_pCustomValue)
{
- m_pCustomValue->m_aCustomOption = m_pCustomEdit->GetText();
+ m_pCustomValue->m_aCustomOption = pEdit->GetText();
}
return 0;
}
More information about the Libreoffice-commits
mailing list