[Libreoffice-commits] core.git: 28 commits - filter/source forms/source include/svtools rsc/inc rsc/source sc/inc sc/source sd/source svl/source sw/source unusedcode.easy
Caolán McNamara
caolanm at redhat.com
Fri Apr 4 04:14:58 PDT 2014
filter/source/xmlfilteradaptor/XmlFilterAdaptor.hxx | 5 +-
forms/source/component/imgprod.cxx | 14 +----
forms/source/xforms/xformsevent.hxx | 10 +++-
include/svtools/imapcirc.hxx | 4 -
include/svtools/imappoly.hxx | 4 -
rsc/inc/rscdef.hxx | 5 +-
rsc/source/parser/rscpar.cxx | 2
sc/inc/chgviset.hxx | 46 +++++++++----------
sc/inc/pivot.hxx | 2
sc/source/core/data/pivot2.cxx | 9 ---
sc/source/filter/inc/eeparser.hxx | 4 -
sc/source/filter/inc/pivottablebuffer.hxx | 1
sc/source/filter/inc/rtfparse.hxx | 11 +++-
sc/source/filter/inc/scflt.hxx | 6 ++
sc/source/filter/lotus/lotattr.cxx | 1
sc/source/filter/lotus/tool.cxx | 1
sc/source/filter/oox/externallinkfragment.cxx | 7 +-
sc/source/filter/oox/stylesbuffer.cxx | 5 +-
sc/source/filter/oox/worksheethelper.cxx | 12 ++--
sc/source/filter/qpro/biff.cxx | 9 ++-
sc/source/ui/Accessibility/AccessibleContextBase.cxx | 15 ------
sc/source/ui/dbgui/consdlg.cxx | 6 ++
sc/source/ui/inc/AccessibleContextBase.hxx | 4 -
sd/source/ui/app/optsitem.cxx | 15 ++----
sd/source/ui/dlg/docprev.cxx | 2
sd/source/ui/unoidl/SdUnoOutlineView.cxx | 13 +----
svl/source/filerec/filerec.cxx | 5 +-
sw/source/core/docnode/ndtbl.cxx | 2
sw/source/core/text/txtfly.cxx | 1
sw/source/filter/inc/fltshell.hxx | 18 +++++--
unusedcode.easy | 3 -
31 files changed, 119 insertions(+), 123 deletions(-)
New commits:
commit 2bd665fadb312356f09ba59ad84957bc88e35e6d
Author: Caolán McNamara <caolanm at redhat.com>
Date: Fri Apr 4 11:33:01 2014 +0100
callcatcher: another layer post pivottable conversion
Change-Id: I58a6a1f0cf0d67bfadddb331364551776998908a
diff --git a/sc/inc/pivot.hxx b/sc/inc/pivot.hxx
index 37bca61..6102137 100644
--- a/sc/inc/pivot.hxx
+++ b/sc/inc/pivot.hxx
@@ -163,8 +163,6 @@ struct ScPivotFuncData
css::sheet::DataPilotFieldReference maFieldRef;
explicit ScPivotFuncData( SCCOL nCol, sal_uInt16 nFuncMask );
- explicit ScPivotFuncData( SCCOL nCol, long nOriginalDim, sal_uInt16 nFuncMask, sal_uInt8 nDupCount,
- const css::sheet::DataPilotFieldReference& rFieldRef );
bool operator== (const ScPivotFuncData& r) const;
diff --git a/sc/source/core/data/pivot2.cxx b/sc/source/core/data/pivot2.cxx
index 24e46cd..a88de02 100644
--- a/sc/source/core/data/pivot2.cxx
+++ b/sc/source/core/data/pivot2.cxx
@@ -215,15 +215,6 @@ ScPivotFuncData::ScPivotFuncData( SCCOL nCol, sal_uInt16 nFuncMask ) :
mnDupCount(0)
{}
-ScPivotFuncData::ScPivotFuncData(SCCOL nCol, long nOriginalDim, sal_uInt16 nFuncMask,
- sal_uInt8 nDupCount, const DataPilotFieldReference& rFieldRef) :
- mnCol(nCol),
- mnOriginalDim(nOriginalDim),
- mnFuncMask(nFuncMask),
- mnDupCount(nDupCount),
- maFieldRef(rFieldRef)
-{}
-
bool ScPivotFuncData::operator== (const ScPivotFuncData& rFuncData) const
{
if (mnCol != rFuncData.mnCol ||
diff --git a/sc/source/ui/Accessibility/AccessibleContextBase.cxx b/sc/source/ui/Accessibility/AccessibleContextBase.cxx
index 9a19e13..f521e7a 100644
--- a/sc/source/ui/Accessibility/AccessibleContextBase.cxx
+++ b/sc/source/ui/Accessibility/AccessibleContextBase.cxx
@@ -521,21 +521,6 @@ void ScAccessibleContextBase::CommitChange(const AccessibleEventObject& rEvent)
comphelper::AccessibleEventNotifier::addEvent( mnClientId, rEvent );
}
-void ScAccessibleContextBase::ChangeName()
-{
- AccessibleEventObject aEvent;
- aEvent.EventId = AccessibleEventId::NAME_CHANGED;
- aEvent.Source = uno::Reference< XAccessibleContext >(const_cast<ScAccessibleContextBase*>(this));
- aEvent.OldValue <<= msName;
-
- msName = ""; // reset the name so it will be hold again
- getAccessibleName(); // create the new name
-
- aEvent.NewValue <<= msName;
-
- CommitChange(aEvent);
-}
-
void ScAccessibleContextBase::CommitFocusGained() const
{
AccessibleEventObject aEvent;
diff --git a/sc/source/ui/inc/AccessibleContextBase.hxx b/sc/source/ui/inc/AccessibleContextBase.hxx
index 943fca3..23a32d3 100644
--- a/sc/source/ui/inc/AccessibleContextBase.hxx
+++ b/sc/source/ui/inc/AccessibleContextBase.hxx
@@ -284,10 +284,6 @@ public:
void
CommitChange(const com::sun::star::accessibility::AccessibleEventObject& rEvent) const;
- /// change the name and call the listener to tell they the change
- void
- ChangeName();
-
protected:
/// Calls all FocusListener to tell they that the focus is gained.
void CommitFocusGained() const;
diff --git a/unusedcode.easy b/unusedcode.easy
index 696f170..6055a42 100644
--- a/unusedcode.easy
+++ b/unusedcode.easy
@@ -184,7 +184,7 @@ apitest::XTextContent::testGetAnchor()
apitest::XTextField::testGetPresentation()
basegfx::tools::containsOnlyHorizontalAndVerticalEdges(basegfx::B2DPolyPolygon const&)
basegfx::tools::equal(basegfx::B2DPolygon const&, basegfx::B2DPolygon const&, double const&)
-basegfx::tools::equal(basegfx::B3DPolyPolygon const&, basegfx::B3DPolyPolygon const&)
+basegfx::tools::equal(basegfx::B3DPolygon const&, basegfx::B3DPolygon const&, double const&)
canvas::createSurfaceProxyManager(boost::shared_ptr<canvas::IRenderModule> const&)
chart::GL3DBarChartDialogController::GL3DBarChartDialogController()
comphelper::detail::ConfigurationWrapper::getGroupReadWrite(boost::shared_ptr<comphelper::ConfigurationChanges> const&, rtl::OUString const&) const
@@ -198,7 +198,6 @@ connectivity::sdbcx::OGroup::OGroup(rtl::OUString const&, bool)
oglcanvas::CanvasHelper::flush() const
oglcanvas::TextLayout::draw(com::sun::star::rendering::ViewState const&, com::sun::star::rendering::RenderState const&, com::sun::star::uno::Reference<com::sun::star::rendering::XGraphicDevice> const&) const
oox::xls::BiffDrawingObjectBase::BiffDrawingObjectBase(oox::xls::WorksheetHelper const&)
-rtl_OUString::convertFromString::test()
sc::CLBuildKernelThread::CLBuildKernelThread()
sc::CLBuildKernelThread::consume()
sc::CLBuildKernelThread::finish()
commit b44bd3fe56dd743a0f3b6ace9d4c42dcfba20eb7
Author: Caolán McNamara <caolanm at redhat.com>
Date: Fri Apr 4 11:29:09 2014 +0100
coverity#708489 Uninitialized scalar field
Change-Id: Id557d9cc37e38d017efbb5b4d77070affe00f4b9
diff --git a/sw/source/filter/inc/fltshell.hxx b/sw/source/filter/inc/fltshell.hxx
index 46a825d..dc66055 100644
--- a/sw/source/filter/inc/fltshell.hxx
+++ b/sw/source/filter/inc/fltshell.hxx
@@ -413,10 +413,20 @@ class SwFltOutDoc : public SwFltOutBase
public:
SwFltOutDoc(SwDoc& rDocu, SwPaM* pP, SwFltControlStack& rStk,
SwFltEndStack& rEStk)
- : SwFltOutBase(rDocu), rStack(rStk), rEndStack(rEStk), pPaM(pP),
- pFly(0), pTable(0), pTabSavedPos(0), pFlySavedPos(0),
- nTableWidth(0), bReadNoTbl(sal_False)
- {}
+ : SwFltOutBase(rDocu)
+ , rStack(rStk)
+ , rEndStack(rEStk)
+ , pPaM(pP)
+ , pFly(0)
+ , pTable(0)
+ , pTabSavedPos(0)
+ , pFlySavedPos(0)
+ , nTableWidth(0)
+ , usTableX(0)
+ , usTableY(0)
+ , bReadNoTbl(sal_False)
+ {
+ }
void SetReadNoTable() { bReadNoTbl = sal_True; }
sal_Bool IsTableWidthSet() const { return 0 != nTableWidth; }
commit 73717981879dc03d42a045b870ac4d4fba8b7275
Author: Caolán McNamara <caolanm at redhat.com>
Date: Fri Apr 4 11:26:22 2014 +0100
coverity#708464 Uninitialized scalar field
Change-Id: Icf882b97fec554bb25063f092d628c140dae60be
diff --git a/sw/source/core/text/txtfly.cxx b/sw/source/core/text/txtfly.cxx
index ec16ea3..ab556af 100644
--- a/sw/source/core/text/txtfly.cxx
+++ b/sw/source/core/text/txtfly.cxx
@@ -379,6 +379,7 @@ void SwTxtFly::CtorInitTxtFly( const SwTxtFrm *pFrm )
bOn = pPage->GetSortedObjs() != 0;
bTopRule = true;
nMinBottom = 0;
+ nNextTop = 0;
nIndex = ULONG_MAX;
}
commit 7fb80c06655bdafefe3911cdc7821f19e0e8f35a
Author: Caolán McNamara <caolanm at redhat.com>
Date: Fri Apr 4 11:22:57 2014 +0100
coverity#708244 Uninitialized scalar field
Change-Id: I99b68fd7efe69cc7ab7daa244cad4c1ac04c312d
diff --git a/svl/source/filerec/filerec.cxx b/svl/source/filerec/filerec.cxx
index 6ddb964..bdbad2a 100644
--- a/svl/source/filerec/filerec.cxx
+++ b/svl/source/filerec/filerec.cxx
@@ -182,8 +182,9 @@ SfxMiniRecordReader::SfxMiniRecordReader
Bytes reduziert, falls der gesuchte Record der erste in der Folge ist.
*/
-: _pStream( pStream ),
- _bSkipped( nTag == SFX_REC_PRETAG_EOR )
+ : _pStream(pStream)
+ , _nEofRec(0)
+ , _bSkipped(nTag == SFX_REC_PRETAG_EOR)
{
// ggf. ignorieren (s.o.)
if ( _bSkipped )
commit cef1e7d81e31004b1c50dcb3902465a425546af2
Author: Caolán McNamara <caolanm at redhat.com>
Date: Fri Apr 4 11:20:48 2014 +0100
coverity#708196 Uninitialized scalar field
Change-Id: Ibedcaa53de5d0611e9a7dfa23c41e8d1533bf54d
diff --git a/include/svtools/imappoly.hxx b/include/svtools/imappoly.hxx
index 7089e14..79ca52a 100644
--- a/include/svtools/imappoly.hxx
+++ b/include/svtools/imappoly.hxx
@@ -43,7 +43,7 @@ protected:
bool ReadPreProLine( SvStream& rIStm, OUString& rStr );
public:
- IMapPolygonObject() {};
+ IMapPolygonObject() : bEllipse(false) {}
IMapPolygonObject( const Polygon& rPoly,
const OUString& rURL,
const OUString& rAltText,
@@ -52,7 +52,7 @@ public:
const OUString& rName,
bool bActive = true,
bool bPixelCoords = true );
- virtual ~IMapPolygonObject() {};
+ virtual ~IMapPolygonObject() {}
virtual sal_uInt16 GetType() const SAL_OVERRIDE;
virtual bool IsHit( const Point& rPoint ) const SAL_OVERRIDE;
commit bec9937984a9387a2984fc42c0c058fba085483a
Author: Caolán McNamara <caolanm at redhat.com>
Date: Fri Apr 4 11:20:08 2014 +0100
coverity#708195 Uninitialized scalar field
Change-Id: I3f32bc1e1982c303d4ec7624e2ee7361533525f0
diff --git a/include/svtools/imapcirc.hxx b/include/svtools/imapcirc.hxx
index ac4cb9a..2ce4127 100644
--- a/include/svtools/imapcirc.hxx
+++ b/include/svtools/imapcirc.hxx
@@ -40,7 +40,7 @@ protected:
public:
- IMapCircleObject() {};
+ IMapCircleObject() : nRadius(0) {}
IMapCircleObject( const Point& rCenter, sal_uLong nRad,
const OUString& rURL,
const OUString& rAltText,
@@ -49,7 +49,7 @@ public:
const OUString& rName,
bool bActive = true,
bool bPixelCoords = true );
- virtual ~IMapCircleObject() {};
+ virtual ~IMapCircleObject() {}
virtual sal_uInt16 GetType() const SAL_OVERRIDE;
virtual bool IsHit( const Point& rPoint ) const SAL_OVERRIDE;
commit 7ebc5955951d1ed16e5f74645c94444858f7500a
Author: Caolán McNamara <caolanm at redhat.com>
Date: Fri Apr 4 11:18:49 2014 +0100
coverity#708129 Uninitialized scalar field
Change-Id: I88e166a8fd055ebae5a5d2e839c7fddba4ae5ec3
diff --git a/sd/source/ui/app/optsitem.cxx b/sd/source/ui/app/optsitem.cxx
index f1c0ece..a624ac8 100644
--- a/sd/source/ui/app/optsitem.cxx
+++ b/sd/source/ui/app/optsitem.cxx
@@ -96,18 +96,15 @@ void SdOptionsItem::SetModified()
// - SdOptionsGeneric -
-
-
-SdOptionsGeneric::SdOptionsGeneric( sal_uInt16 nConfigId, const OUString& rSubTree ) :
- maSubTree ( rSubTree ),
- mpCfgItem ( NULL ),
- mnConfigId ( nConfigId ),
- mbInit ( rSubTree.isEmpty() )
+SdOptionsGeneric::SdOptionsGeneric(sal_uInt16 nConfigId, const OUString& rSubTree)
+ : maSubTree(rSubTree)
+ , mpCfgItem( NULL)
+ , mnConfigId(nConfigId)
+ , mbInit(rSubTree.isEmpty())
+ , mbEnableModify(false)
{
}
-
-
void SdOptionsGeneric::Init() const
{
if( !mbInit )
commit b501d837d2a66be9e2067bcdde7d4909f22b50c8
Author: Caolán McNamara <caolanm at redhat.com>
Date: Fri Apr 4 11:16:44 2014 +0100
coverity#708085 Uninitialized scalar field
Change-Id: If6aa0a955d8b80b2c1eb4d944829f46167b6fae9
diff --git a/sc/source/ui/dbgui/consdlg.cxx b/sc/source/ui/dbgui/consdlg.cxx
index c6854e7..56169a2 100644
--- a/sc/source/ui/dbgui/consdlg.cxx
+++ b/sc/source/ui/dbgui/consdlg.cxx
@@ -42,7 +42,11 @@
class ScAreaData
{
public:
- ScAreaData() {}
+ ScAreaData()
+ : bIsDbArea(false)
+ {
+ }
+
~ScAreaData() {}
void Set( const OUString& rName, const OUString& rArea, sal_Bool bDb )
commit c8529cfc3a8f3560f8eb7bd593cd8bac985e1d5f
Author: Caolán McNamara <caolanm at redhat.com>
Date: Fri Apr 4 11:15:29 2014 +0100
coverity#708054 Uninitialized scalar field
Change-Id: I75e0bb3a5c0894663fbade08b88ea10efc578c63
diff --git a/sc/source/filter/qpro/biff.cxx b/sc/source/filter/qpro/biff.cxx
index 7ec4f9e..333c720 100644
--- a/sc/source/filter/qpro/biff.cxx
+++ b/sc/source/filter/qpro/biff.cxx
@@ -31,10 +31,11 @@
#include "formulacell.hxx"
#include "biff.hxx"
-ScBiffReader::ScBiffReader( SfxMedium & rMedium ) :
- mnId(0),
- mnLength(0),
- mnOffset(0)
+ScBiffReader::ScBiffReader(SfxMedium& rMedium)
+ : mnId(0)
+ , mnLength(0)
+ , mnOffset(0)
+ , mbEndOfFile(false)
{
mpStream = rMedium.GetInStream();
if( mpStream )
commit b7aee1d1ca712c720749e2b53cf0af80748d1a7e
Author: Caolán McNamara <caolanm at redhat.com>
Date: Fri Apr 4 11:13:17 2014 +0100
coverity#708053 Uninitialized scalar field
Change-Id: I1bdba1a8c32a2b5e55f964113087b26b32002b94
diff --git a/sc/source/filter/lotus/tool.cxx b/sc/source/filter/lotus/tool.cxx
index 228f0fc..a1bdf41 100644
--- a/sc/source/filter/lotus/tool.cxx
+++ b/sc/source/filter/lotus/tool.cxx
@@ -165,6 +165,7 @@ double Snum32ToDouble( sal_uInt32 nValue )
}
FormCache::FormCache( ScDocument* pDoc1, sal_uInt8 nNewDefaultFormat )
+ : nIndex(0)
{ // Default-Format ist 'Default'
nDefaultFormat = nNewDefaultFormat;
pFormTable = pDoc1->GetFormatTable();
commit 587668b75fafac50f352a5b4a86580fa1b3578d1
Author: Caolán McNamara <caolanm at redhat.com>
Date: Fri Apr 4 11:12:16 2014 +0100
coverity#708049 Uninitialized scalar field
Change-Id: Ie5260dd4800a7c5d9185ce603c6e9deb658224a3
diff --git a/sc/source/filter/inc/scflt.hxx b/sc/source/filter/inc/scflt.hxx
index 518bad3..e6b3e663 100644
--- a/sc/source/filter/inc/scflt.hxx
+++ b/sc/source/filter/inc/scflt.hxx
@@ -407,7 +407,11 @@ struct Sc10ColAttr
sal_uInt16 Count;
Sc10ColData* pData;
- Sc10ColAttr() : pData(NULL) {}
+ Sc10ColAttr()
+ : Count(0)
+ , pData(NULL)
+ {
+ }
~Sc10ColAttr() { delete [] pData; }
};
commit 54df60d8d8c48a565aaa8c00fd78d826df252844
Author: Caolán McNamara <caolanm at redhat.com>
Date: Fri Apr 4 11:11:31 2014 +0100
coverity#708048 Uninitialized scalar field
Change-Id: Icd9bc7a072a27328d46e1a6ed14a51644a2f7269
diff --git a/sc/source/filter/inc/rtfparse.hxx b/sc/source/filter/inc/rtfparse.hxx
index c70a2c5..0453f65 100644
--- a/sc/source/filter/inc/rtfparse.hxx
+++ b/sc/source/filter/inc/rtfparse.hxx
@@ -30,11 +30,16 @@ struct ScRTFCellDefault
{
SfxItemSet aItemSet;
SCCOL nCol;
- sal_uInt16 nTwips; // rechter Rand der Zelle
+ sal_uInt16 nTwips; // rechter Rand der Zelle
SCCOL nColOverlap; // MergeCell wenn >1, merged cells wenn 0
- ScRTFCellDefault( SfxItemPool* pPool ) :
- aItemSet( *pPool ), nColOverlap(1) {}
+ ScRTFCellDefault( SfxItemPool* pPool )
+ : aItemSet(*pPool)
+ , nCol(0)
+ , nTwips(0)
+ , nColOverlap(1)
+ {
+ }
};
class ScRTFColTwips : public o3tl::sorted_vector<sal_uLong> {};
commit d4360c40d5d67431789f68ee37172411c3f56925
Author: Caolán McNamara <caolanm at redhat.com>
Date: Fri Apr 4 11:10:25 2014 +0100
coverity#708046 Uninitialized scalar field
Change-Id: I9e29123454da4017e4ee4079d396dd31809c29c7
diff --git a/sc/source/filter/lotus/lotattr.cxx b/sc/source/filter/lotus/lotattr.cxx
index 65f5d46..e78209b 100644
--- a/sc/source/filter/lotus/lotattr.cxx
+++ b/sc/source/filter/lotus/lotattr.cxx
@@ -41,6 +41,7 @@ using namespace ::com::sun::star;
LotAttrCache::ENTRY::ENTRY (ScPatternAttr* p)
: pPattAttr(p)
+ , nHash0(0)
{
}
commit f22bebb2128e4f953ef1a0d205e0b413ee1cc79b
Author: Caolán McNamara <caolanm at redhat.com>
Date: Fri Apr 4 11:09:29 2014 +0100
coverity#708045 Uninitialized scalar field
Change-Id: I8084a56a9805afbf69f8df1afe71ebda2e617fb9
diff --git a/sc/source/filter/inc/eeparser.hxx b/sc/source/filter/inc/eeparser.hxx
index 48a465e..6fb3da1 100644
--- a/sc/source/filter/inc/eeparser.hxx
+++ b/sc/source/filter/inc/eeparser.hxx
@@ -81,7 +81,7 @@ struct ScEEParseEntry
aItemSet( rItemSet ), pValStr( NULL ),
pNumStr( NULL ), pName( NULL ),
nCol(SCCOL_MAX), nRow(SCROW_MAX), nTab(0),
- nColOverlap(1), nRowOverlap(1),
+ nTwips(0), nColOverlap(1), nRowOverlap(1),
nOffset(0), nWidth(0), bHasGraphic(false), bEntirePara(true)
{}
commit 4934937aacfd3056795cd304f8581968a3d18a6e
Author: Caolán McNamara <caolanm at redhat.com>
Date: Fri Apr 4 11:08:56 2014 +0100
coverity#708044 Uninitialized scalar field
Change-Id: I5170e743a334883a84f35255d20a2f525ab4fc74
diff --git a/sc/source/filter/inc/eeparser.hxx b/sc/source/filter/inc/eeparser.hxx
index ab7b209..48a465e 100644
--- a/sc/source/filter/inc/eeparser.hxx
+++ b/sc/source/filter/inc/eeparser.hxx
@@ -73,7 +73,7 @@ struct ScEEParseEntry
aItemSet( *pPool ), pValStr( NULL ),
pNumStr( NULL ), pName( NULL ),
nCol(SCCOL_MAX), nRow(SCROW_MAX), nTab(0),
- nColOverlap(1), nRowOverlap(1),
+ nTwips(0), nColOverlap(1), nRowOverlap(1),
nOffset(0), nWidth(0), bHasGraphic(false), bEntirePara(true)
{}
commit 5c614cf14edc93533b21219b97dbb20dddb234db
Author: Caolán McNamara <caolanm at redhat.com>
Date: Fri Apr 4 11:07:22 2014 +0100
coverity#707982 Uninitialized scalar field
Change-Id: If14da2785e2bddbcc1c098c0c88016b4b58d8452
diff --git a/sc/inc/chgviset.hxx b/sc/inc/chgviset.hxx
index 8a379d4..cc1d0f7 100644
--- a/sc/inc/chgviset.hxx
+++ b/sc/inc/chgviset.hxx
@@ -53,31 +53,33 @@ private:
bool bShowAccepted;
bool bShowRejected;
bool mbIsActionRange;
- sal_uLong mnFirstAction;
- sal_uLong mnLastAction;
+ sal_uLong mnFirstAction;
+ sal_uLong mnLastAction;
public:
- ScChangeViewSettings() :
- aFirstDateTime( DateTime::EMPTY ),
- aLastDateTime( DateTime::EMPTY )
- {
- pCommentSearcher=NULL;
- bIsDate=false;
- bIsAuthor=false;
- bIsRange=false;
- bIsComment=false;
- bShowIt=false;
- eDateMode=SCDM_DATE_BEFORE;
- bEveryoneButMe=false;
- bShowAccepted=false;
- bShowRejected=false;
- mbIsActionRange = false;
- }
-
- ScChangeViewSettings( const ScChangeViewSettings& r );
-
- ~ScChangeViewSettings();
+ ScChangeViewSettings()
+ : pCommentSearcher(NULL)
+ , aFirstDateTime(DateTime::EMPTY)
+ , aLastDateTime(DateTime::EMPTY)
+ , eDateMode(SCDM_DATE_BEFORE)
+ , bShowIt(false)
+ , bIsDate(false)
+ , bIsAuthor(false)
+ , bIsComment(false)
+ , bIsRange(false)
+ , bEveryoneButMe(false)
+ , bShowAccepted(false)
+ , bShowRejected(false)
+ , mbIsActionRange(false)
+ , mnFirstAction(0)
+ , mnLastAction(0)
+ {
+ }
+
+ ScChangeViewSettings( const ScChangeViewSettings& r );
+
+ ~ScChangeViewSettings();
bool ShowChanges() const {return bShowIt;}
void SetShowChanges(bool nFlag) {bShowIt=nFlag;}
commit 7e629ac799ff6d16bcfa2e299e22c08316890678
Author: Caolán McNamara <caolanm at redhat.com>
Date: Fri Apr 4 11:03:51 2014 +0100
coverity#707973 Uninitialized scalar field
Change-Id: I882bca4d09fe655275543cfeb3add59d4584d14b
diff --git a/rsc/source/parser/rscpar.cxx b/rsc/source/parser/rscpar.cxx
index 984d365..2d0f496 100644
--- a/rsc/source/parser/rscpar.cxx
+++ b/rsc/source/parser/rscpar.cxx
@@ -34,6 +34,8 @@ void RscFileInst::Init()
RscFileInst::RscFileInst( RscTypCont * pTC, sal_uLong lIndexSrc,
sal_uLong lFIndex, FILE * fFile )
+ : nErrorLine(0)
+ , nErrorPos(0)
{
pTypCont = pTC;
Init();
commit c58f9aded89774462d466858388d7d7b5cd109f2
Author: Caolán McNamara <caolanm at redhat.com>
Date: Fri Apr 4 11:02:28 2014 +0100
coverity#707972 Uninitialized scalar field
Change-Id: Ib013d4075b2cf55cf02afd77dab6f76c6b9ac70e
diff --git a/rsc/inc/rscdef.hxx b/rsc/inc/rscdef.hxx
index fafd5d9..d85657f 100644
--- a/rsc/inc/rscdef.hxx
+++ b/rsc/inc/rscdef.hxx
@@ -83,7 +83,10 @@ public:
RscId( RscDefine * pEle );
RscId( sal_Int32 lNumber )
- { aExp.SetLong( lNumber ); }
+ {
+ aExp.cUnused = false;
+ aExp.SetLong( lNumber );
+ }
RscId( const RscExpType & rExpType )
{ Create( rExpType ); }
commit c6d95c1080028e61ab79fb10992e03730ab52733
Author: Caolán McNamara <caolanm at redhat.com>
Date: Fri Apr 4 11:00:27 2014 +0100
coverity#707962 Uninitialized scalar field
Change-Id: I3620c5cbd16869d2744e5bfa812f88805a030019
diff --git a/sc/source/filter/oox/worksheethelper.cxx b/sc/source/filter/oox/worksheethelper.cxx
index a2abf59..9a1533b 100644
--- a/sc/source/filter/oox/worksheethelper.cxx
+++ b/sc/source/filter/oox/worksheethelper.cxx
@@ -167,16 +167,14 @@ bool RowModel::isMergeable( const RowModel& rModel ) const
(mbCollapsed == rModel.mbCollapsed);
}
-
-
-PageBreakModel::PageBreakModel() :
- mnColRow( 0 ),
- mbManual( false )
+PageBreakModel::PageBreakModel()
+ : mnColRow(0)
+ , mnMin(0)
+ , mnMax(0)
+ , mbManual(false)
{
}
-
-
HyperlinkModel::HyperlinkModel()
{
}
commit 9cddd4dc1e7e326498f3965df31981faf73a46ff
Author: Caolán McNamara <caolanm at redhat.com>
Date: Fri Apr 4 10:58:43 2014 +0100
coverity#707961 Uninitialized scalar field
Change-Id: I86bcdd6cda589e42fb18a33002092d87c6d3a2d4
diff --git a/sc/source/filter/oox/stylesbuffer.cxx b/sc/source/filter/oox/stylesbuffer.cxx
index 842c168..28d32c0 100644
--- a/sc/source/filter/oox/stylesbuffer.cxx
+++ b/sc/source/filter/oox/stylesbuffer.cxx
@@ -399,8 +399,9 @@ static const sal_Int32 spnDefColors8[] =
-ColorPalette::ColorPalette( const WorkbookHelper& rHelper ) :
- WorkbookHelper( rHelper )
+ColorPalette::ColorPalette( const WorkbookHelper& rHelper )
+ : WorkbookHelper(rHelper)
+ , mnAppendIndex(0)
{
// default colors
switch( getFilterType() )
commit 727752e1297ffe7a9f428162b284e082d51c36ec
Author: Caolán McNamara <caolanm at redhat.com>
Date: Fri Apr 4 10:57:37 2014 +0100
coverity#707959 unused mbShowDataDropDown member
Change-Id: Ia09a8a8782fd8370f3655c4ab7f4ac18f5371133
diff --git a/sc/source/filter/inc/pivottablebuffer.hxx b/sc/source/filter/inc/pivottablebuffer.hxx
index 4147a4c..fff2b65 100644
--- a/sc/source/filter/inc/pivottablebuffer.hxx
+++ b/sc/source/filter/inc/pivottablebuffer.hxx
@@ -264,7 +264,6 @@ struct PTDefinitionModel : public AutoFormatModel
bool mbDisableFieldList;
bool mbShowCalcMembers;
bool mbVisualTotals;
- bool mbShowDataDropDown;
bool mbShowDrill;
bool mbPrintDrill;
bool mbEnableDrill;
commit 6900a3bfb7bc7a61f81448f28413c439d8c07f3e
Author: Caolán McNamara <caolanm at redhat.com>
Date: Fri Apr 4 10:56:52 2014 +0100
coverity#707958 Uninitialized scalar field
Change-Id: Ic21f72913c944510baeca3f0ec424485c72745c0
diff --git a/sc/source/filter/oox/externallinkfragment.cxx b/sc/source/filter/oox/externallinkfragment.cxx
index 605a54e..b905997 100644
--- a/sc/source/filter/oox/externallinkfragment.cxx
+++ b/sc/source/filter/oox/externallinkfragment.cxx
@@ -41,9 +41,10 @@ using namespace ::oox::core;
ExternalSheetDataContext::ExternalSheetDataContext(
- WorkbookFragmentBase& rFragment, const Reference< XExternalSheetCache >& rxSheetCache ) :
- WorkbookContextBase( rFragment ),
- mxSheetCache( rxSheetCache )
+ WorkbookFragmentBase& rFragment, const Reference< XExternalSheetCache >& rxSheetCache )
+ : WorkbookContextBase(rFragment)
+ , mxSheetCache(rxSheetCache)
+ , mnCurrType(XML_TOKEN_INVALID)
{
OSL_ENSURE( mxSheetCache.is(), "ExternalSheetDataContext::ExternalSheetDataContext - missing sheet cache" );
}
commit a7b6623b1f473c631d9d203dc714ca0c03938ac3
Author: Caolán McNamara <caolanm at redhat.com>
Date: Fri Apr 4 10:54:34 2014 +0100
coverity#707864 Uninitialized scalar field
Change-Id: Ieb42d64ead25d9e06175a7664d8659e0907d28f1
diff --git a/forms/source/xforms/xformsevent.hxx b/forms/source/xforms/xformsevent.hxx
index acbffb0..51b058d 100644
--- a/forms/source/xforms/xformsevent.hxx
+++ b/forms/source/xforms/xformsevent.hxx
@@ -39,8 +39,14 @@ class XFormsEventConcrete : public cppu::WeakImplHelper1< XFormsEvent > {
typedef com::sun::star::xml::dom::events::PhaseType PhaseType_t;
typedef com::sun::star::util::Time Time_t;
- inline XFormsEventConcrete( void ) : m_canceled(sal_False) {}
- virtual ~XFormsEventConcrete( void ) {}
+ XFormsEventConcrete()
+ : m_canceled(false)
+ , m_phase(com::sun::star::xml::dom::events::PhaseType_CAPTURING_PHASE)
+ , m_bubbles(false)
+ , m_cancelable(false)
+ {
+ }
+ virtual ~XFormsEventConcrete() {}
virtual OUString SAL_CALL getType() throw (RuntimeException_t, std::exception) SAL_OVERRIDE;
virtual XEventTarget_t SAL_CALL getTarget() throw (RuntimeException_t, std::exception) SAL_OVERRIDE;
commit 627b0c682a7d0310daa62b2f47d0d3d8aba3a75e
Author: Caolán McNamara <caolanm at redhat.com>
Date: Fri Apr 4 10:49:10 2014 +0100
coverity#707862 Uninitialized scalar field
Change-Id: I0d94414f4645d3f5da6242bbfefcee449572d2c0
diff --git a/forms/source/component/imgprod.cxx b/forms/source/component/imgprod.cxx
index 47be5b2..d624620 100644
--- a/forms/source/component/imgprod.cxx
+++ b/forms/source/component/imgprod.cxx
@@ -170,19 +170,15 @@ ErrCode ImgProdLockBytes::Stat( SvLockBytesStat* pStat, SvLockBytesStatFlag eFla
}
}
-
// - ImageProducer -
-
-
-ImageProducer::ImageProducer() :
- mpStm ( NULL ),
- mbConsInit ( sal_False )
+ImageProducer::ImageProducer()
+ : mpStm(NULL)
+ , mnTransIndex(0)
+ , mbConsInit(sal_False)
{
mpGraphic = new Graphic;
}
-
-
ImageProducer::~ImageProducer()
{
delete mpGraphic;
@@ -192,8 +188,6 @@ ImageProducer::~ImageProducer()
mpStm = NULL;
}
-
-
// ::com::sun::star::uno::XInterface
::com::sun::star::uno::Any ImageProducer::queryInterface( const ::com::sun::star::uno::Type & rType ) throw(::com::sun::star::uno::RuntimeException, std::exception)
{
commit c48dd161876de095fcede83c87b4596d299150e5
Author: Caolán McNamara <caolanm at redhat.com>
Date: Fri Apr 4 10:47:50 2014 +0100
coverity#707860 Uninitialized scalar field
Change-Id: I5ac73f41333f465a63daa3de44cd6d4e7d931689
diff --git a/filter/source/xmlfilteradaptor/XmlFilterAdaptor.hxx b/filter/source/xmlfilteradaptor/XmlFilterAdaptor.hxx
index a3c25e0..89250ab 100644
--- a/filter/source/xmlfilteradaptor/XmlFilterAdaptor.hxx
+++ b/filter/source/xmlfilteradaptor/XmlFilterAdaptor.hxx
@@ -76,7 +76,10 @@ protected:
public:
XmlFilterAdaptor( const ::com::sun::star::uno::Reference< ::com::sun::star::uno::XComponentContext > & rxContext)
- : mxContext( rxContext ) {}
+ : mxContext(rxContext)
+ , meType(FILTER_IMPORT)
+ {
+ }
virtual ~XmlFilterAdaptor() {}
commit 8d0299673fb59ac8787d60f7a151aad2d3ab37a7
Author: Caolán McNamara <caolanm at redhat.com>
Date: Fri Apr 4 10:43:51 2014 +0100
coverity#704877 Unchecked dynamic_cast
Change-Id: Icbe926c133fd79c0a420578332ae2b6abdbdea9b
diff --git a/sw/source/core/docnode/ndtbl.cxx b/sw/source/core/docnode/ndtbl.cxx
index 317c9e6..9091b66 100644
--- a/sw/source/core/docnode/ndtbl.cxx
+++ b/sw/source/core/docnode/ndtbl.cxx
@@ -2247,7 +2247,7 @@ sal_uInt16 SwDoc::MergeTbl( SwPaM& rPam )
// FIXME: why is this horrible cleanup necessary?
SwUndoRedline *const pU = dynamic_cast<SwUndoRedline*>(
GetUndoManager().RemoveLastUndo());
- if( pU->GetRedlSaveCount() )
+ if (pU && pU->GetRedlSaveCount())
{
SwEditShell *const pEditShell(GetEditShell(0));
OSL_ASSERT(pEditShell);
commit aa0e805a813b21f619986e2e82752031d82ea09c
Author: Caolán McNamara <caolanm at redhat.com>
Date: Fri Apr 4 10:41:59 2014 +0100
coverity#704770 Unchecked dynamic_cast
Change-Id: Ib690d6ad50e89f6cf4b1046fde6bea2d669b971d
diff --git a/sd/source/ui/unoidl/SdUnoOutlineView.cxx b/sd/source/ui/unoidl/SdUnoOutlineView.cxx
index 057aa3c..1d0e947 100644
--- a/sd/source/ui/unoidl/SdUnoOutlineView.cxx
+++ b/sd/source/ui/unoidl/SdUnoOutlineView.cxx
@@ -100,26 +100,19 @@ void SAL_CALL SdUnoOutlineView::removeSelectionChangeListener (
(void)rxListener;
}
-
-
-
//----- XDrawView -------------------------------------------------------------
-
-
void SAL_CALL SdUnoOutlineView::setCurrentPage (
const Reference< drawing::XDrawPage >& xPage)
throw(RuntimeException, std::exception)
{
SvxDrawPage* pDrawPage = SvxDrawPage::getImplementation( xPage );
SdrPage *pSdrPage = pDrawPage ? pDrawPage->GetSdrPage() : NULL;
+ SdPage *pSdPage = dynamic_cast<SdPage*>(pSdrPage);
- if (pSdrPage != NULL)
- mrOutlineViewShell.SetCurrentPage(dynamic_cast<SdPage*>(pSdrPage));
+ if (pSdPage != NULL)
+ mrOutlineViewShell.SetCurrentPage(pSdPage);
}
-
-
-
Reference< drawing::XDrawPage > SAL_CALL SdUnoOutlineView::getCurrentPage (void)
throw(RuntimeException, std::exception)
{
commit 9754ac4ee7047ab0f5fd8369aa617da210e3aed5
Author: Caolán McNamara <caolanm at redhat.com>
Date: Fri Apr 4 10:39:21 2014 +0100
coverity#704743 Unchecked dynamic_cast
Change-Id: I35067c31c3a083791436eba9690d592f0099d3b5
diff --git a/sd/source/ui/dlg/docprev.cxx b/sd/source/ui/dlg/docprev.cxx
index 3d42a52..ebb939d 100644
--- a/sd/source/ui/dlg/docprev.cxx
+++ b/sd/source/ui/dlg/docprev.cxx
@@ -148,7 +148,7 @@ void SdDocPreviewWin::Paint( const Rectangle& rRect )
void SdDocPreviewWin::startPreview()
{
::sd::DrawDocShell* pDocShell = dynamic_cast< ::sd::DrawDocShell * >( mpObj );
- if( mpObj )
+ if( pDocShell )
{
SdDrawDocument* pDoc = pDocShell->GetDoc();
More information about the Libreoffice-commits
mailing list