[Libreoffice-commits] core.git: 13 commits - connectivity/source starmath/source svl/source vcl/source xmloff/source
Norbert Thiebaud
nthiebaud at gmail.com
Sun Apr 6 11:11:54 PDT 2014
connectivity/source/commontools/dbexception.cxx | 46 +++++++++-----------
connectivity/source/drivers/calc/CConnection.cxx | 2
connectivity/source/drivers/file/FConnection.cxx | 5 +-
connectivity/source/inc/calc/CConnection.hxx | 7 ++-
connectivity/source/inc/file/FConnection.hxx | 7 ++-
starmath/source/mathmlimport.cxx | 15 ++++--
starmath/source/node.cxx | 17 ++++---
starmath/source/parse.cxx | 7 ++-
svl/source/filerec/filerec.cxx | 2
svl/source/misc/strmadpt.cxx | 28 ++++++------
svl/source/numbers/zformat.cxx | 13 ++++-
vcl/source/filter/igif/gifread.cxx | 52 ++++++++++++++---------
vcl/source/filter/igif/gifread.hxx | 38 ++++++++--------
vcl/source/filter/wmf/winmtf.cxx | 9 ++-
xmloff/source/draw/shapeexport.cxx | 5 +-
xmloff/source/style/bordrhdl.cxx | 11 +---
16 files changed, 156 insertions(+), 108 deletions(-)
New commits:
commit 0586bdc74813ef83504801d74800589f99c877b0
Author: Norbert Thiebaud <nthiebaud at gmail.com>
Date: Sun Apr 6 02:18:22 2014 -0500
coverity#704111: Unchecked return value
Change-Id: Ida3a1b2804f655b39378f79e10872dcac4e70cf1
diff --git a/xmloff/source/draw/shapeexport.cxx b/xmloff/source/draw/shapeexport.cxx
index 655f163..5b58920 100644
--- a/xmloff/source/draw/shapeexport.cxx
+++ b/xmloff/source/draw/shapeexport.cxx
@@ -3213,8 +3213,9 @@ void XMLShapeExport::ImpExportMediaShape(
ImpExportNewTrans(xPropSet, nFeatures, pRefPoint);
if(eShapeType == XmlShapeTypePresMediaShape)
- ImpExportPresentationAttributes( xPropSet, GetXMLToken(XML_PRESENTATION_OBJECT) );
-
+ {
+ (void)ImpExportPresentationAttributes( xPropSet, GetXMLToken(XML_PRESENTATION_OBJECT) );
+ }
bool bCreateNewline( (nFeatures & SEF_EXPORT_NO_WS) == 0 ); // #86116#/#92210#
SvXMLElementExport aElem( mrExport, XML_NAMESPACE_DRAW,
XML_FRAME, bCreateNewline, true );
commit 302bd1c4ec585011b141a167ce3f2402fcccf80c
Author: Norbert Thiebaud <nthiebaud at gmail.com>
Date: Sun Apr 6 02:15:14 2014 -0500
coverity#441207: Logicaly dead code
Change-Id: Ia198d64a95d86a1cd47987d6db3aa3faafba84f4
diff --git a/xmloff/source/style/bordrhdl.cxx b/xmloff/source/style/bordrhdl.cxx
index 41b94c9..860f9a4 100644
--- a/xmloff/source/style/bordrhdl.cxx
+++ b/xmloff/source/style/bordrhdl.cxx
@@ -222,7 +222,7 @@ bool XMLBorderHdl::importXML( const OUString& rStrImpValue, uno::Any& rValue, co
}
// if there is no style or a different style than none but no width,
- // then the declaration is not valid.
+ // then the declaration is not valid.
if (!bHasStyle || (table::BorderLineStyle::NONE != nStyle && !bHasWidth))
return false;
@@ -237,7 +237,7 @@ bool XMLBorderHdl::importXML( const OUString& rStrImpValue, uno::Any& rValue, co
}
// first of all, delete an empty line
- if ((bHasStyle && table::BorderLineStyle::NONE == nStyle) ||
+ if (table::BorderLineStyle::NONE == nStyle ||
(bHasWidth && USHRT_MAX == nNamedWidth && 0 == nWidth) )
{
aBorderLine.InnerLineWidth = 0;
@@ -245,7 +245,7 @@ bool XMLBorderHdl::importXML( const OUString& rStrImpValue, uno::Any& rValue, co
aBorderLine.LineDistance = 0;
aBorderLine.LineWidth = 0;
}
- else if( bHasWidth )
+ else
{
if( USHRT_MAX != nNamedWidth )
{
@@ -257,11 +257,6 @@ bool XMLBorderHdl::importXML( const OUString& rStrImpValue, uno::Any& rValue, co
lcl_frmitems_setXMLBorderStyle( aBorderLine, nStyle );
}
}
- else
- {
- aBorderLine.LineWidth = 0;
- lcl_frmitems_setXMLBorderStyle( aBorderLine, nStyle );
- }
// set color
if( bHasColor )
commit fa2d66daa6ad1f4d4c151b2990db22d3bcc57982
Author: Norbert Thiebaud <nthiebaud at gmail.com>
Date: Sun Apr 6 01:06:28 2014 -0500
coverity#706300,306,983619: Uncaught exception
Change-Id: If46a483ba0a5334926ffb5c25db064a5d2b81e46
diff --git a/connectivity/source/drivers/calc/CConnection.cxx b/connectivity/source/drivers/calc/CConnection.cxx
index c3a7be9..a3d09d4 100644
--- a/connectivity/source/drivers/calc/CConnection.cxx
+++ b/connectivity/source/drivers/calc/CConnection.cxx
@@ -63,7 +63,7 @@ OCalcConnection::~OCalcConnection()
}
void OCalcConnection::construct(const OUString& url,const Sequence< PropertyValue >& info)
- throw(SQLException)
+ throw(SQLException, RuntimeException, DeploymentException)
{
SAL_INFO( "connectivity.drivers", "calc Ocke.Janssen at sun.com OCalcConnection::construct" );
// open file
diff --git a/connectivity/source/drivers/file/FConnection.cxx b/connectivity/source/drivers/file/FConnection.cxx
index 1309262..24ce44f 100644
--- a/connectivity/source/drivers/file/FConnection.cxx
+++ b/connectivity/source/drivers/file/FConnection.cxx
@@ -93,7 +93,10 @@ sal_Bool OConnection::matchesExtension( const OUString& _rExt ) const
}
-void OConnection::construct(const OUString& url,const Sequence< PropertyValue >& info) throw(SQLException)
+void OConnection::construct(const OUString& url,const Sequence< PropertyValue >& info)
+ throw( css::sdbc::SQLException,
+ css::uno::RuntimeException,
+ css::uno::DeploymentException)
{
osl_atomic_increment( &m_refCount );
diff --git a/connectivity/source/inc/calc/CConnection.hxx b/connectivity/source/inc/calc/CConnection.hxx
index 651e874..89903b2 100644
--- a/connectivity/source/inc/calc/CConnection.hxx
+++ b/connectivity/source/inc/calc/CConnection.hxx
@@ -21,6 +21,7 @@
#define _CONNECTIVITY_CALC_CONNECTION_HXX_
#include "file/FConnection.hxx"
+#include <com/sun/star/uno/DeploymentException.hpp>
namespace com { namespace sun { namespace star { namespace sheet {
class XSpreadsheetDocument;
@@ -45,8 +46,10 @@ namespace connectivity
virtual ~OCalcConnection();
virtual void construct(const OUString& _rUrl,
- const ::com::sun::star::uno::Sequence< ::com::sun::star::beans::PropertyValue >& _rInfo )
- throw( ::com::sun::star::sdbc::SQLException) SAL_OVERRIDE;
+ const ::com::sun::star::uno::Sequence< ::com::sun::star::beans::PropertyValue >& _rInfo )
+ throw( css::sdbc::SQLException,
+ css::uno::RuntimeException,
+ css::uno::DeploymentException) SAL_OVERRIDE;
// XServiceInfo
DECLARE_SERVICE_INFO();
diff --git a/connectivity/source/inc/file/FConnection.hxx b/connectivity/source/inc/file/FConnection.hxx
index d700a34..58dd3c0 100644
--- a/connectivity/source/inc/file/FConnection.hxx
+++ b/connectivity/source/inc/file/FConnection.hxx
@@ -28,6 +28,7 @@
#include <rtl/ustring.hxx>
#include <com/sun/star/sdbcx/XTablesSupplier.hpp>
#include <com/sun/star/ucb/XDynamicResultSet.hpp>
+#include <com/sun/star/uno/DeploymentException.hpp>
#include "connectivity/sqlparse.hxx"
#include "connectivity/sqliterator.hxx"
#include "TConnection.hxx"
@@ -77,7 +78,11 @@ namespace connectivity
OConnection(OFileDriver* _pDriver);
- virtual void construct(const OUString& _rUrl,const ::com::sun::star::uno::Sequence< ::com::sun::star::beans::PropertyValue >& _rInfo ) throw( ::com::sun::star::sdbc::SQLException);
+ virtual void construct(const OUString& _rUrl, const ::com::sun::star::uno::Sequence< ::com::sun::star::beans::PropertyValue >& _rInfo )
+ throw( css::sdbc::SQLException,
+ css::uno::RuntimeException,
+ css::uno::DeploymentException);
+
void closeAllStatements () throw( ::com::sun::star::sdbc::SQLException);
commit fa2769d549d6afb389301fe4953e34c99eb27d0a
Author: Norbert Thiebaud <nthiebaud at gmail.com>
Date: Sun Apr 6 00:45:55 2014 -0500
coverity#706292,95-96,98: Uncaught exception
Change-Id: I7daf691bdaef6939112383f65ba72d246efe58c8
diff --git a/connectivity/source/commontools/dbexception.cxx b/connectivity/source/commontools/dbexception.cxx
index 2056a44..cdfda53 100644
--- a/connectivity/source/commontools/dbexception.cxx
+++ b/connectivity/source/commontools/dbexception.cxx
@@ -468,31 +468,29 @@ OUString getStandardSQLState( StandardSQLState _eState )
{
switch ( _eState )
{
- case SQL_WRONG_PARAMETER_NUMBER: return OUString("07001");
- case SQL_INVALID_DESCRIPTOR_INDEX: return OUString("07009");
- case SQL_UNABLE_TO_CONNECT: return OUString("08001");
- case SQL_NUMERIC_OUT_OF_RANGE: return OUString("22003");
- case SQL_INVALID_DATE_TIME: return OUString("22007");
- case SQL_INVALID_CURSOR_STATE: return OUString("24000");
- case SQL_TABLE_OR_VIEW_EXISTS: return OUString("42S01");
- case SQL_TABLE_OR_VIEW_NOT_FOUND: return OUString("42S02");
- case SQL_INDEX_ESISTS: return OUString("42S11");
- case SQL_INDEX_NOT_FOUND: return OUString("42S12");
- case SQL_COLUMN_EXISTS: return OUString("42S21");
- case SQL_COLUMN_NOT_FOUND: return OUString("42S22");
- case SQL_GENERAL_ERROR: return OUString("HY000");
- case SQL_INVALID_SQL_DATA_TYPE: return OUString("HY004");
- case SQL_OPERATION_CANCELED: return OUString("HY008");
- case SQL_FUNCTION_SEQUENCE_ERROR: return OUString("HY010");
- case SQL_INVALID_CURSOR_POSITION: return OUString("HY109");
- case SQL_INVALID_BOOKMARK_VALUE: return OUString("HY111");
- case SQL_FEATURE_NOT_IMPLEMENTED: return OUString("HYC00");
- case SQL_FUNCTION_NOT_SUPPORTED: return OUString("IM001");
- case SQL_CONNECTION_DOES_NOT_EXIST: return OUString("08003");
- default:
- break;
+ case SQL_WRONG_PARAMETER_NUMBER: return OUString("07001");
+ case SQL_INVALID_DESCRIPTOR_INDEX: return OUString("07009");
+ case SQL_UNABLE_TO_CONNECT: return OUString("08001");
+ case SQL_NUMERIC_OUT_OF_RANGE: return OUString("22003");
+ case SQL_INVALID_DATE_TIME: return OUString("22007");
+ case SQL_INVALID_CURSOR_STATE: return OUString("24000");
+ case SQL_TABLE_OR_VIEW_EXISTS: return OUString("42S01");
+ case SQL_TABLE_OR_VIEW_NOT_FOUND: return OUString("42S02");
+ case SQL_INDEX_ESISTS: return OUString("42S11");
+ case SQL_INDEX_NOT_FOUND: return OUString("42S12");
+ case SQL_COLUMN_EXISTS: return OUString("42S21");
+ case SQL_COLUMN_NOT_FOUND: return OUString("42S22");
+ case SQL_GENERAL_ERROR: return OUString("HY000");
+ case SQL_INVALID_SQL_DATA_TYPE: return OUString("HY004");
+ case SQL_OPERATION_CANCELED: return OUString("HY008");
+ case SQL_FUNCTION_SEQUENCE_ERROR: return OUString("HY010");
+ case SQL_INVALID_CURSOR_POSITION: return OUString("HY109");
+ case SQL_INVALID_BOOKMARK_VALUE: return OUString("HY111");
+ case SQL_FEATURE_NOT_IMPLEMENTED: return OUString("HYC00");
+ case SQL_FUNCTION_NOT_SUPPORTED: return OUString("IM001");
+ case SQL_CONNECTION_DOES_NOT_EXIST: return OUString("08003");
+ default: return OUString("HY001"); // General Error
}
- throw RuntimeException();
}
commit de69c1e9314947c7e29fa6acd30460d8d3c357e9
Author: Norbert Thiebaud <nthiebaud at gmail.com>
Date: Sun Apr 6 00:06:10 2014 -0500
coverity#708313: Unitialized scalar field
Change-Id: If79cfd926464eb1360ea7764c8c9c609f533de3d
diff --git a/vcl/source/filter/igif/gifread.cxx b/vcl/source/filter/igif/gifread.cxx
index a26a57a..94f1a72 100644
--- a/vcl/source/filter/igif/gifread.cxx
+++ b/vcl/source/filter/igif/gifread.cxx
@@ -25,25 +25,39 @@
#define NO_PENDING( rStm ) ( ( rStm ).GetError() != ERRCODE_IO_PENDING )
-GIFReader::GIFReader( SvStream& rStm ) :
- aGPalette ( 256 ),
- aLPalette ( 256 ),
- rIStm ( rStm ),
- pDecomp ( NULL ),
- pAcc8 ( NULL ),
- pAcc1 ( NULL ),
- nYAcc ( 0 ),
- nLastPos ( rStm.Tell() ),
- nLogWidth100 ( 0UL ),
- nLogHeight100 ( 0UL ),
- nGlobalWidth ( 0 ),
- nGlobalHeight ( 0 ),
- nImageWidth ( 0 ),
- nImageHeight ( 0 ),
- nLoops ( 1 ),
- eActAction ( GLOBAL_HEADER_READING ),
- bGCTransparent ( false ),
- bImGraphicReady ( false )
+GIFReader::GIFReader( SvStream& rStm )
+ : aGPalette ( 256 )
+ , aLPalette ( 256 )
+ , rIStm ( rStm )
+ , pDecomp ( NULL )
+ , pAcc8 ( NULL )
+ , pAcc1 ( NULL )
+ , nYAcc ( 0 )
+ , nLastPos ( rStm.Tell() )
+ , nLogWidth100 ( 0UL )
+ , nLogHeight100 ( 0UL )
+ , nGlobalWidth ( 0 )
+ , nGlobalHeight ( 0 )
+ , nImageWidth ( 0 )
+ , nImageHeight ( 0 )
+ , nImagePosX ( 0 )
+ , nImagePosY ( 0 )
+ , nImageX ( 0 )
+ , nImageY ( 0 )
+ , nLastImageY ( 0 )
+ , nLastInterCount ( 0 )
+ , nLoops ( 1 )
+ , eActAction ( GLOBAL_HEADER_READING )
+ , bStatus ( false )
+ , bGCTransparent ( false )
+ , bInterlaced ( false)
+ , bOverreadBlock ( false )
+ , bImGraphicReady ( false )
+ , bGlobalPalette ( false )
+ , nBackgroundColor ( 0 )
+ , nGCTransparentIndex ( 0 )
+ , cTransIndex1 ( 0 )
+ , cNonTransIndex1 ( 0 )
{
maUpperName = "SVIGIF";
pSrcBuf = new sal_uInt8[ 256 ];
diff --git a/vcl/source/filter/igif/gifread.hxx b/vcl/source/filter/igif/gifread.hxx
index 8b22c78..5816fe5 100644
--- a/vcl/source/filter/igif/gifread.hxx
+++ b/vcl/source/filter/igif/gifread.hxx
@@ -65,30 +65,30 @@ class GIFReader : public GraphicReader
long nLastPos;
sal_uInt32 nLogWidth100;
sal_uInt32 nLogHeight100;
- sal_uInt16 nTimer;
- sal_uInt16 nGlobalWidth; // maximum imagewidth from header
- sal_uInt16 nGlobalHeight; // maximum imageheight from header
- sal_uInt16 nImageWidth; // maximum screenwidth from header
- sal_uInt16 nImageHeight; // maximum screenheight from header
- sal_uInt16 nImagePosX;
- sal_uInt16 nImagePosY;
- sal_uInt16 nImageX; // maximum screenwidth from header
- sal_uInt16 nImageY; // maximum screenheight from header
- sal_uInt16 nLastImageY;
- sal_uInt16 nLastInterCount;
- sal_uInt16 nLoops;
+ sal_uInt16 nTimer;
+ sal_uInt16 nGlobalWidth; // maximum imagewidth from header
+ sal_uInt16 nGlobalHeight; // maximum imageheight from header
+ sal_uInt16 nImageWidth; // maximum screenwidth from header
+ sal_uInt16 nImageHeight; // maximum screenheight from header
+ sal_uInt16 nImagePosX;
+ sal_uInt16 nImagePosY;
+ sal_uInt16 nImageX; // maximum screenwidth from header
+ sal_uInt16 nImageY; // maximum screenheight from header
+ sal_uInt16 nLastImageY;
+ sal_uInt16 nLastInterCount;
+ sal_uInt16 nLoops;
GIFAction eActAction;
bool bStatus;
- bool bGCTransparent; // is the image transparant, if yes:
+ bool bGCTransparent; // is the image transparant, if yes:
bool bInterlaced;
bool bOverreadBlock;
bool bImGraphicReady;
bool bGlobalPalette;
- sal_uInt8 nBackgroundColor; // backgroundcolour
- sal_uInt8 nGCTransparentIndex; // pixelx of this index are transparant
- sal_uInt8 nGCDisposalMethod; // 'Disposal Method' (see GIF docs)
- sal_uInt8 cTransIndex1;
- sal_uInt8 cNonTransIndex1;
+ sal_uInt8 nBackgroundColor; // backgroundcolour
+ sal_uInt8 nGCTransparentIndex; // pixelx of this index are transparant
+ sal_uInt8 nGCDisposalMethod; // 'Disposal Method' (see GIF docs)
+ sal_uInt8 cTransIndex1;
+ sal_uInt8 cNonTransIndex1;
void ReadPaletteEntries( BitmapPalette* pPal, sal_uLong nCount );
void ClearImageExtensions();
@@ -96,7 +96,7 @@ class GIFReader : public GraphicReader
bool ReadGlobalHeader();
bool ReadExtension();
bool ReadLocalHeader();
- sal_uLong ReadNextBlock();
+ sal_uLong ReadNextBlock();
void FillImages( HPBYTE pBytes, sal_uLong nCount );
void CreateNewBitmaps();
bool ProcessGIF();
commit d1af634d18aff741962015dc8118fe10310a9d3c
Author: Norbert Thiebaud <nthiebaud at gmail.com>
Date: Sat Apr 5 23:52:58 2014 -0500
coverity#708318: Unitialized scalar field
Change-Id: I434808d6e6456cb095dab5fbe33ba4df0fd36f34
diff --git a/vcl/source/filter/wmf/winmtf.cxx b/vcl/source/filter/wmf/winmtf.cxx
index e7f6b20..02f2f4c 100644
--- a/vcl/source/filter/wmf/winmtf.cxx
+++ b/vcl/source/filter/wmf/winmtf.cxx
@@ -260,10 +260,11 @@ WinMtfFontStyle::WinMtfFontStyle( LOGFONTW& rFont )
aFont.SetSize( aFontSize );
};
-WinMtf::WinMtf( WinMtfOutput* pWinMtfOutput, SvStream& rStreamWMF, FilterConfigItem* pConfigItem ) :
- pOut ( pWinMtfOutput ),
- pWMF ( &rStreamWMF ),
- pFilterConfigItem ( pConfigItem )
+WinMtf::WinMtf( WinMtfOutput* pWinMtfOutput, SvStream& rStreamWMF, FilterConfigItem* pConfigItem )
+ : pOut( pWinMtfOutput )
+ , pWMF( &rStreamWMF )
+ , nEndPos( 0 )
+ , pFilterConfigItem( pConfigItem )
{
SvLockBytes *pLB = pWMF->GetLockBytes();
if ( pLB )
commit 5ae49784688ebd3a37f65f1c4314ff152ba92d1a
Author: Norbert Thiebaud <nthiebaud at gmail.com>
Date: Sat Apr 5 23:23:22 2014 -0500
coverity#708232: Unitialized scalar field
Change-Id: Iebde4e596975560ae5870ded89a2b51f024e8d39
diff --git a/starmath/source/mathmlimport.cxx b/starmath/source/mathmlimport.cxx
index 7f395b6..5bbd122 100644
--- a/starmath/source/mathmlimport.cxx
+++ b/starmath/source/mathmlimport.cxx
@@ -616,8 +616,13 @@ struct SmXMLContext_Helper
SmXMLImportContext rContext;
- SmXMLContext_Helper(SmXMLImportContext &rImport) :
- nIsBold(-1), nIsItalic(-1), nFontSize(0.0), rContext(rImport) {}
+ SmXMLContext_Helper(SmXMLImportContext &rImport)
+ : nIsBold( -1 )
+ , nIsItalic( -1 )
+ , nFontSize( 0.0 )
+ , bFontNodeNeeded( false )
+ , rContext( rImport )
+ {}
void RetrieveAttrs(const uno::Reference< xml::sax::XAttributeList > &xAttrList );
void ApplyAttrs();
commit 3335880d97a3e1a29c0fa9b7b78272eb8678de0b
Author: Norbert Thiebaud <nthiebaud at gmail.com>
Date: Sat Apr 5 23:21:43 2014 -0500
coverity#708233: Unitialized scalar field
Change-Id: Ifd24c4520f1c445af5443ed8e81bb6c6c47cd64c
diff --git a/starmath/source/mathmlimport.cxx b/starmath/source/mathmlimport.cxx
index 191cdb2..7f395b6 100644
--- a/starmath/source/mathmlimport.cxx
+++ b/starmath/source/mathmlimport.cxx
@@ -1517,8 +1517,10 @@ protected:
public:
SmXMLUnderContext_Impl(SmXMLImport &rImport,sal_uInt16 nPrefix,
- const OUString& rLName)
- : SmXMLSubContext_Impl(rImport,nPrefix,rLName) {}
+ const OUString& rLName)
+ : SmXMLSubContext_Impl(rImport,nPrefix,rLName)
+ , nAttrCount( 0 )
+ {}
void StartElement(const uno::Reference< xml::sax::XAttributeList > &xAttrList ) SAL_OVERRIDE;
void EndElement() SAL_OVERRIDE;
commit 6a615262dc3381b2ab6f2290bccd7bbc2fef913f
Author: Norbert Thiebaud <nthiebaud at gmail.com>
Date: Sat Apr 5 23:20:01 2014 -0500
coverity#708236: Unitialized scalar field
Change-Id: I4d87fb217504b0089df6d572cfa7c0d5426a897c
diff --git a/starmath/source/node.cxx b/starmath/source/node.cxx
index a76e7c5..3d21881 100644
--- a/starmath/source/node.cxx
+++ b/starmath/source/node.cxx
@@ -125,13 +125,18 @@ void SmTmpDevice::SetFont(const Font &rNewFont)
SmNode::SmNode(SmNodeType eNodeType, const SmToken &rNodeToken)
+ : aNodeToken( rNodeToken )
+ , eType( eNodeType )
+ , eScaleMode( SCALE_NONE )
+ , eRectHorAlign( RHA_LEFT )
+ , nFlags( 0 )
+ , nAttributes( 0 )
+ , bIsPhantom( false )
+ , bIsDebug( false )
+ , bIsSelected( false )
+ , nAccIndex( -1 )
+ , aParentNode( NULL )
{
- eType = eNodeType;
- eScaleMode = SCALE_NONE;
- aNodeToken = rNodeToken;
- nAccIndex = -1;
- SetSelected(false);
- aParentNode = NULL;
}
commit 1c48041e731676d2d5b6fdb6176119cd58860a59
Author: Norbert Thiebaud <nthiebaud at gmail.com>
Date: Sat Apr 5 23:10:58 2014 -0500
coverity#708237: Unitialized scalar field
Change-Id: I2536a7a2310aaa95fba7891472f0afe58713014c
diff --git a/starmath/source/parse.cxx b/starmath/source/parse.cxx
index bb4598d..4703a97 100644
--- a/starmath/source/parse.cxx
+++ b/starmath/source/parse.cxx
@@ -2366,7 +2366,12 @@ void SmParser::Error(SmParseError eError)
SmParser::SmParser()
- : m_aDotLoc( LanguageTag::convertToLocale( LANGUAGE_ENGLISH_US ) )
+ : m_nCurError( 0 )
+ , m_nBufferIndex( 0 )
+ , m_nTokenIndex( 0 )
+ , m_Row( 0 )
+ , m_nColOff( 0 )
+ , m_aDotLoc( LanguageTag::convertToLocale( LANGUAGE_ENGLISH_US ) )
{
bImportSymNames = m_bExportSymNames = false;
m_nLang = Application::GetSettings().GetUILanguageTag().getLanguageType();
commit 0b5798ee59b8152b0a917437144e8c078e5feb0a
Author: Norbert Thiebaud <nthiebaud at gmail.com>
Date: Sat Apr 5 23:07:14 2014 -0500
coverity#708246: Unitialized scalar field
Change-Id: I3136db825bea07b4b5977b6067db91375720ebed
diff --git a/svl/source/filerec/filerec.cxx b/svl/source/filerec/filerec.cxx
index bdbad2a..f76aba5 100644
--- a/svl/source/filerec/filerec.cxx
+++ b/svl/source/filerec/filerec.cxx
@@ -604,6 +604,8 @@ SfxMultiRecordReader::SfxMultiRecordReader( SvStream *pStream, sal_uInt16 nTag )
, _nContentSize(0)
, _nContentCount(0)
, _nContentNo(0)
+ , _nContentTag( 0 )
+ , _nContentVer( 0 )
{
// Position im Stream merken, um im Fehlerfall zur"uck-seeken zu k"onnen
_nStartPos = pStream->Tell();
commit ac13f88b5d8b1cf0506fe464bfd8a2a0bd28e849
Author: Norbert Thiebaud <nthiebaud at gmail.com>
Date: Sat Apr 5 23:04:51 2014 -0500
coverity#708257: Unitialized scalar field
Change-Id: Ib46e6f5cb52cd47c4c9914b2f15633f5e6af1fe6
diff --git a/svl/source/misc/strmadpt.cxx b/svl/source/misc/strmadpt.cxx
index 83ea628..7b8dc4e 100644
--- a/svl/source/misc/strmadpt.cxx
+++ b/svl/source/misc/strmadpt.cxx
@@ -92,19 +92,21 @@ public:
SvDataPipe_Impl::SvDataPipe_Impl(sal_uInt32 nThePageSize,
sal_uInt32 nTheMinPages,
- sal_uInt32 nTheMaxPages):
- m_pFirstPage(0),
- m_pReadPage(0),
- m_pWritePage(0),
- m_pReadBuffer(0),
- m_nPageSize(std::min< sal_uInt32 >(
- std::max< sal_uInt32 >(nThePageSize, sal_uInt32(1)),
- sal_uInt32(std::numeric_limits< sal_uInt32 >::max()
- - sizeof (Page) + 1))),
- m_nMinPages(std::max< sal_uInt32 >(nTheMinPages, sal_uInt32(1))),
- m_nMaxPages(std::max< sal_uInt32 >(nTheMaxPages, sal_uInt32(1))),
- m_nPages(0),
- m_bEOF(false)
+ sal_uInt32 nTheMaxPages)
+ : m_pFirstPage( 0 )
+ , m_pReadPage( 0 )
+ , m_pWritePage( 0 )
+ , m_pReadBuffer( 0 )
+ , m_nReadBufferSize( 0 )
+ , m_nReadBufferFilled( 0 )
+ , m_nPageSize(std::min< sal_uInt32 >(
+ std::max< sal_uInt32 >(nThePageSize, sal_uInt32(1)),
+ sal_uInt32(std::numeric_limits< sal_uInt32 >::max()
+ - sizeof (Page) + 1)))
+ , m_nMinPages(std::max< sal_uInt32 >(nTheMinPages, sal_uInt32(1)))
+ , m_nMaxPages(std::max< sal_uInt32 >(nTheMaxPages, sal_uInt32(1)))
+ , m_nPages( 0 )
+ , m_bEOF( false )
{}
inline void SvDataPipe_Impl::setReadBuffer(sal_Int8 * pBuffer,
commit 2e77df68184ab4341407c57c03b67c6f339a5529
Author: Norbert Thiebaud <nthiebaud at gmail.com>
Date: Sat Apr 5 22:58:13 2014 -0500
coverity#708260: Unitialized scalar field
Change-Id: Iffad31bc60748fe58fe3524776dd56e907586342
diff --git a/svl/source/numbers/zformat.cxx b/svl/source/numbers/zformat.cxx
index cb5e494..5d5f9e3 100644
--- a/svl/source/numbers/zformat.cxx
+++ b/svl/source/numbers/zformat.cxx
@@ -582,9 +582,16 @@ enum BracketFormatSymbolType
};
SvNumberformat::SvNumberformat( ImpSvNumberformatScan& rSc, LanguageType eLge )
- : rScan(rSc)
- , nNewStandardDefined(0)
- , bStarFlag( false )
+ : fLimit1(0.0)
+ , fLimit2(0.0)
+ , rScan(rSc)
+ , eOp1(NUMBERFORMAT_OP_NO)
+ , eOp2(NUMBERFORMAT_OP_NO)
+ , nNewStandardDefined(0)
+ , eType(0)
+ , bStarFlag( false )
+ , bStandard( false )
+ , bIsUsed( false )
{
maLocale.meLanguage = eLge;
}
More information about the Libreoffice-commits
mailing list