[Libreoffice-commits] core.git: 2 commits - sw/qa

Tor Lillqvist tml at collabora.com
Tue Apr 8 05:56:31 PDT 2014


 sw/qa/extras/inc/swmodeltestbase.hxx |    8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

New commits:
commit 51c2cbf539427dcee27fb5fd2678f94e684b616f
Author: Tor Lillqvist <tml at collabora.com>
Date:   Tue Apr 8 15:55:40 2014 +0300

    WaE: passing OUString by value, rather pass by reference
    
    Change-Id: I72a1617e54157129bdbfd10f39deaf280006b6c9

diff --git a/sw/qa/extras/inc/swmodeltestbase.hxx b/sw/qa/extras/inc/swmodeltestbase.hxx
index 0f3905b..d5d02d0 100644
--- a/sw/qa/extras/inc/swmodeltestbase.hxx
+++ b/sw/qa/extras/inc/swmodeltestbase.hxx
@@ -124,7 +124,7 @@ public:
     {
         return maFilterOptions;
     }
-    void setFilterOptions(OUString rFilterOptions)
+    void setFilterOptions(const OUString &rFilterOptions)
     {
         maFilterOptions = rFilterOptions;
     }
commit 009db0e3a77a9f0d501f35920dd36234a2491e9c
Author: Tor Lillqvist <tml at collabora.com>
Date:   Tue Apr 8 15:53:46 2014 +0300

    WaE: overriding virtual function declaration not marked 'override'
    
    Change-Id: Ie799cd4a2d9c4c9de70712dbfd5de57944d8ecbc

diff --git a/sw/qa/extras/inc/swmodeltestbase.hxx b/sw/qa/extras/inc/swmodeltestbase.hxx
index d133d73..0f3905b 100644
--- a/sw/qa/extras/inc/swmodeltestbase.hxx
+++ b/sw/qa/extras/inc/swmodeltestbase.hxx
@@ -60,7 +60,7 @@ using namespace css;
 #define DECLARE_SW_ROUNDTRIP_TEST(TestName, filename, BaseClass) \
     class TestName : public BaseClass { \
         protected:\
-    virtual OUString getTestName() { return OUString::createFromAscii(#TestName); }\
+    virtual OUString getTestName() SAL_OVERRIDE { return OUString::createFromAscii(#TestName); } \
         public:\
     CPPUNIT_TEST_SUITE(TestName); \
     CPPUNIT_TEST(Import); \
@@ -81,7 +81,7 @@ using namespace css;
 #define DECLARE_SW_IMPORT_TEST(TestName, filename, BaseClass) \
     class TestName : public BaseClass { \
         protected:\
-    virtual OUString getTestName() { return OUString::createFromAscii(#TestName); }\
+    virtual OUString getTestName() SAL_OVERRIDE { return OUString::createFromAscii(#TestName); } \
         public:\
     CPPUNIT_TEST_SUITE(TestName); \
     CPPUNIT_TEST(Import); \
@@ -98,7 +98,7 @@ using namespace css;
 #define DECLARE_SW_EXPORT_TEST(TestName, filename, BaseClass) \
     class TestName : public BaseClass { \
         protected:\
-    virtual OUString getTestName() { return OUString::createFromAscii(#TestName); }\
+    virtual OUString getTestName() SAL_OVERRIDE { return OUString::createFromAscii(#TestName); } \
         public:\
     CPPUNIT_TEST_SUITE(TestName); \
     CPPUNIT_TEST(Import_Export); \


More information about the Libreoffice-commits mailing list