[Libreoffice-commits] core.git: 7 commits - include/svx sfx2/source svx/source
Caolán McNamara
caolanm at redhat.com
Fri Apr 11 03:21:37 PDT 2014
include/svx/EnhancedCustomShape2d.hxx | 13 +++++++++--
sfx2/source/appl/appdata.cxx | 8 ++++++
sfx2/source/control/shell.cxx | 26 ++++++++++------------
svx/source/customshapes/EnhancedCustomShape3d.cxx | 10 +++++---
svx/source/dialog/frmdirlbox.cxx | 5 ++--
svx/source/engine3d/camera3d.cxx | 5 ++++
6 files changed, 45 insertions(+), 22 deletions(-)
New commits:
commit 7692b91939ea7a816e1dfaa10c36d8fd5cd7a759
Author: Caolán McNamara <caolanm at redhat.com>
Date: Fri Apr 11 11:17:47 2014 +0100
coverity#708353 Uninitialized scalar field
Change-Id: Ic38ed3feacecb36083dfc29898292434cdbb4fe7
diff --git a/svx/source/engine3d/camera3d.cxx b/svx/source/engine3d/camera3d.cxx
index c8f2f22..d131d87 100644
--- a/svx/source/engine3d/camera3d.cxx
+++ b/svx/source/engine3d/camera3d.cxx
@@ -36,6 +36,11 @@ Camera3D::Camera3D(const basegfx::B3DPoint& rPos, const basegfx::B3DPoint& rLook
}
Camera3D::Camera3D()
+ : fResetFocalLength(0.0)
+ , fResetBankAngle(0.0)
+ , fFocalLength(0.0)
+ , fBankAngle(0.0)
+ , bAutoAdjustProjection(false)
{
basegfx::B3DPoint aVector3D(0.0 ,0.0 ,1.0);
Camera3D(aVector3D, basegfx::B3DPoint());
commit 8b219e181ad8453ace3aa712d6e525e5b0bd2819
Author: Caolán McNamara <caolanm at redhat.com>
Date: Fri Apr 11 11:15:06 2014 +0100
coverity#708349 Uninitialized scalar field
Change-Id: I38d3d441d3582915d5baeed249c8874aef27439e
diff --git a/svx/source/dialog/frmdirlbox.cxx b/svx/source/dialog/frmdirlbox.cxx
index 04a8454..f4b9dc5 100644
--- a/svx/source/dialog/frmdirlbox.cxx
+++ b/svx/source/dialog/frmdirlbox.cxx
@@ -38,8 +38,9 @@ inline SvxFrameDirection lclVoidToEnum( void* pDirection )
} // namespace
-FrameDirectionListBox::FrameDirectionListBox( Window* pParent, WinBits nBits ) :
- ListBox( pParent, nBits )
+FrameDirectionListBox::FrameDirectionListBox( Window* pParent, WinBits nBits )
+ : ListBox(pParent, nBits)
+ , meSaveValue(FRMDIR_HORI_LEFT_TOP)
{
}
commit 4a35fed86357eaf83141ae0048d265ea75c47392
Author: Caolán McNamara <caolanm at redhat.com>
Date: Fri Apr 11 11:13:28 2014 +0100
coverity#708341 Uninitialized scalar field
Change-Id: If053235eea2d8f003021de733ea73783cf34ed6d
diff --git a/svx/source/customshapes/EnhancedCustomShape3d.cxx b/svx/source/customshapes/EnhancedCustomShape3d.cxx
index 692bec4..1e3622f 100644
--- a/svx/source/customshapes/EnhancedCustomShape3d.cxx
+++ b/svx/source/customshapes/EnhancedCustomShape3d.cxx
@@ -186,9 +186,12 @@ drawing::Direction3D GetDirection3D( SdrCustomShapeGeometryItem& rItem, const OU
}
EnhancedCustomShape3d::Transformation2D::Transformation2D( const SdrObject* pCustomShape, const Rectangle& /*rBoundRect*/, const double *pM )
-: aCenter( pCustomShape->GetSnapRect().Center() )
-, eProjectionMode( drawing::ProjectionMode_PARALLEL )
-, pMap( pM )
+ : aCenter( pCustomShape->GetSnapRect().Center() )
+ , eProjectionMode( drawing::ProjectionMode_PARALLEL )
+ , fZScreen(0.0)
+ , fOriginX(0.0)
+ , fOriginY(0.0)
+ , pMap( pM )
{
SdrCustomShapeGeometryItem& rGeometryItem = (SdrCustomShapeGeometryItem&)pCustomShape->GetMergedItem( SDRATTR_CUSTOMSHAPE_GEOMETRY );
const OUString sProjectionMode( "ProjectionMode" );
@@ -200,7 +203,6 @@ EnhancedCustomShape3d::Transformation2D::Transformation2D( const SdrObject* pCus
GetSkew( rGeometryItem, fSkew, fSkewAngle );
else
{
- fZScreen = 0.0;
GetOrigin( rGeometryItem, fOriginX, fOriginY );
fOriginX = fOriginX * pCustomShape->GetLogicRect().GetWidth();
fOriginY = fOriginY * pCustomShape->GetLogicRect().GetHeight();
commit 4355ac8c31cf65988ae806097eeb2f5df63c1e8a
Author: Caolán McNamara <caolanm at redhat.com>
Date: Fri Apr 11 11:08:26 2014 +0100
coverity#708338 Uninitialized scalar field
Change-Id: I2c4eb18e6bf140d37a10c8105922e13583dcde41
diff --git a/include/svx/EnhancedCustomShape2d.hxx b/include/svx/EnhancedCustomShape2d.hxx
index 692455a..02c4900 100644
--- a/include/svx/EnhancedCustomShape2d.hxx
+++ b/include/svx/EnhancedCustomShape2d.hxx
@@ -166,8 +166,17 @@ class EnhancedCustomShape2d : public SfxItemSet
com::sun::star::drawing::EnhancedCustomShapeParameter aYRangeMinimum;
com::sun::star::drawing::EnhancedCustomShapeParameter aYRangeMaximum;
- Handle() : bMirroredX ( false ), bMirroredY ( false ), bSwitched( false ),
- nRefX( -1 ), nRefY( -1 ), nRefAngle( -1 ), nRefR( -1 ) {};
+ Handle()
+ : nFlags(0)
+ , bMirroredX ( false )
+ , bMirroredY ( false )
+ , bSwitched( false )
+ , nRefX( -1 )
+ , nRefY( -1 )
+ , nRefAngle( -1 )
+ , nRefR( -1 )
+ {
+ }
};
bool IsFlipVert() { return bFlipV; };
commit 4e0129e79946575741842506e3ac813399631756
Author: Caolán McNamara <caolanm at redhat.com>
Date: Fri Apr 11 11:06:22 2014 +0100
coverity#708157 Uninitialized scalar field
Change-Id: I9d798c8b6472241dc7d16e3d7b52653ad0d76654
diff --git a/sfx2/source/control/shell.cxx b/sfx2/source/control/shell.cxx
index 9c741c8..25b9079 100644
--- a/sfx2/source/control/shell.cxx
+++ b/sfx2/source/control/shell.cxx
@@ -94,7 +94,18 @@ struct SfxShell_Impl: public SfxBroadcaster
com::sun::star::uno::Sequence < com::sun::star::embed::VerbDescriptor > aVerbList;
::sfx2::sidebar::ContextChangeBroadcaster maContextChangeBroadcaster;
- SfxShell_Impl() : pViewSh(0), pFrame(0), pRepeatTarget(0), pExecuter(0), pUpdater(0) {}
+ SfxShell_Impl()
+ : pViewSh(0)
+ , pFrame(0)
+ , pRepeatTarget(0)
+ , bActive(false)
+ , nDisableFlags(0)
+ , nHelpId(0)
+ , pExecuter(0)
+ , pUpdater(0)
+ {
+ }
+
virtual ~SfxShell_Impl() { delete pExecuter; delete pUpdater;}
};
@@ -124,12 +135,6 @@ SfxShell::SfxShell()
pUndoMgr(0)
{
pImp = new SfxShell_Impl;
- pImp->pViewSh = 0;
- pImp->pFrame = 0;
- pImp->pRepeatTarget = 0;
- pImp->nHelpId = 0L;
- pImp->bActive = false;
- pImp->nDisableFlags = 0;
}
@@ -149,10 +154,6 @@ SfxShell::SfxShell( SfxViewShell *pViewSh )
{
pImp = new SfxShell_Impl;
pImp->pViewSh = pViewSh;
- pImp->pFrame = 0;
- pImp->pRepeatTarget = 0;
- pImp->nHelpId = 0L;
- pImp->bActive = false;
}
commit 39ae696f1e8db42f42a45c35b8f0200cf5e6354c
Author: Caolán McNamara <caolanm at redhat.com>
Date: Fri Apr 11 11:04:20 2014 +0100
unused bInAppBASIC member
Change-Id: If7adfb573e4a7605953a2561fd280a5bc22b02fd
diff --git a/sfx2/source/control/shell.cxx b/sfx2/source/control/shell.cxx
index badc24f..9c741c8 100644
--- a/sfx2/source/control/shell.cxx
+++ b/sfx2/source/control/shell.cxx
@@ -84,7 +84,6 @@ struct SfxShell_Impl: public SfxBroadcaster
// ViewFrame/ViewShell/SubShell list
SfxViewFrame* pFrame; // Frame, if <UI-active>
SfxRepeatTarget* pRepeatTarget; // SbxObjectRef xParent;
- bool bInAppBASIC;
bool bActive;
sal_uIntPtr nDisableFlags;
sal_uIntPtr nHelpId;
@@ -128,7 +127,6 @@ SfxShell::SfxShell()
pImp->pViewSh = 0;
pImp->pFrame = 0;
pImp->pRepeatTarget = 0;
- pImp->bInAppBASIC = false;
pImp->nHelpId = 0L;
pImp->bActive = false;
pImp->nDisableFlags = 0;
@@ -153,7 +151,6 @@ SfxShell::SfxShell( SfxViewShell *pViewSh )
pImp->pViewSh = pViewSh;
pImp->pFrame = 0;
pImp->pRepeatTarget = 0;
- pImp->bInAppBASIC = false;
pImp->nHelpId = 0L;
pImp->bActive = false;
}
commit 04148c6fbded5d52c1dba7c1741622537b0d70e2
Author: Caolán McNamara <caolanm at redhat.com>
Date: Fri Apr 11 11:01:54 2014 +0100
coverity#738831 Uninitialized pointer field
Change-Id: I9de07f4fe8b9919ec2a7e83019b5131647e552c1
diff --git a/sfx2/source/appl/appdata.cxx b/sfx2/source/appl/appdata.cxx
index 82f4c2d..81d8e60 100644
--- a/sfx2/source/appl/appdata.cxx
+++ b/sfx2/source/appl/appdata.cxx
@@ -88,6 +88,11 @@ SfxAppData_Impl::SfxAppData_Impl( SfxApplication* )
, pBasicResMgr( 0 )
#endif
, pSvtResMgr( 0 )
+ , m_pToolsErrorHdl(0)
+ , m_pSoErrorHdl(0)
+#ifndef DISABLE_SCRIPTING
+ , m_pSbxErrorHdl(0)
+#endif
, pAppDispatch(NULL)
, pTemplates( 0 )
, pPool(0)
@@ -102,7 +107,9 @@ SfxAppData_Impl::SfxAppData_Impl( SfxApplication* )
, m_xImeStatusWindow(new sfx2::appl::ImeStatusWindow(comphelper::getProcessComponentContext()))
, pTbxCtrlFac(0)
, pStbCtrlFac(0)
+ , pMenuCtrlFac(0)
, pViewFrames(0)
+ , pViewShells(0)
, pObjShells(0)
, pSfxResManager(0)
, pOfaResMgr(0)
@@ -114,6 +121,7 @@ SfxAppData_Impl::SfxAppData_Impl( SfxApplication* )
, pInterfaces( 0 )
, nDocNo(0)
, nInterfaces( 0 )
+ , bDispatcherLocked( false )
, bDowning( true )
, bInQuit( false )
, bInvalidateOnUnlock( false )
More information about the Libreoffice-commits
mailing list